From 4fd09f900a218c3cb61a2b015b03dcbd6f96b600 Mon Sep 17 00:00:00 2001 From: Kulikov Vasiliy Date: Mon, 9 Aug 2010 23:52:06 +0400 Subject: staging: spectra: call disable_pci_device() if pci_probe() failed Driver should call disable_pci_device() if it returns from pci_probe() with error. Signed-off-by: Kulikov Vasiliy Signed-off-by: Greg Kroah-Hartman --- drivers/staging/spectra/lld_nand.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) (limited to 'drivers/staging/spectra') diff --git a/drivers/staging/spectra/lld_nand.c b/drivers/staging/spectra/lld_nand.c index 13c3ad2..0d647a8f 100644 --- a/drivers/staging/spectra/lld_nand.c +++ b/drivers/staging/spectra/lld_nand.c @@ -2411,13 +2411,15 @@ static int nand_pci_probe(struct pci_dev *dev, const struct pci_device_id *id) csr_base = pci_resource_start(dev, 0); if (!csr_base) { printk(KERN_ERR "Spectra: pci_resource_start failed!\n"); - return -ENODEV; + ret = -ENODEV; + goto failed_req_csr; } csr_len = pci_resource_len(dev, 0); if (!csr_len) { printk(KERN_ERR "Spectra: pci_resource_len failed!\n"); - return -ENODEV; + ret = -ENODEV; + goto failed_req_csr; } ret = pci_request_regions(dev, SPECTRA_NAND_NAME); @@ -2464,6 +2466,7 @@ static int nand_pci_probe(struct pci_dev *dev, const struct pci_device_id *id) failed_remap_csr: pci_release_regions(dev); failed_req_csr: + pci_disable_device(dev); return ret; } -- cgit v1.1 From 0e324fbdb7146dbe88e979e88263c548d8f54f1c Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig?= Date: Wed, 1 Sep 2010 15:40:26 +0200 Subject: staging/trivial: fix typos concerning "management" MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Signed-off-by: Uwe Kleine-König Signed-off-by: Greg Kroah-Hartman --- drivers/staging/spectra/flash.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'drivers/staging/spectra') diff --git a/drivers/staging/spectra/flash.h b/drivers/staging/spectra/flash.h index 5ed0580..e59cf4e 100644 --- a/drivers/staging/spectra/flash.h +++ b/drivers/staging/spectra/flash.h @@ -104,7 +104,7 @@ struct flash_cache_tag { }; /* - *Data structure for each list node of the managment table + *Data structure for each list node of the management table * used for the Level 2 Cache. Each node maps one logical NAND block. */ struct spectra_l2_cache_list { -- cgit v1.1 From 10b476a2fcc99fd0dab107e39a8aa5777560609c Mon Sep 17 00:00:00 2001 From: Andrea Gelmini Date: Wed, 1 Sep 2010 11:08:55 +0200 Subject: staging: spectra: Kconfig: add missing '.' All help messages end with full stop. Signed-off-by: Andrea Gelmini Signed-off-by: Greg Kroah-Hartman --- drivers/staging/spectra/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'drivers/staging/spectra') diff --git a/drivers/staging/spectra/Kconfig b/drivers/staging/spectra/Kconfig index 5e2ffef..67f7a37 100644 --- a/drivers/staging/spectra/Kconfig +++ b/drivers/staging/spectra/Kconfig @@ -5,7 +5,7 @@ menuconfig SPECTRA default n ---help--- Enable the FTL pseudo-filesystem used with the NAND Flash - controller on Intel Moorestown Platform to pretend to be a disk + controller on Intel Moorestown Platform to pretend to be a disk. choice prompt "Compile for" -- cgit v1.1 From 340362abb9544043d41e047c63d86dffe990a48c Mon Sep 17 00:00:00 2001 From: Vasiliy Kulikov Date: Sun, 19 Sep 2010 16:54:40 +0400 Subject: staging: spectra: off by one g_pBlockTable has only DeviceInfo.wDataBlockNum elements. Signed-off-by: Vasiliy Kulikov Signed-off-by: Greg Kroah-Hartman --- drivers/staging/spectra/flash.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'drivers/staging/spectra') diff --git a/drivers/staging/spectra/flash.c b/drivers/staging/spectra/flash.c index 9b5218b..4e6e451 100644 --- a/drivers/staging/spectra/flash.c +++ b/drivers/staging/spectra/flash.c @@ -1604,7 +1604,7 @@ static int get_l2_cache_blks(void) for (n = 0; n < BLK_NUM_FOR_L2_CACHE; n++) { blk = find_least_worn_blk_for_l2_cache(); - if (blk > DeviceInfo.wDataBlockNum) { + if (blk >= DeviceInfo.wDataBlockNum) { nand_dbg_print(NAND_DBG_WARN, "find_least_worn_blk_for_l2_cache: " "No enough free NAND blocks (n: %d) for L2 Cache!\n", n); -- cgit v1.1 From e80302977017e5cbb12fdf843e5a070ad5d11e3a Mon Sep 17 00:00:00 2001 From: Nicolas Kaiser Date: Mon, 4 Oct 2010 14:10:45 +0200 Subject: staging: spectra: remove duplicated includes Remove duplicated includes. Signed-off-by: Nicolas Kaiser Signed-off-by: Greg Kroah-Hartman --- drivers/staging/spectra/lld_emu.c | 10 ++++------ drivers/staging/spectra/lld_mtd.c | 8 ++------ 2 files changed, 6 insertions(+), 12 deletions(-) (limited to 'drivers/staging/spectra') diff --git a/drivers/staging/spectra/lld_emu.c b/drivers/staging/spectra/lld_emu.c index 60eb0f6f..6733bbf 100644 --- a/drivers/staging/spectra/lld_emu.c +++ b/drivers/staging/spectra/lld_emu.c @@ -25,6 +25,10 @@ #include "lld.h" #if CMD_DMA #include "lld_cdma.h" +#if FLASH_EMU +u32 totalUsedBanks; +u32 valid_banks[MAX_CHANS]; +#endif #endif #define GLOB_LLD_PAGES 64 @@ -32,12 +36,6 @@ #define GLOB_LLD_PAGE_DATA_SIZE 512 #define GLOB_LLD_BLOCKS 2048 -#if (CMD_DMA && FLASH_EMU) -#include "lld_cdma.h" -u32 totalUsedBanks; -u32 valid_banks[MAX_CHANS]; -#endif - #if FLASH_EMU /* This is for entire module */ static u8 *flash_memory[GLOB_LLD_BLOCKS * GLOB_LLD_PAGES]; diff --git a/drivers/staging/spectra/lld_mtd.c b/drivers/staging/spectra/lld_mtd.c index 0de05b1..2bd3466 100644 --- a/drivers/staging/spectra/lld_mtd.c +++ b/drivers/staging/spectra/lld_mtd.c @@ -26,6 +26,8 @@ #include "lld.h" #if CMD_DMA #include "lld_cdma.h" +u32 totalUsedBanks; +u32 valid_banks[MAX_CHANS]; #endif #define GLOB_LLD_PAGES 64 @@ -33,12 +35,6 @@ #define GLOB_LLD_PAGE_DATA_SIZE 512 #define GLOB_LLD_BLOCKS 2048 -#if CMD_DMA -#include "lld_cdma.h" -u32 totalUsedBanks; -u32 valid_banks[MAX_CHANS]; -#endif - static struct mtd_info *spectra_mtd; static int mtddev = -1; module_param(mtddev, int, 0); -- cgit v1.1