From d6906e7efa8071f911fd92a35cec57473bca3074 Mon Sep 17 00:00:00 2001 From: Markus Elfring Date: Wed, 7 Feb 2018 19:47:48 +0000 Subject: parport: ax88796: Delete an error message for a failed memory allocation in parport_ax88796_probe() Omit an extra message for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring Signed-off-by: Sudip Mukherjee Signed-off-by: Greg Kroah-Hartman --- drivers/parport/parport_ax88796.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) (limited to 'drivers/parport/parport_ax88796.c') diff --git a/drivers/parport/parport_ax88796.c b/drivers/parport/parport_ax88796.c index 2fc91ed..ef0aec4 100644 --- a/drivers/parport/parport_ax88796.c +++ b/drivers/parport/parport_ax88796.c @@ -281,10 +281,8 @@ static int parport_ax88796_probe(struct platform_device *pdev) int ret; dd = kzalloc(sizeof(struct ax_drvdata), GFP_KERNEL); - if (dd == NULL) { - dev_err(_dev, "no memory for private data\n"); + if (!dd) return -ENOMEM; - } res = platform_get_resource(pdev, IORESOURCE_MEM, 0); if (res == NULL) { -- cgit v1.1 From 5e50654da591efecb02fd9dab032152e4c5d0ca2 Mon Sep 17 00:00:00 2001 From: Markus Elfring Date: Wed, 7 Feb 2018 19:47:49 +0000 Subject: parport: ax88796: Improve a size determination in parport_ax88796_probe() Replace the specification of a data structure by a pointer dereference as the parameter for the operator "sizeof" to make the corresponding size determination a bit safer according to the Linux coding style convention. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring Signed-off-by: Sudip Mukherjee Signed-off-by: Greg Kroah-Hartman --- drivers/parport/parport_ax88796.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'drivers/parport/parport_ax88796.c') diff --git a/drivers/parport/parport_ax88796.c b/drivers/parport/parport_ax88796.c index ef0aec4..09788d8 100644 --- a/drivers/parport/parport_ax88796.c +++ b/drivers/parport/parport_ax88796.c @@ -280,7 +280,7 @@ static int parport_ax88796_probe(struct platform_device *pdev) int irq; int ret; - dd = kzalloc(sizeof(struct ax_drvdata), GFP_KERNEL); + dd = kzalloc(sizeof(*dd), GFP_KERNEL); if (!dd) return -ENOMEM; -- cgit v1.1 From 520656c03c545011d1da702a261e2c782808b79f Mon Sep 17 00:00:00 2001 From: Markus Elfring Date: Wed, 7 Feb 2018 19:47:50 +0000 Subject: parport: ax88796: Delete an unnecessary variable initialisation in parport_ax88796_probe() The local variable "pp" will eventually be set to an appropriate pointer a bit later. Thus omit the explicit initialisation at the beginning. Signed-off-by: Markus Elfring Signed-off-by: Sudip Mukherjee Signed-off-by: Greg Kroah-Hartman --- drivers/parport/parport_ax88796.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'drivers/parport/parport_ax88796.c') diff --git a/drivers/parport/parport_ax88796.c b/drivers/parport/parport_ax88796.c index 09788d8..bfe97c2 100644 --- a/drivers/parport/parport_ax88796.c +++ b/drivers/parport/parport_ax88796.c @@ -273,7 +273,7 @@ static int parport_ax88796_probe(struct platform_device *pdev) { struct device *_dev = &pdev->dev; struct ax_drvdata *dd; - struct parport *pp = NULL; + struct parport *pp; struct resource *res; unsigned long size; int spacing; -- cgit v1.1