From 5de3bbc8501b637eb753e4ee18a2cccb233cfe41 Mon Sep 17 00:00:00 2001 From: Michal Suchanek Date: Sun, 26 Jun 2016 22:11:58 +0200 Subject: of: overlay: add resolver error prints Applying overlay fails silently in case of an error. Add error prints. Most notably the lack of symbols in the live tree is not reported. Signed-off-by: Michal Suchanek Signed-off-by: Rob Herring --- drivers/of/resolver.c | 6 ++++++ 1 file changed, 6 insertions(+) (limited to 'drivers/of') diff --git a/drivers/of/resolver.c b/drivers/of/resolver.c index 7414611..46325d6 100644 --- a/drivers/of/resolver.c +++ b/drivers/of/resolver.c @@ -315,6 +315,11 @@ int of_resolve_phandles(struct device_node *resolve) phandle phandle, phandle_delta; int err; + if (!resolve) + pr_err("%s: null node\n", __func__); + if (resolve && !of_node_check_flag(resolve, OF_DETACHED)) + pr_err("%s: node %s not detached\n", __func__, + resolve->full_name); /* the resolve node must exist, and be detached */ if (!resolve || !of_node_check_flag(resolve, OF_DETACHED)) return -EINVAL; @@ -371,6 +376,7 @@ int of_resolve_phandles(struct device_node *resolve) /* we need to fixup, but no root symbols... */ if (!root_sym) { + pr_err("%s: no symbols in root of device tree.\n", __func__); err = -EINVAL; goto out; } -- cgit v1.1