From c46ca3c8310b61d253a39ff1375ea97912794cd1 Mon Sep 17 00:00:00 2001 From: Markus Elfring Date: Tue, 2 Dec 2014 13:54:00 +0100 Subject: of: Delete unnecessary check before calling "of_node_put()" The of_node_put() function tests whether its argument is NULL and then returns immediately. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring Signed-off-by: Grant Likely --- drivers/of/unittest.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/of/unittest.c b/drivers/of/unittest.c index 1807a04..844838e 100644 --- a/drivers/of/unittest.c +++ b/drivers/of/unittest.c @@ -516,8 +516,7 @@ static void __init of_selftest_changeset(void) /* Make sure node names are constructed correctly */ selftest((np = of_find_node_by_path("/testcase-data/changeset/n2/n21")), "'%s' not added\n", n21->full_name); - if (np) - of_node_put(np); + of_node_put(np); mutex_lock(&of_mutex); selftest(!of_changeset_revert(&chgset), "revert failed\n"); -- cgit v1.1