summaryrefslogtreecommitdiffstats
path: root/drivers
Commit message (Collapse)AuthorAgeFilesLines
* 3c523: fix warning in drivers/net/3c523.cIngo Molnar2008-11-251-2/+2
| | | | | | | | | | | | | | | fix warning: drivers/net/3c523.c:582: warning: ‘cleanup_card’ defined but not used No code changed: md5: ebe4a1b27d3f21b0b12a78c58463b0d7 3c523.o.before.asm ebe4a1b27d3f21b0b12a78c58463b0d7 3c523.o.after.asm Signed-off-by: Ingo Molnar <mingo@elte.hu> Signed-off-by: David S. Miller <davem@davemloft.net>
* depca: fix warning in drivers/net/depca.cIngo Molnar2008-11-251-1/+6
| | | | | | | | | | | | | fix warning: drivers/net/depca.c: In function ‘depca_eisa_probe’: drivers/net/depca.c:1564: warning: ‘mem_start’ may be used uninitialized in this function this seems to be a real bug - depca_eisa_probe() does not check for failure. Add it, symmetric to depca_isa_probe(). Signed-off-by: Ingo Molnar <mingo@elte.hu> Signed-off-by: David S. Miller <davem@davemloft.net>
* atlx: fix warning in drivers/net/atlx/atl2.cIngo Molnar2008-11-251-2/+0
| | | | | | | | | | | | | | | | | | | fix this warning: drivers/net/atlx/atl2.c: In function ‘atl2_request_irq’: drivers/net/atlx/atl2.c:644: warning: unused variable ‘err’ 'err' is unused in the !CONFIG_PCI_MSI case. Instead of further increasing the #ifdeffery in this function, restructure the code a bit and get rid of the #ifdef. This relies on the fact that pci_enable_msi() will always fail in the !CONFIG_PCI_MSI case. There should be no change in driver behavior. Signed-off-by: Ingo Molnar <mingo@elte.hu> Signed-off-by: David S. Miller <davem@davemloft.net>
* mlx4: fix warning in drivers/net/mlx4/mcg.cIngo Molnar2008-11-251-1/+1
| | | | | | | | | | | | | | | | fix warning: drivers/net/mlx4/mcg.c: In function ‘mlx4_multicast_attach’: drivers/net/mlx4/mcg.c:217: warning: integer overflow in expression there was no real danger of overflow here though. md5: db8eb55620f886c03854a2abb2ce6c3f mcg.o.before.asm db8eb55620f886c03854a2abb2ce6c3f mcg.o.after.asm Signed-off-by: Ingo Molnar <mingo@elte.hu> Signed-off-by: David S. Miller <davem@davemloft.net>
* cassini: fix warning in drivers/net/cassini.cIngo Molnar2008-11-251-1/+1
| | | | | | | | | | | | | | | this warning: drivers/net/cassini.c: In function ‘cas_rx_ringN’: drivers/net/cassini.c:2350: warning: ‘skb’ may be used uninitialized in this function triggers because GCC does not recognize the (correct) error flow between cas_rx_process_pkt() and 'skb'. Annotate it. Signed-off-by: Ingo Molnar <mingo@elte.hu> Signed-off-by: David S. Miller <davem@davemloft.net>
* mlx4: fix error path in drivers/net/mlx4/en_rx.cIngo Molnar2008-11-251-1/+2
| | | | | | | | | | | | | | | | | | | | | this warning: drivers/net/mlx4/en_rx.c: In function ‘mlx4_en_activate_rx_rings’: drivers/net/mlx4/en_rx.c:412: warning: ‘err’ may be used uninitialized in this function Triggers because 'err' is uninitialized in the following input conditions: priv->rx_ring_num is zero and mlx4_en_fill_rx_buffers() fails. But even if ->rx_ring_num is nonzero, 'err' will be zero if mlx4_en_fill_rx_buffers() fails and mlx4_en_activate_rx_rings() returns success - incorrectly. So it's best to keep the error code uptodate on mlx4_en_fill_rx_buffers() calls as well. Signed-off-by: Ingo Molnar <mingo@elte.hu> Signed-off-by: David S. Miller <davem@davemloft.net>
* z85230: fix warning in drivers/net/wan/z85230.cIngo Molnar2008-11-251-1/+1
| | | | | | | | | | | | | this warning: drivers/net/wan/z85230.c: In function ‘z8530_interrupt’: drivers/net/wan/z85230.c:713: warning: ‘intr’ may be used uninitialized in this function is clearly bogus - annotate it. Signed-off-by: Ingo Molnar <mingo@elte.hu> Signed-off-by: David S. Miller <davem@davemloft.net>
* sis900: fix warning in drivers/net/sis900.cIngo Molnar2008-11-251-1/+1
| | | | | | | | | | | | | | | this warning: drivers/net/sis900.c: In function ‘sis900_timer’: drivers/net/sis900.c:1280: warning: ‘speed’ may be used uninitialized in this function triggers because GCC does not recognize the (correct) error flow between sis900_read_mode(), 'speed' and 'duplex'. Annotate it. Signed-off-by: Ingo Molnar <mingo@elte.hu> Signed-off-by: David S. Miller <davem@davemloft.net>
* qla3xxx: fix warning in drivers/net/qla3xxx.cIngo Molnar2008-11-251-1/+1
| | | | | | | | | | | | | | | this warning: drivers/net/qla3xxx.c: In function ‘ql3xxx_probe’: drivers/net/qla3xxx.c:3912: warning: ‘pci_using_dac’ may be used uninitialized in this function triggers because GCC does not recognize the (correct) error flow between 'pci_using_dac' and 'err'. Annotate it. Signed-off-by: Ingo Molnar <mingo@elte.hu> Signed-off-by: David S. Miller <davem@davemloft.net>
* niu: fix another warning in drivers/net/niu.cIngo Molnar2008-11-251-1/+1
| | | | | | | | | | | | | | | | | this warning: drivers/net/niu.c: In function ‘esr_reset’: drivers/net/niu.c:741: warning: ‘reset’ may be used uninitialized in this function triggers because GCC does not recognize the (correct) error flow between: - esr_read_reset() and 'reset' Annotate it. Signed-off-by: Ingo Molnar <mingo@elte.hu> Signed-off-by: David S. Miller <davem@davemloft.net>
* niu: fix warnings in drivers/net/niu.cIngo Molnar2008-11-251-2/+2
| | | | | | | | | | | | | | | | | these warnings: drivers/net/niu.c: In function ‘serdes_init_niu_1g_serdes’: drivers/net/niu.c:451: warning: ‘sig’ may be used uninitialized in this function drivers/net/niu.c: In function ‘serdes_init_niu_10g_serdes’: drivers/net/niu.c:550: warning: ‘sig’ may be used uninitialized in this function triggers because GCC does not recognize that the max_retry loop always initializes 'sig', due to max_retry != 0. Annotate them. Signed-off-by: Ingo Molnar <mingo@elte.hu> Signed-off-by: David S. Miller <davem@davemloft.net>
* s2io: fix warning in drivers/net/s2io.cIngo Molnar2008-11-251-1/+1
| | | | | | | | | | | | | | | | | this warning: drivers/net/s2io.c: In function ‘rx_intr_handler’: drivers/net/s2io.c:7369: warning: ‘lro’ may be used uninitialized in this function triggers because GCC does not recognize the (correct) error flow between: - s2io_club_tcp_session()and 'lro' Annotate it. Signed-off-by: Ingo Molnar <mingo@elte.hu> Signed-off-by: David S. Miller <davem@davemloft.net>
* ixgbe: Naming interrupt vectorsRobert Olsson2008-11-251-4/+14
| | | | | | Signed-off-by: Robert Olsson <robert.olsson@its.uu.se> Acked-by: Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com> Signed-off-by: David S. Miller <davem@davemloft.net>
* niu: Naming interrupt vectors.Robert Olsson2008-11-252-1/+27
| | | | | | | | | | | | | | | | | A patch to put names on the niu interrupt vectors according the syntax below. This is needed to assign correct affinity. > So on a multiqueue card with 2 RX queues and 2 TX queues we'd > have names like: > > eth0-rx-0 > eth0-rx-1 > eth0-tx-0 > eth0-tx-1 Signed-off-by: Robert Olsson <robert.olsson@its.uu.se> Tested-by: Jesper Dangaard Brouer <jdb@comx.dk> Signed-off-by: David S. Miller <davem@davemloft.net>
* Revert "hso: Fix crashes on close."David S. Miller2008-11-251-9/+2
| | | | | | | | This reverts commit 4a3e818181e1baf970e9232ca8b747e233176b87. On request from Alan Cox. Signed-off-by: David S. Miller <davem@davemloft.net>
* Revert "hso: Fix free of mutexes still in use."David S. Miller2008-11-251-87/+23
| | | | | | | | This reverts commit 52429eb216385fdc6969c0112ba8b46cffefaaef. On request from Alan Cox. Signed-off-by: David S. Miller <davem@davemloft.net>
* Revert "hso: Add TIOCM ioctl handling."David S. Miller2008-11-251-317/+12
| | | | | | | | This reverts commit 7ea3a9ad9bf360f746a7ad6fa72511a5c359490d. On request from Alan Cox. Signed-off-by: David S. Miller <davem@davemloft.net>
* igb: loopback bits not correctly cleared from RCTL registerAlexander Duyck2008-11-252-3/+4
| | | | | | | | | This change forces the bits to 0 by using an &= operation with an inverted mask of all options instead of using an |= with a value of 0. Signed-off-by: Alexander Duyck <alexander.h.duyck@intel.com> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com> Signed-off-by: David S. Miller <davem@davemloft.net>
* igb: remove unneeded bit refrence when enabling jumbo framesAlexander Duyck2008-11-252-20/+6
| | | | | | | | | | There is a reference to a Buffer Size extention bit that is unneded by 82575/82576 hardware. Since it is not needed it should be removed from the code. Signed-off-by: Alexander Duyck <alexander.h.duyck@intel.com> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com> Signed-off-by: David S. Miller <davem@davemloft.net>
* DCB: fix kconfig optionJeff Kirsher2008-11-254-9/+9
| | | | | | | | | Since the netlink option for DCB is necessary to actually be useful, simplified the Kconfig option. In addition, added useful help text for the Kconfig option. Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com> Signed-off-by: David S. Miller <davem@davemloft.net>
* aoe: remove private mac address format functionHarvey Harrison2008-11-254-25/+11
| | | | | | | Add %pm to omit the colons when printing a mac address. Signed-off-by: Harvey Harrison <harvey.harrison@gmail.com> Signed-off-by: David S. Miller <davem@davemloft.net>
* hso: Hook up ->reset_resumeDenis Joseph Barrow2008-11-251-0/+1
| | | | | | | | | | Made usb_drivers reset_resume function point to hso_resume this fixes problems a usb reset is done when the network interface is left idle for a few minutes. Possibly reset_resume should initialise hardware more but this works in the common case. Signed-off-by: Denis Joseph Barrow <D.Barow@option.com> Signed-off-by: David S. Miller <davem@davemloft.net>
* hso: Add TIOCM ioctl handling.Denis Joseph Barrow2008-11-251-12/+317
| | | | | | | | | Makes TIOCM ioctls for Data Carrier Detect & related functions work like /drivers/serial/serial-core.c potentially needed for pppd & similar user programs. Signed-off-by: Denis Joseph Barrow <D.Barow@option.com> Signed-off-by: David S. Miller <davem@davemloft.net>
* hso: Fix free of mutexes still in use.Denis Joseph Barrow2008-11-251-23/+87
| | | | | | | | | | | | | A new structure hso_mutex_table had to be declared statically & used as as hso_device mutex_lock(&serial->parent->mutex) etc is freed in hso_serial_open & hso_serial_close by kref_put while the mutex is still in use. This is a substantial change but should make the driver much stabler. Signed-off-by: Denis Joseph Barrow <D.Barow@option.com> Signed-off-by: David S. Miller <davem@davemloft.net>
* hso: Fix URB submission -EINVAL.Denis Joseph Barrow2008-11-251-11/+14
| | | | | | | | | Added check for IFF_UP in hso_resume, this should eliminate -EINVAL (-22) errors caused from urb's being submitted twice, once by hso_resume & once in hso_net_open, if suspend/resume USB power saving mode is enabled Signed-off-by: Denis Joseph Barrow <D.Barow@option.com> Signed-off-by: David S. Miller <davem@davemloft.net>
* hso: Fix crashes on close.Denis Joseph Barrow2008-11-251-2/+9
| | | | | | | | | | | | | | Moved serial_open_count in hso_serial_open to prevent crashes owing to the serial structure being made NULL when hso_serial_close is called even though hso_serial_open returned -ENODEV, Alan Cox pointed out this happens, also put in sanity check in hso_serial_close to check for a valid serial structure which should prevent the most reproducable crash in the driver when the hso device is disconnected while in use. Signed-off-by: Denis Joseph Barrow <D.Barow@option.com> Signed-off-by: David S. Miller <davem@davemloft.net>
* hso: Add new usb device id's.Denis Joseph Barrow2008-11-251-0/+5
| | | | | Signed-off-by: Denis Joseph Barrow <D.Barow@option.com> Signed-off-by: David S. Miller <davem@davemloft.net>
* infiniband: Kill directly reference of netdev->privWang Chen2008-11-241-4/+4
| | | | | | | | | | | This use of netdev->priv is wrong. The right way is: alloc_netdev() with no memory for private data. make netdev->ml_priv to point to c2_dev. Signed-off-by: Wang Chen <wangchen@cn.fujitsu.com> Acked-by: Roland Dreier <rolandd@cisco.com> Signed-off-by: David S. Miller <davem@davemloft.net>
* netdevice sbni: Convert directly reference of netdev->privWang Chen2008-11-241-47/+52
| | | | | | | | 1. convert netdev->priv to netdev_priv(). 2. make sbni_pci_probe() be static. Signed-off-by: Wang Chen <wangchen@cn.fujitsu.com> Signed-off-by: David S. Miller <davem@davemloft.net>
* tokenring/3c359.c: Prevent possible mem leak when open failedJirka Pirko2008-11-241-0/+2
| | | | | | | Freeing previously allocated buffers in case of error. Signed-off-by: Jirka Pirko <jirka@pirko.cz> Signed-off-by: David S. Miller <davem@davemloft.net>
* tokenring/3c359.c: Fix error message when allocating tx_ringJirka Pirko2008-11-241-1/+1
| | | | | | | | Pointed out by Joe Perches. Error message after tx_ring allocation check was wrong. Signed-off-by: Jirka Pirko <jirka@jirka.pirko.cz> Signed-off-by: David S. Miller <davem@davemloft.net>
* tokenring/3c359.c: fix allocation null checkJirka Pirko2008-11-241-1/+1
| | | | | | | Fixed typo when allocating rx_ring, tx_ring was checked for null instead. Signed-off-by: Jirka Pirko <jirka@pirko.cz> Signed-off-by: David S. Miller <davem@davemloft.net>
* 8139too: use err.h macrosStephen Hemminger2008-11-241-11/+7
| | | | | | | | Instead of using call by reference use the PTR_ERR macros to handle return value with error case. Compile tested only. Signed-off-by: Stephen Hemminger <shemminger@vyatta.com> Signed-off-by: David S. Miller <davem@davemloft.net>
* axnet_cs: Fix build after net device ops ne2k conversion.David S. Miller2008-11-231-8/+8
| | | | | | | | | | | | | Commit 4e4fd4e485ad63a9074ff09a9b53ffc7a5c594ec ("ne2k: convert to net_device_ops") exported some ei_* symbols from the 8390 library, but the axnet_cs driver defines local static versions of the same functions. Rename them to avoid the namespace conflict. Reported by Stephen Rothwell. Signed-off-by: David S. Miller <davem@davemloft.net>
* myri10ge: update firmware headersBrice Goglin2008-11-231-0/+1
| | | | | | | Update myri10ge firmware headers. Signed-off-by: Brice Goglin <brice@myri.com> Signed-off-by: David S. Miller <davem@davemloft.net>
* myri10ge: update DCA commentsBrice Goglin2008-11-231-3/+3
| | | | | | | Update DCA sections closing comments. Signed-off-by: Brice Goglin <brice@myri.com> Signed-off-by: David S. Miller <davem@davemloft.net>
* Merge branch 'for-david' of ↵David S. Miller2008-11-219-1857/+1374
|\ | | | | | | git://git.kernel.org/pub/scm/linux/kernel/git/chris/linux-2.6
| * WAN pc300too.c: Fix PC300-X.21 detectionKrzysztof Hałasa2008-11-221-24/+24
| | | | | | | | | | | | | | pc300too driver works around a bug in PCI9050 bridge. Unfortunately it was doing that too late. Signed-off-by: Krzysztof Hałasa <khc@pm.waw.pl>
| * WAN: syncppp.c is no longer used by any kernel code. Remove it.Krzysztof Hałasa2008-11-221-1476/+0
| | | | | | | | Signed-off-by: Krzysztof Hałasa <khc@pm.waw.pl>
| * WAN: new synchronous PPP implementation for generic HDLC.Krzysztof Hałasa2008-11-222-48/+602
| | | | | | | | Signed-off-by: Krzysztof Hałasa <khc@pm.waw.pl>
| * WAN: Simplify sca_init_port() in HD64572 driver.Krzysztof Hałasa2008-11-221-36/+31
| | | | | | | | Signed-off-by: Krzysztof Hałasa <khc@pm.waw.pl>
| * WAN: Correct comments in hd6457[02].cKrzysztof Hałasa2008-11-222-2/+2
| | | | | | | | Signed-off-by: Krzysztof Hałasa <khc@pm.waw.pl>
| * WAN: HD64572 drivers don't use next_desc() anymore.Krzysztof Hałasa2008-11-221-10/+3
| | | | | | | | Signed-off-by: Krzysztof Hałasa <khc@pm.waw.pl>
| * WAN: Simplify HD64572 drivers.Krzysztof Hałasa2008-11-223-135/+110
| | | | | | | | Signed-off-by: Krzysztof Hałasa <khc@pm.waw.pl>
| * WAN: don't print HD64572 driver versions anymore.Krzysztof Hałasa2008-11-222-26/+2
| | | | | | | | Signed-off-by: Krzysztof Hałasa <khc@pm.waw.pl>
| * WAN: Simplify HD64572 status handling.Krzysztof Hałasa2008-11-221-29/+8
| | | | | | | | Signed-off-by: Krzysztof Hałasa <khc@pm.waw.pl>
| * WAN: rework HD64572 interrupts a bit.Krzysztof Hałasa2008-11-221-23/+13
| | | | | | | | Signed-off-by: Krzysztof Hałasa <khc@pm.waw.pl>
| * WAN: HD64572 already handles TX underruns with DMAC.Krzysztof Hałasa2008-11-221-17/+15
| | | | | | | | Signed-off-by: Krzysztof Hałasa <khc@pm.waw.pl>
| * WAN: TX-done handler now uses the ownership bit in HD64572 drivers.Krzysztof Hałasa2008-11-221-8/+3
| | | | | | | | Signed-off-by: Krzysztof Hałasa <khc@pm.waw.pl>
| * WAN: convert HD64572-based drivers to NAPI.Krzysztof Hałasa2008-11-223-37/+71
| | | | | | | | Signed-off-by: Krzysztof Hałasa <khc@pm.waw.pl>
OpenPOWER on IntegriCloud