summaryrefslogtreecommitdiffstats
path: root/drivers/staging/wlags49_h2
Commit message (Collapse)AuthorAgeFilesLines
* staging: wlags49_h2: buffer overflow setting station nameDan Carpenter2013-10-301-3/+6
| | | | | | | | | | | | | | We need to check the length parameter before doing the memcpy(). I've actually changed it to strlcpy() as well so that it's NUL terminated. You need CAP_NET_ADMIN to trigger these so it's not the end of the world. Reported-by: Nico Golde <nico@ngolde.de> Reported-by: Fabian Yamaguchi <fabs@goesec.de> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> Cc: stable@kernel.org Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
* staging: wlags49_h2: remove sysfs fileGreg Kroah-Hartman2013-08-245-152/+0
| | | | | | | | | | | | | The sysfs file in this driver is showing a raft of debugging values, none of which belong in sysfs, let alone in a single sysfs file. If these really need to be described somewhere, they should go into debugfs. For now, just delete the sysfs file, which removes a bunch of files from the tree. Cc: Henk de Groot <pe1dnn@amsat.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: wlags49_h2: fix error return code in wl_adapter_insert()Wei Yongjun2013-05-171-1/+2
| | | | | | | | | | | | | When return from wl_adapter_insert() in the register_netdev() error handling case, 'ret' which is 0 is returned, but we should return a negative error code instead, so fix to return the return value of register_netdev(). Introduce by commit 657d4c86d4cd85a4696445f6fb2fe0941a5724ff (staging: wlags49_h2: fix error handling in pcmcia probe function) Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: wlags49_h2: fix up "205179d staging: wlags49_h2: strncpy, need ↵Chen Gang2013-05-161-1/+2
| | | | | | | | | | | | | | | | checking the memory length" for avoiding warnings Type of 'probe_rsp->rawData[1]' is 'hcf_8' which is 'u8', it will compare with 'int', so use min_t() to cast to 'u8' to avoid related warning. If use min(), it has '(void) (&_min1 == &_min2);', so if no type cast, the compiler will report 'pointer types lacks a cast': drivers/staging/wlags49_h2/wl_main.c:3174:122: warning: comparison of distinct pointer types lacks a cast [enabled by default] Signed-off-by: Chen Gang <gang.chen@asianux.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: wlags49_h2: strncpy, need checking the memory lengthChen Gang2013-05-131-1/+2
| | | | | | | | HCF_MAX_NAME_LEN is 32, which may less than ''probe_rsp->rawData[1]'', so need check the length when copy to ssid. Signed-off-by: Chen Gang <gang.chen@asianux.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: wlags49_h2: fix error handling in pcmcia probe functionAlexey Khoroshilov2013-05-132-7/+10
| | | | | | | | | | wl_adapter_attach() ignores some important issues such as register_netdev() failure. The patch fixes it. Found by Linux Driver Verification project (linuxtesting.org). Signed-off-by: Alexey Khoroshilov <khoroshilov@ispras.ru> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: single_open() leaksAl Viro2013-05-051-1/+1
| | | | | Cc: stable@vger.kernel.org Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
* wlags49_h2: Don't use create_proc_read_entry()David Howells2013-04-291-159/+161
| | | | | | | | | | | | Don't use create_proc_read_entry() as that is deprecated, but rather use proc_create_data() and seq_file instead. Signed-off-by: David Howells <dhowells@redhat.com> cc: Henk de Groot <pe1dnn@amsat.org> cc: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com> cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> cc: linux-wireless@vger.kernel.org Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
* wlags49_h2: Don't use create_proc_entry()David Howells2013-04-091-11/+0
| | | | | | | | create_proc_entry() shouldn't be used. Rather proc_create_data() should be used. The proc_write() function is only used by #if'd out code, so delete it for now. Signed-off-by: David Howells <dhowells@redhat.com>
* Merge tag 'staging-3.9-rc1' of ↵Linus Torvalds2013-02-2110-812/+799
|\ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging Pull staging tree update from Greg Kroah-Hartman: "Here's the big staging tree merge for 3.9-rc1 Lots of cleanups and updates for drivers all through the staging tree. We are pretty much "code neutral" here, adding just about as many lines as we removed. All of these have been in linux-next for a while." * tag 'staging-3.9-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging: (804 commits) staging: comedi: vmk80xx: wait for URBs to complete staging: comedi: drivers: addi-data: hwdrv_apci3200.c: Add a missing semicolon staging: et131x: Update TODO list staging: et131x: Remove assignment of skb->dev staging: wlan-ng: hfa384x.h: fix for error reported by smatch staging/zache checkpatch ERROR: spaces prohibited around that staging/ozwpan: Mark read only parameters and structs as const staging/ozwpan: Remove empty and unused function oz_cdev_heartbeat staging/ozwpan: Mark local functions as static (fix sparse warnings) staging/ozwpan: Add missing header includes staging/usbip: Mark local functions as static (fix sparse warnings) staging/xgifb: Remove duplicated code in loops. staging/xgifb: Consolidate return paths staging/xgifb: Remove code without effect staging/xgifb: Remove unnecessary casts staging/xgifb: Consolidate if/else if with identical code branches staging: vt6656: replaced custom TRUE definition with true staging: vt6656: replaced custom FALSE definition with false staging: vt6656: replace custom BOOL definition with bool staging/rtl8187se: Mark functions as static to silence sparse ...
| * staging: wlags49_h2: remove unneeded memset() in wireless_get_bssid()Cyril Roelandt2013-01-071-2/+0
| | | | | | | | | | | | | | | | A few lines after this call, we memcpy over the same memory area, so the call to memset is not necessary. Signed-off-by: Cyril Roelandt <tipecaml@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
| * staging: wlags49_h2: wl_util: corrects asterisk placementJohan Meiring2013-01-071-3/+3
| | | | | | | | | | | | | | This commit fixes incorrect placement of the asterisk character. Signed-off-by: Johan Meiring <johanmeiring@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
| * staging: wlags49_h2: wl_util: converts C99 // commentJohan Meiring2013-01-071-1/+1
| | | | | | | | | | | | | | This commit converts a C99 // comment to /* */ Signed-off-by: Johan Meiring <johanmeiring@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
| * staging: wlags49_h2: wl_util: fixes spacing around parenthesesJohan Meiring2013-01-071-18/+18
| | | | | | | | | | | | | | | | This commit corrects the spacing in an and around parentheses in the file. Signed-off-by: Johan Meiring <johanmeiring@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
| * staging: wlags49_h2: wl_priv: converts C99 // commentsJohan Meiring2013-01-071-136/+123
| | | | | | | | | | | | | | This commit converts C99 // comments to /* */ Signed-off-by: Johan Meiring <johanmeiring@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
| * staging: wlags49_h2: wl_priv: converts indentation to tabsJohan Meiring2013-01-071-97/+97
| | | | | | | | | | | | | | This commit converts instances of space-based indentation to tabs. Signed-off-by: Johan Meiring <johanmeiring@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
| * staging: wlags49_h2: wl_priv: fixes brace placementJohan Meiring2013-01-071-7/+3
| | | | | | | | | | | | | | | | This commit fixes incorrect brace placements in the file, as indicated by the checkpatch.pl tool. Signed-off-by: Johan Meiring <johanmeiring@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
| * staging: wlags49_h2: wl_priv: fixes case statement styling issuesJohan Meiring2013-01-071-10/+10
| | | | | | | | | | | | | | This commit fixes issues related to the styling of case statements. Signed-off-by: Johan Meiring <johanmeiring@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
| * staging: wlags49_h2: wl_priv: fixes incorrect #includeJohan Meiring2013-01-071-1/+1
| | | | | | | | | | | | | | | | This commit forces the file to use <linux/uaccess.h> instead of <asm/uaccess.h>. Everything still compiles a-OK. Signed-off-by: Johan Meiring <johanmeiring@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
| * staging: wlags49_h2: wl_priv: fixes parentheses styling issuesJohan Meiring2013-01-071-46/+46
| | | | | | | | | | | | | | | | This commit fixes further parentheses styling issues as identified by the checkpatch.pl tool. Signed-off-by: Johan Meiring <johanmeiring@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
| * staging: wlags49_h2: wl_priv: fixes spacing around parenthesesJohan Meiring2013-01-071-379/+379
| | | | | | | | | | | | | | | | This commit fixes many instances where the spacing in and around parentheses was applied incorrectly. Signed-off-by: Johan Meiring <johanmeiring@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
| * staging: wlags49_h2: wl_profile.h: fixes C99 // commentJohan Meiring2013-01-071-1/+1
| | | | | | | | | | | | | | | | This commit converts a C99 // comment to /* */. The checkpatch.pl tool reports that this file has no further styling issues. Signed-off-by: Johan Meiring <johanmeiring@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
| * staging: wlags49_h2: wl_profile.h: fixes spacing around parenthesesJohan Meiring2013-01-071-5/+5
| | | | | | | | | | | | | | This commit cleans up the spacing around parentheses. Signed-off-by: Johan Meiring <johanmeiring@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
| * staging: wlags49_h2: sta_h2: corrects C99 // commentsJohan Meiring2013-01-071-35/+35
| | | | | | | | | | | | | | This commit converts C99 // comments to /* */ Signed-off-by: Johan Meiring <johanmeiring@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
| * staging: wlags49_h2: sta_h2: fixes casting style issueJohan Meiring2013-01-071-4/+4
| | | | | | | | | | | | | | This commit cleans up a styling issue when casting to "hcf_8 *". Signed-off-by: Johan Meiring <johanmeiring@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
| * staging: wlags49_h2: sta_h2: fixes spaces around parenthesesJohan Meiring2013-01-071-1/+1
| | | | | | | | | | | | | | | | This commit fixes an instance where the spacing around parentheses was incorrect. Signed-off-by: Johan Meiring <johanmeiring@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
| * staging: wlags49_h2: sta_h2: fixes malformed #include filenameJohan Meiring2013-01-071-1/+1
| | | | | | | | | | | | | | | | | | This minor change simply removes quotations from within a comment so that the checkpatch.pl tool won't complain about a malformed include filename anymore. Signed-off-by: Johan Meiring <johanmeiring@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
| * staging: wlags49_h2: sta_h2: fixes spaces-before-tabs problemsJohan Meiring2013-01-071-10/+10
| | | | | | | | | | | | | | | | This commit various cases where there were spaces before tabs, as reported by the checkpatch.pl tool. Signed-off-by: Johan Meiring <johanmeiring@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
| * staging: wlags49_h2: wl_netdev.h: sorts out spacing issuesJohan Meiring2013-01-071-45/+45
| | | | | | | | | | | | | | | | | | This commit fixes issues regarding spacing around parentheses. The checkpatch.pl tool reports that this file has no further styling issues. Signed-off-by: Johan Meiring <johanmeiring@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
| * staging: wlags49_h2: wl_netdev.h: converts C99 // commentsJohan Meiring2013-01-071-2/+2
| | | | | | | | | | | | | | This commit converts C99 // comments to /* */ Signed-off-by: Johan Meiring <johanmeiring@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
| * staging: wlags49_h2: wl_priv.h: fixes instances of 80+ char linesJohan Meiring2013-01-071-6/+12
| | | | | | | | | | | | | | | | | | This commit corrects cases where lines where longer than 80 characters. checkpatch.pl now reports that this file has no further issues. Signed-off-by: Johan Meiring <johanmeiring@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
| * staging: wlags49_h2: wl_priv.h: converts C99 // commentsJohan Meiring2013-01-071-14/+14
| | | | | | | | | | | | | | This commit converts C99 // comments to /* */ Signed-off-by: Johan Meiring <johanmeiring@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
| * staging: wlags49_h2: wl_priv.h: fixes spacing around parenthesesJohan Meiring2013-01-071-12/+12
| | | | | | | | | | | | | | This commit fixes the incorrect spacing around parentheses. Signed-off-by: Johan Meiring <johanmeiring@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
| * staging: wlags49_h2: wl_enc: fixes incorrect use of returnJohan Meiring2013-01-071-2/+2
| | | | | | | | | | | | | | | | This commit removes parentheses that were used as part of return statements, seeing as how return is not a function. Signed-off-by: Johan Meiring <johanmeiring@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
| * staging: wlags49_h2: wl_enc: corrects spacing around colonsJohan Meiring2013-01-071-6/+6
| | | | | | | | | | | | | | This commit fixes incorrect use of spaces around colons. Signed-off-by: Johan Meiring <johanmeiring@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
| * staging: wlags49_h2: wl_enc: corrects spacing around parenthesesJohan Meiring2013-01-071-23/+23
| | | | | | | | | | | | | | | | This commit corrects various instances where the use of spaces around parentheses was incorrect. Signed-off-by: Johan Meiring <johanmeiring@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
| * staging: wlags49_h2: wl_enc: converts indentation spaces to tabsJohan Meiring2013-01-071-62/+62
| | | | | | | | | | | | | | This commit converts space-based indentation to tabs. Signed-off-by: Johan Meiring <johanmeiring@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
| * staging: wlags49_h2: ap_h25: corrects incorrect use of // commentsJohan Meiring2013-01-071-34/+34
| | | | | | | | | | | | | | This commit converts C99 // comments to /* */ Signed-off-by: Johan Meiring <johanmeiring@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
| * staging: wlags49_h2: ap_h25: corrects casting styling issueJohan Meiring2013-01-071-4/+4
| | | | | | | | | | | | | | | | This commit corrects a casting styling issue as reported by the checkpatch.pl tool. Signed-off-by: Johan Meiring <johanmeiring@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
| * staging: wlags49_h2: ap_h25: corrects malformed #include warningJohan Meiring2013-01-071-1/+1
| | | | | | | | | | | | | | | | | | This extremely minor commit removes quotation marks from within a comment so that the checkpatch.pl tool won't complain about the line in question anymore. Signed-off-by: Johan Meiring <johanmeiring@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
| * staging: wlags49_h2: ap_h25: corrects parentheses styling issueJohan Meiring2013-01-071-1/+1
| | | | | | | | | | | | | | This commit corrects incorrect spaces around parentheses. Signed-off-by: Johan Meiring <johanmeiring@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
| * staging: wlags49_h2: ap_h25: corrects tabs/spaces syling issuesJohan Meiring2013-01-071-9/+9
| | | | | | | | | | | | | | | | This commit corrects tabs and spaces issues as reported by the checkpatch.pl tool. Signed-off-by: Johan Meiring <johanmeiring@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
| * staging: wlags49_h2: ap_h2: corrects a pointer styling issueJohan Meiring2013-01-071-4/+4
| | | | | | | | | | | | | | | | This commit correct a pointer styling issue as reported by the checkpatch.pl tool. Signed-off-by: Johan Meiring <johanmeiring@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* | ethtool: fix drvinfo strings set in driversJiri Pirko2013-01-061-7/+7
|/ | | | | | | | | | | | Use strlcpy where possible to ensure the string is \0 terminated. Use always sizeof(string) instead of 32, ETHTOOL_BUSINFO_LEN and custom defines. Use snprintf instead of sprint. Remove unnecessary inits of ->fw_version Remove unnecessary inits of drvinfo struct. Signed-off-by: Jiri Pirko <jiri@resnulli.us> Signed-off-by: David S. Miller <davem@davemloft.net>
* staging: wlags49_h2: remove use of __devexitBill Pemberton2012-11-211-2/+2
| | | | | | | | CONFIG_HOTPLUG is going away as an option so __devexit is no longer needed. Signed-off-by: Bill Pemberton <wfp5p@virginia.edu> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: wlags49_h2: remove use of __devinitdataBill Pemberton2012-11-211-1/+1
| | | | | | | | CONFIG_HOTPLUG is going away as an option so __devinitdata is no longer needed. Signed-off-by: Bill Pemberton <wfp5p@virginia.edu> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: wlags49_h2: remove use of __devinitBill Pemberton2012-11-211-2/+2
| | | | | | | | CONFIG_HOTPLUG is going away as an option so __devinit is no longer needed. Signed-off-by: Bill Pemberton <wfp5p@virginia.edu> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: wlags49_h2: remove use of __devexit_pBill Pemberton2012-11-211-8/+7
| | | | | | | | | | | CONFIG_HOTPLUG is going away as an option so __devexit_p is no longer needed, remove it. This also changes the syntax for the initialization of the wl_driver struct to match convention. Signed-off-by: Bill Pemberton <wfp5p@virginia.edu> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: wlags49_h2: ap_h2.c: fixes spaces-before-tabs problemsJohan Meiring2012-11-211-8/+8
| | | | | | | | This commit sorts out a few instances of spaces before tabs, as reported by the checkpatch.pl tool. Signed-off-by: Johan Meiring <johanmeiring@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: wlags49_h2: wl_if.h: gets rid of C99 // commentsJohan Meiring2012-11-211-23/+16
| | | | | | | This commit converts all C99 // comments to standard /* */ comments Signed-off-by: Johan Meiring <johanmeiring@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
OpenPOWER on IntegriCloud