summaryrefslogtreecommitdiffstats
path: root/drivers/staging/vt6656
Commit message (Collapse)AuthorAgeFilesLines
* staging: Use available error codesJulia Lawall2010-08-311-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | An error code is stored in a variable, but 0 is returned instead. Use the variable instead of 0. The semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/) // <smpl> @r@ local idexpression x; constant C; @@ if (...) { ... x = -C ... when != x ( return <+...x...+>; | return NULL; | return; | * return ...; ) } // </smpl> Signed-off-by: Julia Lawall <julia@diku.dk> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
* Staging: vt6656: problems in error handlingDan Carpenter2010-08-311-6/+5
| | | | | | | | | | The first kfree(pDevice) is pointless because pDevice is NULL. The second kfree(pDevice) is a double free because pDevice is the driver's private data and that is already freed by free_netdev(netdev). Also the free_netdev() error path doesn't call usb_put_dev(). Signed-off-by: Dan Carpenter <error27@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
* staging: vt6656: resolved checkpatch findingLuis Bosch2010-08-311-1/+1
| | | | | | | Added spaces in for loop arguments. Signed-off-by: Luis Bosch <luis.bosch@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
* staging: vt6656: removed extra spacesVictor Rosales2010-08-311-4/+4
| | | | | | | Removed spaces between functions name and parenthesis. Signed-off-by: Victor Rosales <victorhrosales@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
* staging: vt6656: changed comments convention and removed spaces before tabAlejandro Emanuel Paredes2010-08-311-3/+3
| | | | | | | resolved checkpatch finding Signed-off-by: Alejandro Emanuel Paredes <aleparedes@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
* staging: vt6656: removed macro to test bitsAndres More2010-08-313-31/+29
| | | | | | | Removed custom macro used to test bits. Signed-off-by: Andres More <more.andres@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
* staging: vt6656: removed NDIS_STATUS int redefinitionAndres More2010-08-313-6/+3
| | | | | | | Removed int redefinition for function results. Signed-off-by: Andres More <more.andres@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
* staging: vt6656: removed custom definitions of Ethernet packet typesAndres More2010-08-313-45/+18
| | | | | | | | Removed some unused definitions of Ethernet packet types, also replaced two of them with in-kernel counterparts from include/linux/if_ether.h Signed-off-by: Andres More <more.andres@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
* staging: vt6656: removed not useful commentsAndres More2010-08-3113-66/+33
| | | | | | | Removed comments about who changed/added lines, they do not seem useful. Signed-off-by: Andres More <more.andres@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
* staging: vt6656: added spaces around '||'Andres More2010-08-314-8/+11
| | | | | | | Cleared checkpatch ERROR: spaces required around that '||' Signed-off-by: Andres More <more.andres@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
* staging: vt6656: removed NTSTATUS definitionAndres More2010-08-0215-109/+38
| | | | | | | Replaced NTSTATUS with int, as defined in a couple of places. Signed-off-by: Andres More <more.andres@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
* staging: vt6656: simplified tests involving both multi/broad-castsAndres More2010-08-021-18/+13
| | | | | | | | By definition the broadcast address is also a multicast address. Lindented the modified section as required by checkpatch.pl. Signed-off-by: Andres More <more.andres@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
* Staging: vt6656: Remove PUINT from ttype.hRoel Van Nyen2010-08-024-9/+8
| | | | | | | Remove PUINT from ttype.h Signed-off-by: Roel Van Nyen <roel.vannyen@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
* staging: vt6656: code cleanup in device_netdev_ops' device_xmit()Andres More2010-07-221-24/+22
| | | | | | | Lindented, cleared checkpatch findings and simplified error handling. Signed-off-by: Andres More <more.andres@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
* staging: vt6656: replaced MAX_PACKET_LEN with ETH_FRAME_LENAndres More2010-07-222-14/+3
| | | | | | | | Replaced custom macro with one from include/linux/if_ether.h. Also removed MAX_LOOKAHEAD_SIZE as it is not used elsewhere. Signed-off-by: Andres More <more.andres@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
* staging: vt6656: replaced MIN_PACKET_LEN with ETH_ZLENAndres More2010-07-222-8/+2
| | | | | | | | Removed custom macro with one from include/linux/if_ether.h. Also removed MIN_DATA_LEN as it is not used elsewhere. Signed-off-by: Andres More <more.andres@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
* staging: vt6656: replaced MAX_DATA_LEN with ETH_DATA_LENAndres More2010-07-222-4/+3
| | | | | | | Removed custom macro with one from include/linux/if_ether.h. Signed-off-by: Andres More <more.andres@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
* staging: vt6656: replaced U_CRC_LEN with ETH_FCS_LENAndres More2010-07-223-4/+4
| | | | | | | | Removed custom macro with one from include/linux/if_ether.h. FCS is an Ethernet field that holds the CRC value. Signed-off-by: Andres More <more.andres@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
* staging: vt6656: removed Calcu_LinkQual definitionAndres More2010-07-227-35/+0
| | | | | | | Removed an always defined macro, perhaps used to patch the driver Signed-off-by: Andres More <more.andres@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
* staging: vt6656: removed WPA_SM_Transtatus definitionAndres More2010-07-226-20/+0
| | | | | | | Removed an always defined macro, perhaps used to patch the driver Signed-off-by: Andres More <more.andres@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
* staging: vt6656: removed update_BssList definitionAndres More2010-07-222-7/+0
| | | | | | | Removed an always defined macro, perhaps used to patch the driver Signed-off-by: Andres More <more.andres@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
* staging: vt6656: removed Adhoc_STA definitionAndres More2010-07-224-14/+1
| | | | | | | Removed an always defined macro, perhaps used to patch the driver Signed-off-by: Andres More <more.andres@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
* staging: vt6656: removed Safe_Close definitionAndres More2010-07-223-50/+3
| | | | | | | Removed an always defined macro, perhaps used to patch the driver Signed-off-by: Andres More <more.andres@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
* staging: vt6656: code cleanup in vt6656 DMA TXAndres More2010-07-221-22/+10
| | | | | | | Lindented, removed unused variables and cleared checkpatch warnings. Signed-off-by: Andres More <more.andres@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
* staging: vt6656: code cleanup in vt6656_probe()Andres More2010-07-221-50/+44
| | | | | | | Lindented, cleared checkpatch warnings and removed legacy comments. Signed-off-by: Andres More <more.andres@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
* staging: vt6656: removed '#if 1'/'#if 0' definitionsAndres More2010-07-225-87/+0
| | | | | | | Removed code guarded by always false definitions. Signed-off-by: Andres More <more.andres@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
* staging: vt6656: removed SndEvt_ToAPI definitionAndres More2010-07-085-18/+0
| | | | | | | Removed an always defined macro, perhaps used to patch the driver Signed-off-by: Andres More <more.andres@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
* staging: vt6656: removed TxInSleep definitionAndres More2010-07-088-37/+2
| | | | | | | Removed an always defined macro, perhaps used to patch the driver Signed-off-by: Andres More <more.andres@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
* staging: vt6656: removed unused IS_NULL_ADDRESS definitionAndres More2010-07-081-6/+0
| | | | | | | | Removed custom definition not used elsewhere, is_zero_ether_addr() is already provided if required. Signed-off-by: Andres More <more.andres@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
* staging: vt6656: replace IS_ETH_ADDRESS_EQUAL with compare_ether_addrAndres More2010-06-248-67/+29
| | | | | | | | | | Code cleanup, removed custom macro to compare Ethernet addresses. Some checkpatch warnings on indentation were not resolved. The return value of compare_ether_addr was reversed, something to consider. Signed-off-by: Andres More <more.andres@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
* Staging: vt6656: replaced IS_BROADCAST_ADDRESS with is_broadcast_ether_addrAndres More2010-06-237-30/+17
| | | | | | | | Replaced and removed the custom definition. Minor checkpatch warnings on long lines and indentation were not cleared. Signed-off-by: Andres More <more.andres@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
* Staging: vt6656: code cleanup of vt6656_disconnect()Andres More2010-06-231-32/+17
| | | | | | | | Fixed style and debugging printks. Not replaced PSDevice here, nor removed wireless_send_event() yet. Signed-off-by: Andres More <more.andres@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
* Staging: vt6656: code cleanup in vt6656_suspend()/vt6656_resume()Andres More2010-06-221-21/+20
| | | | | | | Not changed PSDevice priv struct, just fixed style and removed printks. Signed-off-by: Andres More <more.andres@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
* Staging: vt6656: removed '#if 0' definitionsAndres More2010-06-226-111/+0
| | | | | | | Removed code in .c files that was being skipped by the preprocessor Signed-off-by: Andres More <more.andres@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
* Staging: vt665*: fix typos concerning "management"Uwe Kleine-König2010-06-185-6/+6
| | | | | Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
* Staging: vt6656: fix coding style issues in 80211mgr.cTimofey Trofimov2010-06-181-263/+251
| | | | | | | | This is a patch to the 80211mgr.c file that fixes up warnings found by the checkpatch.pl tool Signed-off-by: Timofey Trofimov <tumoxep@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
* Staging: vt6656: fix up built-in compilation together with rt2870Otavio Salvador2010-06-182-6/+4
| | | | | | | | | | | | | | | | | | | | Fix this build error: drivers/staging/vt6656/built-in.o: In function `rotr1': (.text+0x1a878): multiple definition of `rotr1' drivers/staging/rt2870/built-in.o:(.text+0x106c2): first defined here drivers/staging/vt6656/built-in.o: In function `tkip_sbox': (.text+0x1a848): multiple definition of `tkip_sbox' drivers/staging/rt2870/built-in.o:(.text+0x10697): first defined here drivers/staging/vt6656/built-in.o: In function `xor_32': (.text+0x1ec24): multiple definition of `xor_32' drivers/staging/rt2870/built-in.o:(.text+0x111c4): first defined here drivers/staging/vt6656/built-in.o: In function `xor_128': (.text+0x1ec00): multiple definition of `xor_128' drivers/staging/rt2870/built-in.o:(.text+0x111dd): first defined here Signed-off-by: Otavio Salvador <otavio@ossystems.com.br> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
* Staging: vt6656: code cleanup, resolved checkpatch findings in headersAndres More2010-06-1821-229/+136
| | | | | | | Resolved whitespace-related checkpatch findings in .h files Signed-off-by: Andres More <more.andres@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
* Staging: vt6656: code cleanup, fixed 'for' statementsAndres More2010-06-1815-160/+161
| | | | | | | | | Resolved checkpatch findings, but some long lines warnings. ERROR: space required before the open parenthesis '(' ERROR: spaces required around that Signed-off-by: Andres More <more.andres@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
* Merge staging-next tree into Linus's latest versionGreg Kroah-Hartman2010-05-2175-3879/+3529
|\ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Conflicts: drivers/staging/arlan/arlan-main.c drivers/staging/comedi/drivers/cb_das16_cs.c drivers/staging/cx25821/cx25821-alsa.c drivers/staging/dt3155/dt3155_drv.c drivers/staging/hv/hv.c drivers/staging/netwave/netwave_cs.c drivers/staging/wavelan/wavelan.c drivers/staging/wavelan/wavelan_cs.c drivers/staging/wlags49_h2/wl_cs.c This required a bit of hand merging due to the conflicts that happened in the later .34-rc releases, as well as some staging driver changing coming in through other trees (v4l and pcmcia). Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
| * Staging: vt6656: use ETH_HLEN macro instead of custom oneCharles Clément2010-05-182-14/+12
| | | | | | | | | | | | | | | | Replace custom header length definition U_HEADER_LEN by ETH_HLEN from <linux/if_ether.h>. Also remove unused U_TYPE_LEN. Signed-off-by: Charles Clément <caratorn@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
| * Staging: vt6656: removed custom UCHAR/USHORT/UINT/ULONG/ULONGLONG typedefsAndres More2010-05-1848-692/+700
| | | | | | | | | | | | | | Cleared all checkpatch warnings but 'do not add new typedefs' ones. Signed-off-by: Andres More <more.andres@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
| * Staging: vt6656: removed custom CHAR/SHORT/INT/LONG typedefsAndres More2010-05-1810-56/+77
| | | | | | | | | | | | | | Cleared all checkpatch warnings but one 'do not add new typedefs' Signed-off-by: Andres More <more.andres@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
| * Staging: Use kcalloc or kzallocJulia Lawall2010-05-142-4/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Use kcalloc or kzalloc rather than the combination of kmalloc and memset. The semantic patch that makes this change is as follows: (http://coccinelle.lip6.fr/) // <smpl> @@ expression x,y,flags; statement S; type T; @@ x = - kmalloc + kcalloc ( - y * sizeof(T), + y, sizeof(T), flags); if (x == NULL) S -memset(x, 0, y * sizeof(T)); @@ expression x,size,flags; statement S; @@ -x = kmalloc(size,flags); +x = kzalloc(size,flags); if (x == NULL) S -memset(x, 0, size); // </smpl> Signed-off-by: Julia Lawall <julia@diku.dk>
| * staging: vt6656: code cleanup, removed unused I8 macroAndres More2010-05-141-7/+0
| | | | | | | | | | | | | | Removed custom macro for signed 8-bit integers, which was not used. Signed-off-by: Andres More <more.andres@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
| * staging: vt6656: code cleanup, replaced U32 macro with u32Andres More2010-05-143-137/+112
| | | | | | | | | | | | | | Removed custom macro for unsigned 32-bit integers. Signed-off-by: Andres More <more.andres@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
| * staging: vt6656: code cleanup, replaced U16 macro with u16Andres More2010-05-142-24/+23
| | | | | | | | | | | | | | Removed custom macro for unsigned 16-bit integers. Signed-off-by: Andres More <more.andres@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
| * staging: vt6656: code cleanup, replaced U8 macro with u8Andres More2010-05-142-40/+32
| | | | | | | | | | | | | | Removed custom macro for unsigned 8-bit integers. Signed-off-by: Andres More <more.andres@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
| * staging: vt6656: card.h: code cleanup, resolved checkpatch findingsAndres More2010-05-111-15/+9
| | | | | | | | | | | | | | Cleared all findings but a couple of 'do not add new typedefs' warnings. Signed-off-by: Andres More <more.andres@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
| * Staging: Drop memory allocation castJulia Lawall2010-05-113-4/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Drop cast on the result of kmalloc and similar functions. The semantic patch that makes this change is as follows: (http://coccinelle.lip6.fr/) // <smpl> @@ type T; @@ - (T *) (\(kmalloc\|kzalloc\|kcalloc\|kmem_cache_alloc\|kmem_cache_zalloc\| kmem_cache_alloc_node\|kmalloc_node\|kzalloc_node\)(...)) // </smpl> Signed-off-by: Julia Lawall <julia@diku.dk> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
OpenPOWER on IntegriCloud