summaryrefslogtreecommitdiffstats
path: root/drivers/staging/vt6655
Commit message (Collapse)AuthorAgeFilesLines
* staging: Use available error codesJulia Lawall2010-08-311-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | An error code is stored in a variable, but 0 is returned instead. Use the variable instead of 0. The semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/) // <smpl> @r@ local idexpression x; constant C; @@ if (...) { ... x = -C ... when != x ( return <+...x...+>; | return NULL; | return; | * return ...; ) } // </smpl> Signed-off-by: Julia Lawall <julia@diku.dk> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
* staging: vt6655: do not use PCI resources before pci_enable_device()Kulikov Vasiliy2010-08-311-1/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | IRQ and resource[] may not have correct values until after PCI hotplug setup occurs at pci_enable_device() time. The semantic match that finds this problem is as follows: // <smpl> @@ identifier x; identifier request ~= "pci_request.*|pci_resource.*"; @@ ( * x->irq | * x->resource | * request(x, ...) ) ... *pci_enable_device(x) // </smpl> Signed-off-by: Kulikov Vasiliy <segooon@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
* Staging: vt6655: replace BOOL with in kernel boolCharles Clément2010-08-0250-472/+470
| | | | | Signed-off-by: Charles Clément <caratorn@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
* Staging: vt6655: replace FALSE with in kernel falseCharles Clément2010-08-0230-589/+581
| | | | | Signed-off-by: Charles Clément <caratorn@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
* Staging: vt6655: replace TRUE with in kernel trueCharles Clément2010-08-0231-768/+761
| | | | | Signed-off-by: Charles Clément <caratorn@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
* Staging: vt6655: use for_each_pci_dev()Kulikov Vasiliy2010-07-081-1/+1
| | | | | | | Use for_each_pci_dev() to simplify the code. Signed-off-by: Kulikov Vasiliy <segooon@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
* Staging: vt6655: simplify broadcast and multicast ethernet address testCharles Clément2010-07-082-19/+9
| | | | | | | | | | A broadcast address is also a multicast address so simplify test cases where possible. As suggested by Joe Perches. Signed-off-by: Charles Clément <caratorn@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
* Staging: vt6655: Add TODO entries on x86-64 pointers and .data sizeCharles Clément2010-06-251-0/+2
| | | | | | | As suggested by Jiri Slaby. Signed-off-by: Charles Clément <caratorn@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
* Staging: vt6655: remove PUINT typedefCharles Clément2010-06-258-147/+50
| | | | | Signed-off-by: Charles Clément <caratorn@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
* Staging: vt6655: remove BYTE typedefCharles Clément2010-06-2455-965/+963
| | | | | | | Replace all occurrences with unsigned char type. Signed-off-by: Charles Clément <caratorn@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
* Staging: vt6655: remove WORD typedefCharles Clément2010-06-2444-590/+589
| | | | | | | Replace all occurrences with unsigned short type. Signed-off-by: Charles Clément <caratorn@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
* Staging: vt6655: remove DWORD typedefCharles Clément2010-06-2432-309/+308
| | | | | | | | | | | | Replace all occurrences with unsigned long type, except for pointer fields that should be u32 in packed structures and 8-byte-aligned 8 byte long structure QWORD. Thanks to Jiri Slaby for pointing out that simply replacing by unsigned long is wrong on x86-64 arch. Signed-off-by: Charles Clément <caratorn@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
* Staging: vt6655: remove DWORD_PTR pointer typedefCharles Clément2010-06-2213-196/+194
| | | | | | Use unsigned long instead. Signed-off-by: Charles Clément <caratorn@gmail.com>
* Staging: vt6655: remove ULONG_PTR typedefCharles Clément2010-06-222-5/+4
| | | | Signed-off-by: Charles Clément <caratorn@gmail.com>
* Staging: vt6655: move channel mapping code from card.c to channel.cCharles Clément2010-06-2212-982/+931
| | | | | | | | | | | | | | | | | | | | | | | | | | Move functions managing the channel mapping to a new channel.c file, as done in the staging VT6656 driver. The function names contained in card.c were prefixed with CARD followed by the first letter of the return code, remove this and use more coherent function names. The following functions moved and were renamed: ChannelValid -> is_channel_valid CARDbSetChannel -> set_channel CARDvInitChannelTable -> init_channel_table CARDbyGetChannelMapping -> get_channel_mapping CARDvSetCountryInfo -> set_country_info CARDbySetSupportChannels -> set_support_channels CARDbChannelGetList -> channel_get_list CARDvSetCountryIE -> set_country_IE CARDbGetChannelMapInfo -> get_channel_map_info CARDvSetChannelMapInfo -> set_channel_map_info CARDvClearChannelMapInfo -> clear_channel_map_info CARDbyAutoChannelSelect -> auto_channel_select CARDbyGetChannelNumber -> get_channel_number Signed-off-by: Charles Clément <caratorn@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
* Staging: vt6655: struct pci_driver cleanupCharles Clément2010-06-181-19/+19
| | | | | | | | Rename driver struct and callbacks to vt6655_* instead of device_* and add __devinit/__devexit directives. Signed-off-by: Charles Clément <caratorn@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
* Staging: vt665*: fix typos concerning "management"Uwe Kleine-König2010-06-181-1/+1
| | | | | Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
* Staging: vt6655: fix up U32 conversionGreg Kroah-Hartman2010-06-182-2/+2
| | | | | | | | | | | | | Commit 902d2411298a6e0b8a473a0163aa4bf6d5c8a073 converted U32 to u32 which you would think would be just fine. Unfortunatly, it seems that VIA only builds their code on a 32bit processor (which makes sense if you think about it), but this doesn't work on x86-64. So fix up the few places where this really wanted to be an unsigned long width. Cc: Charles Clément <caratorn@gmail.com> Cc: Forest Bond <forest@alittletooquiet.net>, Cc: Andres More <more.andres@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
* Staging: vt6655: include linux/ headers instead of asm/Charles Clément2010-06-181-2/+2
| | | | | Signed-off-by: Charles Clément <caratorn@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
* Staging: vt6655: remove PDWORD typedefCharles Clément2010-06-1814-84/+82
| | | | | | | Use unsigned long * instead. Signed-off-by: Charles Clément <caratorn@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
* Staging: vt6655: remove PWORD typedefCharles Clément2010-06-1821-133/+131
| | | | | | | Use unsigned short * instead. Signed-off-by: Charles Clément <caratorn@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
* Staging: vt6655: remove PBYTE typedefCharles Clément2010-06-1857-503/+503
| | | | | | | Use unsigned char * instead. Signed-off-by: Charles Clément <caratorn@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
* Staging: vt6655: remove custom ULONGLONG typedefCharles Clément2010-06-186-91/+87
| | | | | Signed-off-by: Charles Clément <caratorn@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
* Staging: vt6655: remove custom ULONG typedefCharles Clément2010-06-1819-67/+67
| | | | | Signed-off-by: Charles Clément <caratorn@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
* Staging: vt6655: remove custom UINT typedefCharles Clément2010-06-1847-538/+545
| | | | | Signed-off-by: Charles Clément <caratorn@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
* Staging: vt6655: remove custom USHORT typedefCharles Clément2010-06-182-8/+7
| | | | | Signed-off-by: Charles Clément <caratorn@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
* Staging: vt6655: remove custom UCHAR typedefCharles Clément2010-06-184-9/+10
| | | | | Signed-off-by: Charles Clément <caratorn@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
* Staging: vt6655: remove custom LONG typedefCharles Clément2010-06-189-22/+20
| | | | | Signed-off-by: Charles Clément <caratorn@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
* Staging: vt6655: remove custom INT typedefCharles Clément2010-06-186-43/+42
| | | | | Signed-off-by: Charles Clément <caratorn@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
* Staging: vt6655: removed custom SHORT typedefCharles Clément2010-06-182-5/+4
| | | | | Signed-off-by: Charles Clément <caratorn@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
* Staging: vt6655: removed custom CHAR typedefCharles Clément2010-06-183-4/+3
| | | | | Signed-off-by: Charles Clément <caratorn@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
* Staging: vt6655: remove U32 custom macroCharles Clément2010-06-186-127/+124
| | | | | | | Remove custom macro for unsigned 32-bit integers, replace by u32. Signed-off-by: Charles Clément <caratorn@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
* Staging: vt6655: remove U16 custom macroCharles Clément2010-06-184-30/+29
| | | | | | | Remove custom macro for unsigned 16-bit integers. Signed-off-by: Charles Clément <caratorn@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
* Staging: vt6655: remove U8 custom macroCharles Clément2010-06-185-42/+41
| | | | | | | Remove custom macro for unsigned 8-bit integers. Signed-off-by: Charles Clément <caratorn@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
* Staging: vt6655: remove I8 custom macroCharles Clément2010-06-184-11/+9
| | | | | | | Remove custom macro for signed 8-bit integers. Signed-off-by: Charles Clément <caratorn@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
* Staging: vt6655: remove unused OUT definitionCharles Clément2010-06-181-4/+0
| | | | | Signed-off-by: Charles Clément <caratorn@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
* Staging: vt6655: remove double definition of Calcu_LinkQualCharles Clément2010-06-181-4/+0
| | | | | | | Calcu_LinkQual is already defined a couple lines earlier. Signed-off-by: Charles Clément <caratorn@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
* Staging: vt6655: remove unused argument in ChannelValid functionCharles Clément2010-06-183-6/+5
| | | | | Signed-off-by: Charles Clément <caratorn@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
* Staging: vt6655: use compare_ether_addr instead of custom macroCharles Clément2010-06-189-27/+20
| | | | | | | | Replace custom macro IS_ETH_ADDRESS_EQUAL by compare_ether_addr from <linux/etherdevice.h>. Signed-off-by: Charles Clément <caratorn@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
* Staging: vt6655: use is_zero_ether_addr instead of custom macroCharles Clément2010-06-182-6/+1
| | | | | | | | Replace custom macro IS_NULL_ADDRESS by is_zero_ether_addr from <linux/etherdevice.h>. Signed-off-by: Charles Clément <caratorn@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
* Staging: vt6655: use is_broadcast_ether_addr instead of custom macroCharles Clément2010-06-188-18/+13
| | | | | | | | Replace custom macro IS_BROADCAST_ADDRESS by is_broadcast_ether_addr from <linux/etherdevice.h>. Signed-off-by: Charles Clément <caratorn@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
* Staging: vt6655: use is_multicast_ether_addr instead of custom macroCharles Clément2010-06-185-14/+11
| | | | | | | | | | Replace custom macro IS_MULTICAST_ADDRESS by is_multicast_ether_addr from <linux/etherdevice.h>. Remove linux/if_ether.h include as it is included in linux/etherdevice.h already. Signed-off-by: Charles Clément <caratorn@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
* Staging: vt6655: use ETH_ZLEN macro instead of custom oneCharles Clément2010-06-182-8/+2
| | | | | | | | Replace custom minimum packet lenght definition MIN_PACKET_LEN by ETH_ZLEN from <linux/if_ether.h>. Signed-off-by: Charles Clément <caratorn@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
* Merge staging-next tree into Linus's latest versionGreg Kroah-Hartman2010-05-2160-1928/+1903
|\ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Conflicts: drivers/staging/arlan/arlan-main.c drivers/staging/comedi/drivers/cb_das16_cs.c drivers/staging/cx25821/cx25821-alsa.c drivers/staging/dt3155/dt3155_drv.c drivers/staging/hv/hv.c drivers/staging/netwave/netwave_cs.c drivers/staging/wavelan/wavelan.c drivers/staging/wavelan/wavelan_cs.c drivers/staging/wlags49_h2/wl_cs.c This required a bit of hand merging due to the conflicts that happened in the later .34-rc releases, as well as some staging driver changing coming in through other trees (v4l and pcmcia). Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
| * Staging: vt6655: use ETH_FRAME_LEN macro instead of custom oneCharles Clément2010-05-182-6/+3
| | | | | | | | | | | | | | | | Replace custom maximum packet lenght definition MAX_PACKET_LEN by ETH_FRAME_LEN from <linux/if_ether.h>. Signed-off-by: Charles Clément <caratorn@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
| * Staging: vt6655: use ETH_DATA_LEN macro instead of custom oneCharles Clément2010-05-184-7/+6
| | | | | | | | | | | | | | | | Replace custom maximum data lenght definition MAX_DATA_LEN by ETH_DATA_LEN from <linux/if_ether.h>. Signed-off-by: Charles Clément <caratorn@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
| * Staging: vt6655: use ETH_FCS_LEN macro instead of custom oneCharles Clément2010-05-182-2/+1
| | | | | | | | | | | | | | | | Replace custom FCS/CRC length definition U_CRC_LEN by ETH_FCS_LEN from <linux/if_ether.h>. Signed-off-by: Charles Clément <caratorn@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
| * Staging: vt6655: use ETH_HLEN macro instead of custom oneCharles Clément2010-05-173-14/+12
| | | | | | | | | | | | | | | | Replaced custom header length definition U_HEADER_LEN by ETH_HLEN from <linux/if_ether.h>. Also remove unused U_TYPE_LEN. Signed-off-by: Charles Clément <caratorn@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
| * Staging: vt6655: use ETH_ALEN macro instead of custom oneCharles Clément2010-05-1719-96/+96
| | | | | | | | | | | | | | | | Replaced custom ethernet address length definition U_ETHER_ADDR_LEN by ETH_ALEN from <linux/if_ether.h>. Signed-off-by: Charles Clément <caratorn@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
| * Staging: Use kcalloc or kzallocJulia Lawall2010-05-142-4/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Use kcalloc or kzalloc rather than the combination of kmalloc and memset. The semantic patch that makes this change is as follows: (http://coccinelle.lip6.fr/) // <smpl> @@ expression x,y,flags; statement S; type T; @@ x = - kmalloc + kcalloc ( - y * sizeof(T), + y, sizeof(T), flags); if (x == NULL) S -memset(x, 0, y * sizeof(T)); @@ expression x,size,flags; statement S; @@ -x = kmalloc(size,flags); +x = kzalloc(size,flags); if (x == NULL) S -memset(x, 0, size); // </smpl> Signed-off-by: Julia Lawall <julia@diku.dk>
OpenPOWER on IntegriCloud