summaryrefslogtreecommitdiffstats
path: root/drivers/staging/rtl8188eu
Commit message (Collapse)AuthorAgeFilesLines
* Staging: rtl8188eu: core/rtw_led.c: format line to reduce it below 80 charactersShishir Kulkarni2017-02-141-1/+2
| | | | | | | Fixes checkpatch.pl warning: "WARNING: line over 80 characters" Signed-off-by: Shishir Kulkarni <shishir.kulkarni.2307@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging:r8188eu: replace recv_frame->rx_(data|len|tail) with ↵Ivan Safonov2017-02-098-159/+83
| | | | | | | | | | | | | pkt->(data|len|tail) and remove unused recvframe_(put|pull|pull_tail)() recv_frame->rx_(data|len|tail) duplicate pkt (skb) data|len|tail members and require special functions recvframe_(put|pull|pull_tail)() instead of skb_(put|pull|trim). Replace rx_(data|len|tail) with pkt->(data|len|tail), remove rx_(data|len|tail) and remove recvframe_(put|pull|pull_tail)(). Signed-off-by: Ivan Safonov <insafonov@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging:r8188eu: update pkt->(data|tail|len) synchronously with ↵Ivan Safonov2017-02-091-1/+4
| | | | | | | | | | | | | rx_(data|tail|len) in recv_frame structure Original driver code uses rx_* members to store skb (pkt) fields (instead of pkt->* members), pkt->* updated only after data completely formed, not in process. Update pkt->* after data buffer changed (with rx_*). Signed-off-by: Ivan Safonov <insafonov@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging:r8188eu: remove unused rtw_ieee80211_bar structure definitionIvan Safonov2017-02-091-15/+0
| | | | | | | rtw_ieee80211_bar structure definition does not used. Remove it. Signed-off-by: Ivan Safonov <insafonov@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging:r8188eu: replace rx_end member of recv_frame with pkt->endIvan Safonov2017-02-092-3/+1
| | | | | | | | | rx_end is duplication of pkt->end pointer. pkt->end is preferred, because it is native skb field supported by skb_*() functions. Signed-off-by: Ivan Safonov <insafonov@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: rtl8188eu: remove not necessary braces {} (checkpatch fix)Martin Karamihov2017-02-031-2/+1
| | | | | | | | This is checkpatch fix for hal/bb_cfg.c file: remove not necessary braces {} Signed-off-by: Martin Karamihov <martinowar@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: rtl8188eu: Fix coding style issuesWilliam Blough2017-01-271-64/+64
| | | | | | | Convert leading spaces to tabs Signed-off-by: William Blough <devel@blough.us> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* Staging: rtl8188eu: os_dep: usb_ops_linux.c - style fixDerek Robson2017-01-231-1/+1
| | | | | | | | Fixed comparison, moved the constant to the right side of the test Found using checkpatch Signed-off-by: Derek Robson <robsonde@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: rtl8188eu: core: Remove NULL test before vfreeShyam Saini2017-01-191-2/+1
| | | | | | | | | vfree frees the virtually continuous block of memory beginning at addr. If addr is NULL, no operation is performed. So, NULL test is not needed before vfree(). Signed-off-by: Shyam Saini <mayhs11saini@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: rtl8188eu: fix type sign of len in rtw_get_bcn_infoPierre-Yves Kerbrat2017-01-191-1/+1
| | | | | | | | | | | | | | | len was declared unsigned int where we use an int Fix sparse (-Wtypesign) issues: drivers/staging/rtl8188eu/core/rtw_ieee80211.c:1081:88: warning: incorrect type in argument 3 (different signedness) drivers/staging/rtl8188eu/core/rtw_ieee80211.c:1081:88: expected int *len drivers/staging/rtl8188eu/core/rtw_ieee80211.c:1081:88: got unsigned int *<noident> drivers/staging/rtl8188eu/core/rtw_ieee80211.c:1091:86: warning: incorrect type in argument 3 (different signedness) drivers/staging/rtl8188eu/core/rtw_ieee80211.c:1091:86: expected int *len drivers/staging/rtl8188eu/core/rtw_ieee80211.c:1091:86: got unsigned int *<noident> Signed-off-by: Pierre-Yves Kerbrat <pkerbrat@free.fr> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: rtl8188eu: fix type of wpa_ielen in rtw_get_cipher_infoPierre-Yves Kerbrat2017-01-191-1/+1
| | | | | | | | | | | | | wpa_ielen was declared u32 when we actually use an int Fix sparse (-Wtypesign) issues: drivers/staging/rtl8188eu/core/rtw_ieee80211.c:1008:60: warning: incorrect type in argument 2 (different signedness) drivers/staging/rtl8188eu/core/rtw_ieee80211.c:1008:60: expected int *wpa_ie_len drivers/staging/rtl8188eu/core/rtw_ieee80211.c:1008:60: got unsigned int *<noident> drivers/staging/rtl8188eu/core/rtw_ieee80211.c:1021:69: warning: incorrect type in argument 2 (different signedness) Signed-off-by: Pierre-Yves Kerbrat <pkerbrat@free.fr> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging:r8188eu: remove unused rx_head member of struct recv_frameIvan Safonov2017-01-162-2/+0
| | | | | | | Value of rx_head member of struct recv_frame does not used. Remove it. Signed-off-by: Ivan Safonov <insafonov@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging:r8188eu: remove unnecessary trace output in rtw_recv_indicatepkt()Ivan Safonov2017-01-161-15/+0
| | | | | | | | Trace output for each received packet in rtw_recv_indicatepkt() is redudant. Remove it. Signed-off-by: Ivan Safonov <insafonov@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging:r8188eu: remove unused struct wifidirect_info and all corresponding codeIvan Safonov2017-01-162-261/+0
| | | | | | | | | wifidirect_info structure is unused. Big amount of another definitions used only for wifidirect_info definition. Remove all. Signed-off-by: Ivan Safonov <insafonov@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging:r8188eu: remove unused get_rxmem()Ivan Safonov2017-01-161-8/+0
| | | | | | | get_rxmem() is not unused, remove it. Signed-off-by: Ivan Safonov <insafonov@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging:r8188eu: remove unused EOR macroIvan Safonov2017-01-161-2/+0
| | | | | | | EOR macro is not unused, remove it. Signed-off-by: Ivan Safonov <insafonov@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging:r8188eu: remove unused WPA_(GET|PUT)_(BE|LE)_xx macroIvan Safonov2017-01-161-29/+0
| | | | | | | WPA_(GET|PUT)_(BE|LE)_xx macros are unused, remove it. Signed-off-by: Ivan Safonov <insafonov@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging:r8188eu: remove unused (GET|PUT)U32 macrosIvan Safonov2017-01-161-7/+0
| | | | | | | (GET|PUT)U32 macros are unused, remove it. Signed-off-by: Ivan Safonov <insafonov@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* drivers: staging: rtl8188eu: include: wifi: Removed unnecessary defined macrosKartikey Singh2017-01-161-17/+0
| | | | | | | Removed macros not in use. Signed-off-by: Kartikey Singh <dr.kartikeynrc@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: rtl: fix possible NULL pointer dereferenceArnd Bergmann2017-01-161-0/+2
| | | | | | | | | | | | | | | | | | | | | | | | gcc-7 detects that wlanhdr_to_ethhdr() in two drivers calls memcpy() with a destination argument that an earlier function call may have set to NULL: staging/rtl8188eu/core/rtw_recv.c: In function 'wlanhdr_to_ethhdr': staging/rtl8188eu/core/rtw_recv.c:1318:2: warning: argument 1 null where non-null expected [-Wnonnull] staging/rtl8712/rtl871x_recv.c: In function 'r8712_wlanhdr_to_ethhdr': staging/rtl8712/rtl871x_recv.c:649:2: warning: argument 1 null where non-null expected [-Wnonnull] I'm fixing this by adding a NULL pointer check and returning failure from the function, which is hopefully already handled properly. This seems to date back to when the drivers were originally added, so backporting the fix to stable seems appropriate. There are other related realtek drivers in the kernel, but none of them contain a function with a similar name or produce this warning. Cc: stable@vger.kernel.org Fixes: 1cc18a22b96b ("staging: r8188eu: Add files for new driver - part 5") Fixes: 2865d42c78a9 ("staging: r8712u: Add the new driver to the mainline kernel") Signed-off-by: Arnd Bergmann <arnd@arndb.de> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: rtl8188eu: fixed 'braces are not necessary for single statement ↵Yamanappagouda Patil2017-01-104-18/+13
| | | | | | | | | blocks'. Fixed checkpatch.pl warnings in rtl8188eu module core folder files. Signed-off-by: Yamanappagouda Patil <goudapatilk@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging:rtl8188eu:rtw_ap.c remove unnecessary bracesScott Matheina2017-01-071-53/+53
| | | | | | | Removed unnecessary braces Signed-off-by: Scott Matheina <scott@matheina.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging:rtl8188eu:core Fixes Alignment should match opening braceScott Matheina2017-01-071-20/+18
| | | | | | | Fixed style issue: Alignment should match open brace Signed-off-by: Scott Matheina <scott@matheina.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging:r8188eu: eleminate recovery attemp using skb_clone after ↵Ivan Safonov2017-01-051-16/+3
| | | | | | | | | | netdev_alloc_skb fail It is wrong to create new skb using skb_clone instead netdev_alloc_skb, because buffer data will be changed later. Signed-off-by: Ivan Safonov <insafonov@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging:r8188eu: remove unused WIFI_MP_*STATE and WIFI_MP_CTX* definitionsIvan Safonov2017-01-056-65/+3
| | | | | | | | | fw_state member of struct mlme_priv never obtain WIFI_MP_STATE value, so code only for (fw_state == WIFI_MP_STATE) is dead. Remove it, WIFI_MP_*STATE and WIFI_MP_CTX* definitions. Signed-off-by: Ivan Safonov <insafonov@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging:r8188eu: remove (NDEV|ADPT)_(FMT|ARG) definitionsIvan Safonov2017-01-051-4/+0
| | | | | | | (NDEV|ADPT)_(FMT|ARG) definitions does not used. Remove it. Signed-off-by: Ivan Safonov <insafonov@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging:r8188eu: remove rtw_update_mem_stat definitionIvan Safonov2017-01-051-1/+0
| | | | | | | rtw_update_mem_stat definition does not used. Remove it. Signed-off-by: Ivan Safonov <insafonov@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging:r8188eu: remove RTW_STATUS_CODE()Ivan Safonov2017-01-052-14/+0
| | | | | | | RTW_STATUS_CODE() does not used. Remove it. Signed-off-by: Ivan Safonov <insafonov@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: rtl8188eu: fix incorrect ERROR tags from logsGalo Navarro2017-01-051-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | Several lifecycle events in the rtl8188eu driver are logged using the DBG_88E_LEVEL macro from rtw_debug.h, which is tagged as ERROR regardless of the actual level. Below are dmesg excerpts after loading and unloading the module, the messages are misleading as there was no error. [517434.916239] usbcore: registered new interface driver r8188eu [517435.680653] R8188EU: ERROR indicate disassoc [517437.122606] R8188EU: ERROR assoc success [517797.735611] usbcore: deregistering interface driver r8188eu [517797.736069] R8188EU: ERROR indicate disassoc Remove the ERROR prefix from the logs. After the patch, logs are: [517949.873976] usbcore: registered new interface driver r8188eu [517950.592845] R8188EU: indicate disassoc [517951.993973] R8188EU: assoc success [521778.784448] usbcore: deregistering interface driver r8188eu [521778.784838] R8188EU: indicate disassoc Signed-off-by: Galo Navarro <anglorvaroa@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: rtl8188eu: remove unused function _linked_rx_signal_strehgth_displayLuca Ceresoli2017-01-051-18/+0
| | | | | | | | | | | | Not referenced anymore since commit 9fe7b29c6cc1 ("staging: rtl8188eu: remove unused field bRxRSSIDisplay in struct adapter"). Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Cc: Larry Finger <Larry.Finger@lwfinger.net> Cc: Ivan Safonov <insafonov@gmail.com> Cc: devel@driverdev.osuosl.org Signed-off-by: Luca Ceresoli <luca@lucaceresoli.net> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: rtl8188eu: remove unused members from struct recv_privLuca Ceresoli2017-01-032-38/+39
| | | | | | | | | | | | | | | | | | | Since commit da25a8ec6b2d ("staging: rtl8188eu: remove unused debugging functions") is_signal_dbg is never set to true, so the code under if (adapter->recvpriv.is_signal_dbg) is dead. Remove the variable and the dead code. The signal_strength_dbg was referenced only in the code that is being removed, so remove it as well. Also fix coding style issues in the touched lines. Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Cc: Larry Finger <Larry.Finger@lwfinger.net> Cc: Ivan Safonov <insafonov@gmail.com> Cc: devel@driverdev.osuosl.org Signed-off-by: Luca Ceresoli <luca@lucaceresoli.net> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: rtl8188eu: remove unused field bRxRSSIDisplay in struct adapterLuca Ceresoli2017-01-033-6/+0
| | | | | | | | | | | | | | | | Since commit da25a8ec6b2d ("staging: rtl8188eu: remove unused debugging functions") this field is never set set to any nonzero value, so it is actually always zero. It is also used only once, as a boolean inside an if(). This means the code under that if() is dead code, so remove it as well. Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Cc: Larry Finger <Larry.Finger@lwfinger.net> Cc: Ivan Safonov <insafonov@gmail.com> Cc: devel@driverdev.osuosl.org Signed-off-by: Luca Ceresoli <luca@lucaceresoli.net> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: rtl8188eu: In core directory, fixed 'missing a balnk line after ↵Yamanappagouda Patil2017-01-0311-3/+55
| | | | | | | | | declarations' warnings. Fixed checkpatch.pl warnings in rtl8188eu/core directory. Signed-off-by: Yamanappagouda Patil <goudapatilk@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: rtl8188eu: Fixed 'Missing a blank line after declarations' warnings.Yamanappagouda Patil2017-01-034-2/+9
| | | | | | | | Fixed checkpatch.pl 'Missing a blank line after declarations' in rtl8188eu module. Signed-off-by: Yamanappagouda Patil <goudapatilk@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: r8188eu: fix spelling mistake on xmitframe_coalseceColin Ian King2017-01-031-1/+1
| | | | | | | | trivial fix to spelling mistake of function name in debuf message, should be xmitframe_coalesce instead of xmitframe_coalsece. Signed-off-by: Colin Ian King <colin.king@canonical.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* Makefile: drop -D__CHECK_ENDIAN__ from cflagsMichael S. Tsirkin2016-12-161-1/+1
| | | | | | | | | | | That's the default now, no need for makefiles to set it. Signed-off-by: Michael S. Tsirkin <mst@redhat.com> Acked-by: Kalle Valo <kvalo@codeaurora.org> Acked-by: Marcel Holtmann <marcel@holtmann.org> Acked-by: Marc Kleine-Budde <mkl@pengutronix.de> Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Acked-by: Arend van Spriel <arend.vanspriel@broadcom.com>
* Merge tag 'staging-4.10-rc1' of ↵Linus Torvalds2016-12-1335-491/+202
|\ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging Pull staging/IIO updates from Greg KH: "Here's the "big" staging/iio pull request for 4.10-rc1. Not as big as 4.9 was, but still just over a thousand changes. We almost broke even of lines added vs. removed, as the slicoss driver was removed (got a "clean" driver for the same hardware through the netdev tree), and some iio drivers were also dropped, but I think we ended up adding a few thousand lines to the source tree in the end. Other than that it's a lot of minor fixes all over the place, nothing major stands out at all. All of these have been in linux-next for a while. There will be a merge conflict with Al's vfs tree in the lustre code, but the resolution for that should be pretty simple, that too has been in linux-next" * tag 'staging-4.10-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging: (1002 commits) staging: comedi: comedidev.h: Document usage of 'detach' handler staging: fsl-mc: remove unnecessary info prints from bus driver staging: fsl-mc: add sysfs ABI doc staging/lustre/o2iblnd: Fix misspelled attemps->attempts staging/lustre/o2iblnd: Fix misspelling intialized->intialized staging/lustre: Convert all bare unsigned to unsigned int staging/lustre/socklnd: Fix whitespace problem staging/lustre/o2iblnd: Add missing space staging/lustre/lnetselftest: Fix potential integer overflow staging: greybus: audio_module: remove redundant OOM message staging: dgnc: Fix lines longer than 80 characters staging: dgnc: fix blank line after '{' warnings. staging/android: remove Sync Framework tasks from TODO staging/lustre/osc: Revert erroneous list_for_each_entry_safe use staging: slicoss: remove the staging driver staging: lustre: libcfs: remove lnet upcall code staging: lustre: remove set but unused variables staging: lustre: osc: set lock data for readahead lock staging: lustre: import: don't reconnect during connect interpret staging: lustre: clio: remove mtime check in vvp_io_fault_start() ...
| * Staging: rtl8188eu: Fix code indention found by checkpatch.Victor Carvajal2016-10-301-1/+1
| | | | | | | | | | | | | | | | ERROR: code indent should use tabs where possible +^I^I uint in_len, uint initial_out_len);$ Signed-off-by: Victor Carvajal <carva005@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
| * staging: rtl8188eu: Standardize test for NULL.Elise Lennion2016-10-301-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The test for NULL of the return variable of functions was changed from (ret == NULL) to !ret to match the standard. Coccinelle was used with semantic patch: @@ expression e; identifier id, f; statement S; @@ f(...) { <+... id = \(kmalloc\|devm_kzalloc\|kmalloc_array\|devm_ioremap \|usb_alloc_urb\|alloc_netdev\|dev_alloc_skb\) (...) ... when any when != id = e + if (!id) - if (\(NULL == id\|id == NULL\)) S ...+> } Signed-off-by: Elise Lennion <elise.lennion@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
| * staging: rtl8188eu: os_dep: remove unnecessary alloc fail messagePierre-Yves Kerbrat2016-10-251-5/+3
| | | | | | | | | | | | | | | | Remove redundant alloc fail message This patch fixes the warning found by checkpatch Signed-off-by: Pierre-Yves Kerbrat <pkerbrat@free.fr> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
| * staging: rtl8188eu: os_dep: remove unnecessary parenthesesPierre-Yves Kerbrat2016-10-251-3/+3
| | | | | | | | | | | | | | Remove parentheses in _rtw_init_queue to fix checkpatch warning Signed-off-by: Pierre-Yves Kerbrat <pkerbrat@free.fr> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
| * staging: rtl8188eu: os_dep: fix missing spaces around operatorsPierre-Yves Kerbrat2016-10-251-2/+2
| | | | | | | | | | | | | | | | Fix missing space around operators in rtw_alloc2d function in osdep_service.c Signed-off-by: Pierre-Yves Kerbrat <pkerbrat@free.fr> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
| * staging: rtl8188eu: os_dep: fix block comment alignment issuePierre-Yves Kerbrat2016-10-251-3/+4
| | | | | | | | | | | | | | | | Fix coding style issue in block comment in osdep_service.c found by checkpatch tool Signed-off-by: Pierre-Yves Kerbrat <pkerbrat@free.fr> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
| * staging: rtl8188eu: os_dep: remove empty linesPierre-Yves Kerbrat2016-10-251-2/+0
| | | | | | | | | | | | | | Remove unnecessary empty lines (issue found by checkpatch) Signed-off-by: Pierre-Yves Kerbrat <pkerbrat@free.fr> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
| * staging:r8188eu: Remove space before commaAlex Briskin2016-10-251-2/+2
| | | | | | | | | | | | | | Trivial style fix to remove unnecessary errors in checkpatch.pl Signed-off-by: Alex Briskin <br.shurik@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
| * staging: rtl8188eu: Fix coding style errorsCarlos Maiolino2016-10-251-14/+14
| | | | | | | | | | | | | | | | | | | | | | Fix coding style errors reported by checkpatch.pl, specifically: ERROR: space prohibited before that ',' (ctx:WxW) This patch get rid of all "ERROR" messages from checkpatch.pl for this file Signed-off-by: Carlos Maiolino <cmaiolino28@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
| * staging: rtl8188eu: core: constify local structureElizabeth Ferdman2016-10-171-1/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Constify the static struct RTW_CHANNEL_PLAN_MAP_REALTEK_DEFINE. The only other instance was one of its properties being assigned to a variable: Index2G = RTW_CHANNEL_PLAN_MAP_REALTEK_DEFINE.Index2G; Therefore this is a good candidate for constification. Running size did not show any difference: Before/After: text data bss dec hex filename 44122 408 2974 47504 b990 Lastly, break up the long line to fix the checkpatch warning and conform to kernel coding style. Signed-off-by: Elizabeth Ferdman <gnudevliz@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
| * Staging: rtl8188eu: hal: Compress return logic into one lineMihaela Muraru2016-10-161-6/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Simplify function returns by merging assignment and return into one command line. Found with Coccinelle @@ expression e, ret; @@ -ret = +return e; -return ret; Signed-off-by: Mihaela Muraru <mihaela.muraru21@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
| * staging:r8188eu: remove unnecessary type cast for ↵Ivan Safonov2016-10-161-1/+1
| | | | | | | | | | | | | | | | | | update_recvframe_phyinfo_88e argument pphy_status alreay is (struct phy_stat *). Signed-off-by: Ivan Safonov <insafonov@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
| * staging:r8188eu: refactor recvbuf2recvframe functionIvan Safonov2016-10-161-16/+15
| | | | | | | | | | | | | | Reduce number of nesting levels. Signed-off-by: Ivan Safonov <insafonov@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
OpenPOWER on IntegriCloud