summaryrefslogtreecommitdiffstats
path: root/drivers/staging/rtl8188eu/hal
Commit message (Collapse)AuthorAgeFilesLines
* Revert "Staging: drivers: rtl8188eu: use sizeof(*ptr) instead of sizeof(struct)"Hans de Goede2016-06-171-1/+2
| | | | | | | | | | | | | | This reverts commit 99aded71b52c ("Staging: drivers: rtl8188eu: use sizeof(*ptr) instead of sizeof(struct)"). This commit is wrong, as adapt->HalData has a type of "void *", so now we are allocating a much to small struct, which causes the driver to overwrite random memory which leads to a non working driver and various system crashes. Cc: Jacky Boen <aqiank@gmail.com> Signed-off-by: Hans de Goede <hdegoede@redhat.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* Staging: drivers: rtl8188eu: use sizeof(*ptr) instead of sizeof(struct)Jacky Boen2016-05-011-2/+1
| | | | | | | Fix coding style issue Signed-off-by: Jacky Boen <aqiank@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* Staging: drivers: rtl8188eu: fixed extraneous spacesJacky Boen2016-05-011-2/+2
| | | | | | | Fix coding style issue Signed-off-by: Jacky Boen <aqiank@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* Staging: drivers: rtl8188eu: fixed extraneous parenthesesJacky Boen2016-05-011-15/+15
| | | | | | | Fix coding style issue Signed-off-by: Jacky Boen <aqiank@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* Staging: drivers: rtl8188eu: fixed extraneous indentationJacky Boen2016-05-011-1/+1
| | | | | | | Fixed coding style issue Signed-off-by: Jacky Boen <aqiank@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* Staging: drivers: rtl8188eu: fixed unnecessary else branchJacky Boen2016-05-011-3/+2
| | | | | | | Fixed coding style issue Signed-off-by: Jacky Boen <aqiank@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* Staging: drivers: rtl8188eu: fixed brace styleJacky Boen2016-05-011-2/+1
| | | | | | | Fixed coding style issue Signed-off-by: Jacky Boen <aqiank@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* Staging: drivers: rtl8188eu: fixed newlines styleJacky Boen2016-05-011-6/+1
| | | | | | | Fixed coding style issue Signed-off-by: Jacky Boen <aqiank@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* Staging: drivers: rtl8188eu: fixed block comments styleJacky Boen2016-05-011-3/+6
| | | | | | | Fixed coding style issue Signed-off-by: Jacky Boen <aqiank@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* Staging: drivers: rtl8188eu: fixed typoJacky Boen2016-05-011-1/+1
| | | | | | | Fixed typo Signed-off-by: Jacky Boen <aqiank@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* Staging: drivers: rtl8188eu: move constants to the right in comparisonsJacky Boen2016-05-011-2/+2
| | | | | | | Fixed coding style issue Signed-off-by: Jacky Boen <aqiank@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* Staging: rtl8188eu: usb_halinit: Use !x instead of x == NULL.Sandhya Bankar2016-03-281-1/+1
| | | | | | | Use !x instead of x == NULL. Signed-off-by: Sandhya Bankar <bankarsandhya512@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* Staging: rtl8188eu: rtl8188e_rxdesc: Use !x instead of x == NULL.Sandhya Bankar2016-03-281-1/+1
| | | | | | | Use !x instead of x == NULL. Signed-off-by: Sandhya Bankar <bankarsandhya512@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* Staging: rtl8188eu: hal_intf: Use x instead of x != NULL.Sandhya Bankar2016-03-281-1/+1
| | | | | | | Use x instead of x != NULL. Signed-off-by: Sandhya Bankar <bankarsandhya512@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* Staging: rtl8188eu: Hal8188ERateAdaptive: Use x instead of x != NULL.Sandhya Bankar2016-03-281-1/+1
| | | | | | | Use x instead of x != NULL. Signed-off-by: Sandhya Bankar <bankarsandhya512@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: rtl8188eu: Remove license paragraph with mailing addressKyle Kuffermann2016-03-2822-107/+0
| | | | | | | | | | | | | | This fixes the issue reported by checkpatch.pl: "Do not include the paragraph about writing to the Free Software Foundation's mailing address from the sample GPL notice. The FSF has changed addresses in the past, and may do so again. Linux already includes a copy of the GPL." in all files for the rtl8188eu driver. Signed-off-by: Kyle Kuffermann <kyle.kuffermann@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* Staging: rtl8188eu: removes an unnecessary cast on a void pointer.Ben Marsh2016-03-281-1/+1
| | | | | | | | Patch to rtl8188e_rxdesc.c to remove an unnecessary cast on a void pointer. Signed-off-by: Ben Marsh <bmarsg94@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: rtl8188eu: remove PWR_BASEADDR_* macro definitions and "base" ↵Ivan Safonov2016-03-111-2/+1
| | | | | | | | | | member of wl_pwr_cfg structure These macros and "base" member of wl_pwr_cfg structure are used only to produce debug output. Signed-off-by: Ivan Safonov <insafonov@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: rtl8188eu: remove PWR_INTF_*_MSK macro definitions and ↵Ivan Safonov2016-03-112-9/+7
| | | | | | | | | interface_mask of wl_pwr_cfg structure This driver is intended only for usb devices. Signed-off-by: Ivan Safonov <insafonov@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: rtl8188eu: remove PWR_FAB_*_MSK macro definitions and fab_msk of ↵Ivan Safonov2016-03-112-12/+7
| | | | | | | | | | | | | | wl_pwr_cfg structure fab_msk used for marking commands for devices of a certain manufacturer. However, always used only PWR_FAB_ALL_MSK value of fab_msk. Most likely, such mark is useless. Signed-off-by: Ivan Safonov <insafonov@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: rtl8188eu: remove FabVersion member of odm_dm_struct structIvan Safonov2016-03-112-7/+1
| | | | | | | | | Value of this variable is hardcoded and used only to produce debug output. Probably, FabVersion is useless. Signed-off-by: Ivan Safonov <insafonov@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: rtl8188eu: hal: Drop Useless InitializationBhaktipriya Shridhar2016-03-111-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | Removed initialisation of a varible if it is immediately reassigned. Changes were made using Coccinelle. @bad@ identifier i; position p; @@ i =@p <+...i...+>; @@ type T; constant C; expression e; identifier i; position p != bad.p; @@ T i - = C ; i =@p e; Signed-off-by: Bhaktipriya Shridhar <bhaktipriya96@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: rtl8188eu: Remove RF_PATH_C & RF_PATH_DAndrew Bradford2016-02-202-52/+0
| | | | | | | | RTL8188EE has a maximum of 2 RF paths (chains) so paths C and D are not needed to support this part. Signed-off-by: Andrew Bradford <andrew@bradfordembedded.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: rtl8188eu: add release_firmware() between request_firmware and ↵Ivan Safonov2016-02-111-1/+4
| | | | | | | | | function error exit Small memory leak fixed. Signed-off-by: Ivan Safonov <insafonov@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: rtl8188eu: remove pfirmware and fwsize of the hal_data_8188e structureIvan Safonov2016-02-111-11/+9
| | | | | | | | | | | | The pfirmware is used only in rtl88eu_download_fw function (except the kfree(rtlhal->pfirmware) in netdev_close). The fwsize not used after initialization at all. The pfirmvare replaced by fw_data and fwsize removed. Signed-off-by: Ivan Safonov <insafonov@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: rtl8188eu: remove _rtl88e_fill_dummyIvan Safonov2016-02-111-25/+20
| | | | | | | | | | | | The _rtl88e_fill_dummy function replaced by memset in rtl88eu_download_fw. More appropriate names are used for pfwdata and fwsize variables (download_data and download_size respectively). Also u32 replaced by size_t for download_size variable. Signed-off-by: Ivan Safonov <insafonov@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: rtl8188eu: rarely used macros replaced by their definitionsIvan Safonov2015-11-152-8/+8
| | | | | | | IS_* macros (except one) occur only once. Signed-off-by: Ivan Safonov <insafonov@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: rtl8188eu: for loop instead of while loop usedIvan Safonov2015-11-151-10/+4
| | | | | | | | The range of elements to fill with zeros is determined by using a roundup macro Signed-off-by: Ivan Safonov <insafonov@gmail.com> Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: rtl8188eu: offset renamed to write_addressIvan Safonov2015-11-151-6/+6
| | | | | | | This name is better suited for this variable. Signed-off-by: Ivan Safonov <insafonov@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: rtl8188eu: pu4BytePtr renamed to dword_bufferIvan Safonov2015-11-151-2/+2
| | | | | | | This name is better suited for this variable. Signed-off-by: Ivan Safonov <insafonov@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: rtl8188eu: buf_ptr renamed to byte_bufferIvan Safonov2015-11-151-3/+3
| | | | | | | This name is better suited for this variable. Signed-off-by: Ivan Safonov <insafonov@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: rtl8188eu: unnessesary braces for single statement block removedIvan Safonov2015-11-151-4/+2
| | | | | | | | checkpatch fix: WARNING: braces {} are not necessary for single statement blocks Signed-off-by: Ivan Safonov <insafonov@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: rtl8188eu: unnecessary initialization removedIvan Safonov2015-11-151-1/+1
| | | | | | | It is superfluous. Signed-off-by: Ivan Safonov <insafonov@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: rtl8188eu: types of local variables conformed with types of ↵Ivan Safonov2015-11-151-2/+2
| | | | | | | | | function arguments The array should not change in any case. Signed-off-by: Ivan Safonov <insafonov@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: rtl8188eu: buf_ptr variable completely defined in a single lineIvan Safonov2015-11-151-1/+1
| | | | | | | It is simpler. Signed-off-by: Ivan Safonov <insafonov@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: rtl8188eu: offset increment placed into for loop headerIvan Safonov2015-11-151-4/+3
| | | | | | | It makes the code little easier. Signed-off-by: Ivan Safonov <insafonov@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: rtl8188eu: unnecessary branching removedIvan Safonov2015-11-151-5/+3
| | | | | | | If the 'remain' is zero, the loop is not executed at all. Signed-off-by: Ivan Safonov <insafonov@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: rtl8188eu: unnecessary variable override removedIvan Safonov2015-11-151-3/+1
| | | | | | | Variable value calculated in the previous loop. Signed-off-by: Ivan Safonov <insafonov@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: rtl8188eu: offset variable replaced by its valueIvan Safonov2015-11-151-1/+1
| | | | | | | It is now possible to get rid of re-initializing the offset variable. Signed-off-by: Ivan Safonov <insafonov@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: rtl8188eu: initial value placed in the variableIvan Safonov2015-11-151-3/+2
| | | | | | | | Line become shorter. After the loop offset variable points to the location following insertion. Signed-off-by: Ivan Safonov <insafonov@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: rtl8188eu: assigning a value to the variable is replaced by the ↵Ivan Safonov2015-11-151-1/+3
| | | | | | | | | increment It is made to the initial value could be placed in the offset variable. Signed-off-by: Ivan Safonov <insafonov@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: rtl8188eu: *(ptr + i) replaced by ptr[i] in _rtl88e_fw_block_writeIvan Safonov2015-11-151-2/+2
| | | | | | | It is better to read. Signed-off-by: Ivan Safonov <insafonov@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: rtl8188eu: 'infinite' loop removedIvan Safonov2015-11-151-19/+15
| | | | | | | | The body of this loop is executed only once, so it can be removed. In this loop no keyword 'continue', only 'break' at the end. Signed-off-by: Ivan Safonov <insafonov@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: rtl8188eu: add missing delay in polling loops.Rémy Oudompheng2015-11-151-1/+2
| | | | | | | Previously the code could exit with failure too early. Signed-off-by: Rémy Oudompheng <remyoudompheng@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: rtl8188eu: jiffies are unsigned longRémy Oudompheng2015-11-152-6/+8
| | | | | | | | Remove rtw_get_passing_time_ms function and adjust type of relevant variables. Signed-off-by: Rémy Oudompheng <remyoudompheng@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: rtl8188eu: pwrGrpCnt variable removed in store_pwrindex_offset functionIvan Safonov2015-10-291-2/+1
| | | | | | | | This variable used only once in the beginning of the function, it can be removed. Signed-off-by: Ivan Safonov <insafonov@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: rtl8188eu: new variable for ↵Ivan Safonov2015-10-291-16/+18
| | | | | | | | | hal_data->MCSTxPowerLevelOriginalOffset[pwrGrpCnt] in store_pwrindex_offset function hal_data->MCSTxPowerLevelOriginalOffset[pwrGrpCnt] frequent in this function, so it replaced by the power_level_offset new variable. Signed-off-by: Ivan Safonov <insafonov@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: rtl8188eu: checkpatch fixes: 'Avoid CamelCase' in hal/bb_cfg.cIvan Safonov2015-10-291-6/+6
| | | | | | | This is checkpatch fixes for hal/bb_cfg.c file: Avoid CamelCase. Signed-off-by: Ivan Safonov <insafonov@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: rtl8188eu: checkpatch fixes: line over 80 characters splited into ↵Ivan Safonov2015-10-291-4/+8
| | | | | | | | | | two parts This is checkpatch fixes for hal/bb_cfg.c file: line over 80 characters. Signed-off-by: Ivan Safonov <insafonov@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: rtl8188eu: checkpatch fixes: alignment should match open parenthesisIvan Safonov2015-10-291-1/+1
| | | | | | | | This is checkpatch fixes for hal/bb_cfg.c file: alignment should match open parenthesis. Signed-off-by: Ivan Safonov <insafonov@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
OpenPOWER on IntegriCloud