summaryrefslogtreecommitdiffstats
path: root/drivers/staging/panel
Commit message (Collapse)AuthorAgeFilesLines
* staging: panel: fix block comment usageAlex Wilson2015-07-311-4/+8
| | | | | | | Fixed two coding style warnings concerning multiline comments. Signed-off-by: Alex Wilson <alex.david.wilson@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* Merge tag 'staging-4.2-rc1' of ↵Linus Torvalds2015-06-261-39/+21
|\ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging Pull staging driver updates from Greg KH: "Here's the big, really big, staging tree patches for 4.2-rc1. Loads of stuff in here, almost all just coding style fixes / churn, and a few new drivers as well, one of which I just disabled from the build a few minutes ago due to way too many build warnings. Other than the one "disable this driver" patch, all of these have been in linux-next for quite a while with no reported issues" * tag 'staging-4.2-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging: (1163 commits) staging: wilc1000: disable driver due to build warnings Staging: rts5208: fix CHANGE_LINK_STATE value Staging: sm750fb: ddk750_swi2c.c: Insert spaces before parenthesis Staging: sm750fb: ddk750_swi2c.c: Place braces on correct lines Staging: sm750fb: ddk750_swi2c.c: Insert spaces around operators Staging: sm750fb: ddk750_swi2c.c: Replace spaces with tabs Staging: sm750fb: ddk750_swi2c.h: Shorten lines to under 80 characters Staging: sm750fb: ddk750_swi2c.h: Replace spaces with tabs Staging: sm750fb: modedb.h: Shorten lines to under 80 characters Staging: sm750fb: modedb.h: Replace spaces with tabs staging: comedi: addi_apci_3120: rename 'this_board' variables staging: comedi: addi_apci_1516: rename 'this_board' variables staging: comedi: ni_atmio: cleanup ni_getboardtype() staging: comedi: vmk80xx: sanity check context used to get the boardinfo staging: comedi: vmk80xx: rename 'boardinfo' variables staging: comedi: dt3000: rename 'this_board' variables staging: comedi: adv_pci_dio: rename 'this_board' variables staging: comedi: cb_pcidas64: rename 'thisboard' variables staging: comedi: cb_pcidas: rename 'thisboard' variables staging: comedi: me4000: rename 'thisboard' variables ...
| * staging: panel: use schedule_timeout_interruptible()Nicholas Mc Guire2015-05-311-5/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | API consolidation with coccinelle found: ./drivers/staging/panel/panel.c:782:2-18: consolidation with schedule_timeout_*() recommended This is a 1:1 conversion with respect to schedule_timeout() to the schedule_timeout_interruptible() helper only - so only an API consolidation to improve readability. The timeout was being passed as (ms * HZ + 999) / 1000 but that simply looks wrong - rather than "manual" converting to jiffies, msecs_to_jiffies which handles all corner-cases correctly, was used. Patch was compile tested with x86_64_defconfig + CONFIG_STAGING=y, CONFIG_PARPORT=m, CONFIG_PANEL=m Signed-off-by: Nicholas Mc Guire <hofrat@osadl.org> Acked-by: Willy Tarreau <w@1wt.eu> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
| * staging: panel: fix stackdumpSudip Mukherjee2015-05-241-23/+21
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | if we load the module, unload and then again try to load the module, we will get a stackdump. In the module_exit function we are unregistering the device and releasing the parport. So when we reach the detach function parport is already null and the unregister_reboot_notifier() is never called. When we again try to load the module it again tries register_reboot_notifier() and gives us a stackdump as its earlier registration is still not removed. It was caused by the commit bb046fef9668 ('staging: panel: register reboot') Fix this by moving all the unregistering and releasing in the detach function, which should be the ideal case as the detach will be called if we try to unregister the driver or if the parport is removed. Fixes: bb046fef9668 ('staging: panel: register reboot') Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
| * staging: panel: remove duplicate codeSudip Mukherjee2015-04-301-14/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | both the misc_deregister(), parport_release() and parport_unregister_device() is there in the module_exit function also. detach is called from parport_unregister_driver() and by the time detach executes misc_deregister(), parport_release() and parport_unregister_device() has already executed marking keypad_initialized and lcd.initialized as false. so this part of the code will never execute. Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org> Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* | staging: panel: use new parport device modelSudip Mukherjee2015-06-011-5/+9
|/ | | | | | | Converted to use the new device-model parallel port. Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: panel: fix lcd typeSudip Mukherjee2015-03-261-6/+6
| | | | | | | | | | | | | | | | | | the lcd type as defined in the Kconfig is not matching in the code. as a result the rs, rw and en pins were getting interchanged. Kconfig defines the value of PANEL_LCD to be 1 if we select custom configuration but in the code LCD_TYPE_CUSTOM is defined as 5. my hardware is LCD_TYPE_CUSTOM, but the pins were assigned to it as pins of LCD_TYPE_OLD, and it was not working. Now values are corrected with referenece to the values defined in Kconfig and it is working. checked on JHD204A lcd with LCD_TYPE_CUSTOM configuration. Cc: <stable@vger.kernel.org> # 2.6.32+ Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org> Acked-by: Willy Tarreau <w@1wt.eu> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: panel: remove initialization checkSudip Mukherjee2015-03-201-11/+0
| | | | | | | | | | | no need to monitor init_in_progress now as keypad_send_key() can only be called after the timer is initialized. and timer is initialized from keypad_init() which is in the attach section and can only execute after the module has initialized. Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org> Acked-by: Willy Tarreau <w@1wt.eu> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: panel: return register valueSudip Mukherjee2015-03-201-3/+4
| | | | | | | | | we were returning success even if the module failed to register. now we are returning the actual return value, success or error. Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org> Acked-by: Willy Tarreau <w@1wt.eu> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: panel: register rebootSudip Mukherjee2015-03-201-4/+3
| | | | | | | | | | | we donot need the reboot notifier in module init section, as the notifier is used after lcd is initialized. so lets register for the reboot notifier only after we have successfully attached to the parallel port. and similarly unregister at detach. Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org> Acked-by: Willy Tarreau <w@1wt.eu> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: panel: initialize lcd if lcd enabledSudip Mukherjee2015-03-061-19/+22
| | | | | | | | initialiaze lcd parameters only if lcd is enabled. Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org> Acked-by: Willy Tarreau <w@1wt.eu> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: panel: register driver after checking deviceSudip Mukherjee2015-03-061-12/+6
| | | | | | | | | register the driver only if lcd or keypad has been enabled and if both are disabled then just exit. Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org> Acked-by: Willy Tarreau <w@1wt.eu> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: panel: replace init_timer by setup_timerAya Mahfouz2015-02-261-3/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | This patch replaces init_timer and the 2 step initialization of function and data by setup_timer to make the code more concise. The issue was discovered using the following coccinelle script: @@ expression ds, e1, e2; @@ -init_timer (&ds); +setup_timer (&ds, e1, e2); ... ( -ds.function = e1; ... -ds.data = e2; | -ds.data = e2; ... -ds.function = e1; ) Signed-off-by: Aya Mahfouz <mahfouz.saif.elyazal@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* drivers/staging: use current->state helpersDavidlohr Bueso2015-01-281-1/+1
| | | | | | | | | Call __set_current_state() instead of assigning the new state directly. These interfaces also aid CONFIG_DEBUG_ATOMIC_SLEEP environments, keeping track of who changed the state. Signed-off-by: Davidlohr Bueso <dbueso@suse.de> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: panel: Remove magic numbers in LCD commandsMariusz Gorski2015-01-121-30/+66
| | | | | | | | | Get rid of magic numbers in LCD commands and replace them with defined values, so that it's more obvious that the commands are doing. Signed-off-by: Mariusz Gorski <marius.gorski@gmail.com> Acked-by: Willy Tarreau <w@1wt.eu> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: panel: Remove unused variableMariusz Gorski2015-01-121-6/+0
| | | | | | | | | Remove lcd.left_shift because it is only written to at some places but never read from. Signed-off-by: Mariusz Gorski <marius.gorski@gmail.com> Acked-by: Willy Tarreau <w@1wt.eu> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: panel: Move LCD-related state into struct lcdMariusz Gorski2014-12-021-121/+134
| | | | | | | | | | Move more or less all LCD-related state into struct lcd in order to get better cohesion; use bool instead of int where it makes sense. Signed-off-by: Mariusz Gorski <marius.gorski@gmail.com> Acked-by: Willy Tarreau <w@1wt.eu> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: panel: Remove more magic number comparisonMariusz Gorski2014-12-021-10/+10
| | | | | | | | | Use a defined value instead of magic number comparison for checking whether a module param value has been set. Signed-off-by: Mariusz Gorski <marius.gorski@gmail.com> Acked-by: Willy Tarreau <w@1wt.eu> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: panel: Refactor LCD init codeMariusz Gorski2014-12-021-141/+163
| | | | | | | | | | | Rework lcd_init method to make it a little bit more clear about the precedence of the params, move LCD geometry and pins layout to the LCD struct and thus make the LCD-related module params effectively read-only. Signed-off-by: Mariusz Gorski <marius.gorski@gmail.com> Acked-by: Willy Tarreau <w@1wt.eu> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: panel: Make two more module params read-onlyMariusz Gorski2014-12-021-34/+37
| | | | | | | | | | | Make keypad_type and lcd_type module params read-only. This step also starts making it more clear what is the precedence of device params coming from different sources (device profile, runtime module param values etc). Signed-off-by: Mariusz Gorski <marius.gorski@gmail.com> Acked-by: Willy Tarreau <w@1wt.eu> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: panel: Start making module params read-onlyMariusz Gorski2014-12-021-14/+21
| | | | | | | | | | Start decoupling module params from the actual device state, both for lcd and keypad, by keeping the params read-only and moving the device state to related structs. Signed-off-by: Mariusz Gorski <marius.gorski@gmail.com> Acked-by: Willy Tarreau <w@1wt.eu> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: panel: Use defined value or checking module params stateMariusz Gorski2014-12-021-43/+43
| | | | | | | | | | Avoid magic number and use a comparison with a defined value instead that checks whether module param has been set by the user to some value at loading time. Signed-off-by: Mariusz Gorski <marius.gorski@gmail.com> Acked-by: Willy Tarreau <w@1wt.eu> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: panel: Remove magic numbersMariusz Gorski2014-12-021-10/+12
| | | | | | | | | Get rid of magic numbers indicating that the value of a module param is not set. Use a defined value instead. Signed-off-by: Mariusz Gorski <marius.gorski@gmail.com> Acked-by: Willy Tarreau <w@1wt.eu> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: panel: Call init function directlyMariusz Gorski2014-12-021-6/+1
| | | | | | | | | Remove useless function and let the kernel call the actual init function directly. Signed-off-by: Mariusz Gorski <marius.gorski@gmail.com> Acked-by: Willy Tarreau <w@1wt.eu> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: panel: Set default parport module param valueMariusz Gorski2014-12-021-4/+1
| | | | | | | | | Set default parport module param value to DEFAULT_PARPORT so that a if-block can be avoided. Signed-off-by: Mariusz Gorski <marius.gorski@gmail.com> Acked-by: Willy Tarreau <w@1wt.eu> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: panel: Use better names for two defined valuesMariusz Gorski2014-11-261-8/+8
| | | | | | | | | Give DEFAULT_KEYPAD and DEFAULT_LCD defines better names, so that their meaning is emphasized. Signed-off-by: Mariusz Gorski <marius.gorski@gmail.com> Acked-By: Willy Tarreau <w@1wt.eu> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: panel: Reorder module parameter declarationsMariusz Gorski2014-11-261-35/+38
| | | | | | | | | Change the order of the module parameter declarations so that it matches the Kconfig order. Signed-off-by: Mariusz Gorski <marius.gorski@gmail.com> Acked-By: Willy Tarreau <w@1wt.eu> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: panel: Reorder DEFAULT_* values redefinesMariusz Gorski2014-11-261-13/+13
| | | | | | | | | Change the order of the DEFAULT_* values redefines so that it matches the Kconfig order. Signed-off-by: Mariusz Gorski <marius.gorski@gmail.com> Acked-By: Willy Tarreau <w@1wt.eu> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: panel: Reorder initial DEFAULT_* definesMariusz Gorski2014-11-261-4/+4
| | | | | | | | | Change the order of the initial DEFAULT_* defines so that it matches the Kconfig order. Signed-off-by: Mariusz Gorski <marius.gorski@gmail.com> Acked-By: Willy Tarreau <w@1wt.eu> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: panel: Fix single-open policy race conditionMariusz Gorski2014-11-051-9/+10
| | | | | | | | Fix the implementation of a single-open policy for both devices (lcd and keypad) by using atomic_t instead of plain ints. Signed-off-by: Mariusz Gorski <marius.gorski@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: panel: Remove outdated TODO taskMariusz Gorski2014-11-031-1/+0
| | | | | | | Remove Lindent task from TODO file as it's obsolete. Signed-off-by: Mariusz Gorski <marius.gorski@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: panel: Use designated initializersMariusz Gorski2014-10-291-6/+6
| | | | | | | | Fix "warning: missing initializer [-Wmissing-field-initializers]" by using designated struct initializers. Signed-off-by: Mariusz Gorski <marius.gorski@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* Staging: panel: fixed frivilous else statement warningVincent Heuken2014-07-101-4/+5
| | | | | | | | | Fixed one instance of the following checkpatch.pl warning in panel.c: WARNING: else is not generally useful after a break or return Signed-off-by: Vincent Heuken <me@vincentheuken.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: panel: (coding style) Multiple assignmentsDominique van den Broeck2014-05-251-13/+30
| | | | | | | | Style-only modifications to comply with checkpatch.pl --strict --file. . Breaks down compound assignments. Signed-off-by: Dominique van den Broeck <domdevlin@free.fr> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: panel: (coding style) Line alignments and malloc sizeofDominique van den Broeck2014-05-231-13/+11
| | | | | | | | | | Style-only modifications to comply with checkpatch.pl --strict --file. . Correctly realigns the lines that needed to be ; . Suppress useless blank rows ; . Fix sizeof() issues in various -malloc() functions. Signed-off-by: Dominique van den Broeck <domdevlin@free.fr> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: panel: (coding style) Matching bracesDominique van den Broeck2014-05-231-10/+11
| | | | | | | | Style-only modifications to comply with checkpatch.pl --strict --file. . Adds every missing brace in condition statements. Signed-off-by: Dominique van den Broeck <domdevlin@free.fr> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: panel: fix regression in lcd_writeBastien Armand2014-05-231-1/+1
| | | | | | | | This patch fix a regression in lcd_write caused by commit 70a8c3eb8546cefe40fb0bc7991e8899b7b91075 Signed-off-by: Bastien Armand <armand.bastien@laposte.net> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: panel: add blank lines after declarationsBastien Armand2014-04-181-0/+15
| | | | | | | This patch fixes "Missing a blank line after declarations" checkpatch warnings in panel.c. Signed-off-by: Bastien Armand <armand.bastien@laposte.net> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: panel: fix sparse warnings in keypad_readBastien Armand2014-04-181-2/+2
| | | | | | | | | This patch fixes two sparse warnings related to keypad_read : warning: incorrect type in argument 1 (different address spaces) warning: incorrect type in initializer (incompatible argument 2 (different address spaces)) Signed-off-by: Bastien Armand <armand.bastien@laposte.net> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: panel: fix sparse warnings in lcd_writeBastien Armand2014-04-181-96/+109
| | | | | | | | | | | | | | | This patch fixes two sparse warnings related to lcd_write : warning: incorrect type in argument 1 (different address spaces) warning: incorrect type in initializer (incompatible argument 2 (different address spaces)) lcd_write can be used from kernel space (in panel_lcd_print) or from user space. So we introduce the lcd_write_char function that will write a char to the device. We modify lcd_write and panel_lcd_print to use it. Finally we add __user annotation missing in lcd_write. Signed-off-by: Bastien Armand <armand.bastien@laposte.net> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: panel: replace del_timer by del_timer_syncJulia Lawall2014-04-181-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Use del_timer_sync to ensure that the timer is stopped on all CPUs before the driver exists. This change was suggested by Thomas Gleixner. The semantic patch that makes this change is as follows: (http://coccinelle.lip6.fr/) // <smpl> @r@ declarer name module_exit; identifier ex; @@ module_exit(ex); @@ identifier r.ex; @@ ex(...) { <... - del_timer + del_timer_sync (...) ...> } // </smpl> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* Staging: panel: Fix quoted string split across line in panel.cMonam Agarwal2014-02-271-18/+9
| | | | | | | | This patch fixes the following checkpatch.pl warning in panel.c: WARNING: quoted string split across lines Signed-off-by: Monam Agarwal <monamagarwal123@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* Staging: panel: Fix space prohibited between function name and open paranthesisMonam Agarwal2014-02-271-7/+7
| | | | | | | | This patch fixes the following checkpatch.pl issues in panel.c: WARNING: space prohibited between function name and open parenthesis '(' Signed-off-by: Monam Agarwal <monamagarwal123@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: panel: fix interruptible_sleep_on raceArnd Bergmann2014-01-091-2/+2
| | | | | | | | | | | | interruptible_sleep_on is racy and going away. This replaces the one caller in the panel driver with the appropriate wait_event_interruptible variant. Signed-off-by: Arnd Bergmann <arnd@arndb.de> Cc: devel@driverdev.osuosl.org Cc: Willy Tarreau <willy@meta-x.org> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* Staging: Panel: panel: Fixed checkpatch line length warningsJake Champlin2013-05-161-11/+14
| | | | | | | | | Fixed 4 cases of line length issues with checkpatch. Checkpatch is now clean for panel.c. Signed-off-by: 'Jake Champlin <jake.champlin.27@gmail.com>' Acked-by: Willy Tarreau <w@1wt.eu> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging/panel: Mark local functions/structs static and add const if ↵Peter Huewe2013-02-151-15/+16
| | | | | | | | | | | | | | | | | | | | | | | applicable (fix sparse warnings) sparse complains about the following functions: panel.c:188:1: warning: symbol 'logical_inputs' was not declared. Should it be static? panel.c:569:6: warning: symbol 'old_keypad_profile' was not declared. Should it be static? panel.c:580:6: warning: symbol 'new_keypad_profile' was not declared. Should it be static? panel.c:593:6: warning: symbol 'nexcom_keypad_profile' was not declared. Should it be static? panel.c:672:6: warning: symbol 'pin_to_bits' was not declared. Should it be static? panel.c:1375:6: warning: symbol 'panel_lcd_print' was not declared. Should it be static? panel.c:1382:6: warning: symbol 'lcd_init' was not declared. Should it be static? panel.c:2181:5: warning: symbol 'panel_init' was not declared. Should it be static? Add the static keyword to silence these warnings and make sparse happy. If structs or function parameters are used readonly they are also marked as const. CC: David Howells <dhowells@redhat.com> Signed-off-by: Peter Huewe <peterhuewe@gmx.de> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: panel: pass correct lengths to keypad_send_key()Dan Carpenter2012-11-291-4/+4
| | | | | | | | | | | | | We changed the sizeof() statements in 429ccf058b "staging:panel: Fixed coding conventions." so that they could fit inside the 80 character line limit. Unfortunately, the new sizeof() statements are a smaller size. This reverts it. There isn't a nice way to stay within the 80 character limit without a re-work so I've gone over. Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: Fix misspellings of "whether".Adam Buchbinder2012-09-211-2/+2
| | | | | | | | "Whether" is spelled "wether" in several places. This fixes those that are in the staging tree. Signed-off-by: Adam Buchbinder <adam.buchbinder@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* Staging: panel: fix spinlock trylock failure on UPFengguang Wu2012-09-101-22/+22
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Use spin_lock_irq() to quiet warning: [ 8.232324] BUG: spinlock trylock failure on UP on CPU#0, reboot/85 [ 8.234138] lock: c161c760, .magic: dead4ead, .owner: reboot/85, .owner_cpu: 0 [ 8.236132] Pid: 85, comm: reboot Not tainted 3.4.0-rc7-00656-g82163ed #5 [ 8.237965] Call Trace: [ 8.238648] [<c13dfd20>] ? printk+0x18/0x1a [ 8.239827] [<c122a5e0>] spin_dump+0x80/0xd0 [ 8.241016] [<c122a652>] spin_bug+0x22/0x30 [ 8.242181] [<c122a93b>] do_raw_spin_trylock+0x5b/0x70 [ 8.243611] [<c13e8bae>] _raw_spin_trylock+0xe/0x60 [ 8.244975] [<c1392230>] ? keypad_send_key.constprop.9+0xe0/0xe0 ==> [ 8.246638] [<c13922ea>] panel_scan_timer+0xba/0x570 [ 8.248019] [<c1392230>] ? keypad_send_key.constprop.9+0xe0/0xe0 [ 8.249689] [<c102f6f5>] run_timer_softirq+0x1e5/0x370 [ 8.251191] [<c102f645>] ? run_timer_softirq+0x135/0x370 [ 8.252718] [<c1392230>] ? keypad_send_key.constprop.9+0xe0/0xe0 [ 8.254462] [<c102a592>] __do_softirq+0xc2/0x1c0 [ 8.255758] [<c102a4d0>] ? local_bh_enable_ip+0x130/0x130 [ 8.257228] <IRQ> [<c102a855>] ? irq_exit+0x65/0x70 [ 8.258647] [<c1013ff9>] ? smp_apic_timer_interrupt+0x49/0x80 [ 8.260226] [<c13e96c1>] ? apic_timer_interrupt+0x31/0x38 [ 8.261737] [<c12700e0>] ? drm_vm_open_locked+0x70/0xb0 [ 8.263166] [<c122489a>] ? delay_tsc+0x1a/0x30 [ 8.264452] [<c12248c9>] ? __delay+0x9/0x10 [ 8.265621] [<c12248ec>] ? __const_udelay+0x1c/0x20 ==> [ 8.266967] [<c139136c>] ? lcd_clear_fast_p8+0x9c/0xe0 [ 8.268386] [<c1391a66>] ? lcd_write+0x226/0x810 [ 8.269653] [<c1367900>] ? md_set_readonly+0xc0/0xc0 [ 8.271013] [<c122a9ed>] ? do_raw_spin_unlock+0x9d/0xe0 [ 8.272470] [<c1392a98>] ? panel_lcd_print+0x38/0x40 [ 8.273837] [<c1392ace>] ? panel_notify_sys+0x2e/0x60 [ 8.275224] [<c1046634>] ? notifier_call_chain+0x84/0xb0 [ 8.276754] [<c10469ce>] ? __blocking_notifier_call_chain+0x3e/0x60 [ 8.278576] [<c1046a0a>] ? blocking_notifier_call_chain+0x1a/0x20 [ 8.280267] [<c1036a14>] ? kernel_restart_prepare+0x14/0x40 [ 8.281901] [<c1036a8e>] ? kernel_restart+0xe/0x50 [ 8.283216] [<c1036ce9>] ? sys_reboot+0x149/0x1e0 [ 8.284532] [<c10b3fb3>] ? handle_pte_fault+0x93/0xd70 [ 8.285956] [<c1019e35>] ? do_page_fault+0x215/0x5e0 [ 8.287330] [<c101a113>] ? do_page_fault+0x4f3/0x5e0 [ 8.288704] [<c1045ac6>] ? up_read+0x16/0x30 [ 8.289890] [<c101a113>] ? do_page_fault+0x4f3/0x5e0 [ 8.291252] [<c10d4486>] ? iterate_supers+0x86/0xd0 [ 8.292615] [<c122a9ed>] ? do_raw_spin_unlock+0x9d/0xe0 [ 8.294049] [<c13e8dcd>] ? _raw_spin_unlock+0x1d/0x20 [ 8.295449] [<c10d44ab>] ? iterate_supers+0xab/0xd0 [ 8.296795] [<c10fb620>] ? __sync_filesystem+0xa0/0xa0 [ 8.298199] [<c13e9b03>] ? sysenter_do_call+0x12/0x37 [ 8.306899] Restarting system. [ 8.307747] machine restart Signed-off-by: Fengguang Wu <fengguang.wu@intel.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: panel: fix checkpatch warningsToshiaki Yamane2012-08-131-2/+2
| | | | | | | | | | | | Now checkpatch clean. $ find drivers/staging/panel -name "*.[ch]"|xargs ./scripts/checkpatch.pl \ -f --terse --nosummary|cut -f3- -d":"|sort |uniq -c|sort -n 2 WARNING: Single statement macros should not use a do {} while (0) loop Signed-off-by: Toshiaki Yamane <yamanetoshi@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
OpenPOWER on IntegriCloud