summaryrefslogtreecommitdiffstats
path: root/drivers/staging/ks7010
Commit message (Collapse)AuthorAgeFilesLines
* staging: ks7010: Fix brace style issue in ks_wlan_net.cDavid Wittman2017-01-161-2/+3
| | | | | | | | This change fixes a checkpatch error for "that open brace { should be on the previous line" as well as a related spacing warning. Signed-off-by: David Wittman <dwittman@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* Staging: ks7010: ks7010_sdio.h: Trailing whitespaceManoj Sawai2017-01-031-1/+1
| | | | | | | Removed trailing whitespace. Signed-off-by: Manoj Sawai <mas@iitkgp.ac.in> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* Staging: ks7010: ks7010_sdio.h: Complex macro not in parenthesesManoj Sawai2017-01-031-1/+1
| | | | | | | Fixed coding style error. Complex macro not inside parentheses. Signed-off-by: Manoj Sawai <mas@iitkgp.ac.in> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* Staging: ks7010: ks7010_stio.h: fixed coding style errorManoj Sawai2016-12-061-2/+2
| | | | | | | Fixed 2 coding style errors about trailing whitespaces. Signed-off-by: Manoj Sawai <mas@iitkgp.ac.in> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: ks7010: fixed 'space prohibited after that *' erros.Yamanappagouda Patil2016-12-061-6/+6
| | | | | | | | Fixed checkpatch.pl errors related to "space prohibited after that '*' or '&'" in ks_wlan_net.c file. Signed-off-by: Yamanappagouda Patil <goudapatilk@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: ks7010: Fixed 'missing blank line after declaration' warnings.Yamanappagouda Patil2016-12-061-0/+7
| | | | | | | | Fixed checkpatch.pl warnings 'Missing blank line after declaration' in ks_wlan_net.c file. Signed-off-by: Yamanappagouda Patil <goudapatilk@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* Staging: ks7010: Fixed {} brace warnings for single statement blocks.Yamanappagouda Patil2016-11-291-106/+66
| | | | | | | | Fixed checkpatch.pl warnings related to {} brace warnings for single statement blocks. Signed-off-by: Yamanappagouda Patil <goudapatilk@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* Staging: ks7010: Use preffered kernel typesPunit Vara2016-11-163-83/+83
| | | | | | | | Replace uint8_t, uint16_t and uint32_t with preferred kernel types u8, u16 and u32 respectively suggested by checkpatch.pl Signed-off-by: Punit Vara <punitvara@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* Staging: ks7010: Prefer using the BIT macroPunit Vara2016-11-141-8/+8
| | | | | | | | | Replace all occurences of (1<<x) by BIT(x) in the file ks7010_sdio.h to get rid of checkpatch.pl "CHECK" output "Prefer using BIT macro". Signed-off-by: Punit Vara <punitvara@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: ks7010: add a blank line after declarationsJiong Du2016-10-271-0/+2
| | | | | | | Fixes checkpatch warning: Missing a blank line after declarations Signed-off-by: Jiong Du <jiongdu0.0@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: ks7010: split long lineJiong Du2016-10-271-1/+2
| | | | | | | Fixes checkpatch warning: line over 80 characters Signed-off-by: Jiong Du <jiongdu0.0@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: ks7010: remove space before tabJiong Du2016-10-271-3/+3
| | | | | | | Fixes checkpatch warning: space before tabs Signed-off-by: Jiong Du <jiongdu0.0@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: ks7010: fix complex macro errorJiong Du2016-10-271-1/+1
| | | | | | | Fixes checkpatch error: Macros with complex values should be enclosed in parentheses Signed-off-by: Jiong Du <jiongdu0.0@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: ks7010: fix spacing errorsJiong Du2016-10-271-8/+8
| | | | | | | Fixes checkpatch errors: spacing errors Signed-off-by: Jiong Du <jiongdu0.0@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: ks7010: Remove trailing whitespaceJiong Du2016-10-251-6/+6
| | | | | | | Fixes checkpatch error: tailing whitespace Signed-off-by: Jiong Du <jiongdu0.0@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: ks7010: ks7010_sdio.c: Fixing multiple assignmentsNick Rosbrook2016-10-251-2/+4
| | | | | | | | | | Running checkpatch on ks7010_sdio.c shows two locations where multiple assignment statements are used. This patch modifies the assignments into single assignments. Signed-off-by: Nick Rosbrook <nrosbrook@mail.smcvt.edu> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: ks7010: Corrected a spelling mistakeNick Rosbrook2016-10-251-1/+1
| | | | | | | | | This patch corrects the spelling of 'initialize' in ks7010_sdio.c. The issue was found by checkpatch. Signed-off-by: Nick Rosbrook <nrosbrook@mail.smcvt.edu> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: ks7010: Add spaces around '*'Nick Rosbrook2016-10-251-1/+1
| | | | | | | Added spaces around a '*' in ks7010_sdio.c. Issue found by checkpatch. Signed-off-by: Nick Rosbrook <nrosbrook@mail.smcvt.edu> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: ks7010: ks_wlan_net: Use setup_timer instead of init_timer and data ↵Wei Yongjun2016-10-251-3/+2
| | | | | | | | | | fields Use setup_timer function instead of initializing timer with the function and data fields Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: ks7010: convert list_for_each to entry variantWei Yongjun2016-10-251-3/+1
| | | | | | | | convert list_for_each() to list_for_each_entry() where applicable. Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: ks7010: remove unused including <linux/version.h>Wei Yongjun2016-10-251-1/+0
| | | | | | | Remove including <linux/version.h> that don't need it. Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: ks7010: Remove braces around single statement blocksSabitha George2016-10-171-15/+8
| | | | | | | | Fixes checkpatch warning: braces{} are not necessary for single statment blocks Signed-off-by: Sabitha George <sabitha.george@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: ks7010: Add blank line after declarationsSabitha George2016-10-171-0/+6
| | | | | | | | Fixes checkpatch.pl warning :Missing a blank line after declarations Signed-off-by: Sabitha George <sabitha.george@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: ks7010: Fixes warning :do not add new typedefsSabitha George2016-10-161-3/+3
| | | | | | | | Fixes checkpatch.pl warning: do not add new typedefs in ks_wlan_net.c Signed-off-by: Sabitha George <sabitha.george@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: ks7010: Replace __attribute__(aligned(x)) with __aligned(x)Sabitha George2016-10-161-1/+1
| | | | | | | | Fixes checkpatch.pl warning: __aligned(size) is preferred over __attribute__((aligned(size)) in ks7010_sdio.h Signed-off-by: Sabitha George <sabitha.george@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: ks7010: Fixes error "foo * bar should be foo *bar"Sabitha George2016-10-161-32/+32
| | | | | | | | Fixes checkpatch warning on ks_wlan_net.c: foo * bar should be foo *bar Signed-off-by: Sabitha George <sabitha.george@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: ks7010: Replace asm/uaccess.h and asm/atomic.hSabitha George2016-10-161-2/+2
| | | | | | | | Replaces inclusion of asm/uaccess.h with linux/uaccess.h and asm/atomic.h with linux/atomic.h in ks_wlan_net.c Signed-off-by: Sabitha George <sabitha.george@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: ks7010: use netdev_* instead of printk()Sabitha George2016-10-161-13/+9
| | | | | | | | | 1. Fixes checkpatch warning on printk usage in ks_hostif.c 2. Dropped "ks_wlan" prefix from the messages 3. Removed the "Memory squeeze,dropping packet" messages Signed-off-by: Sabitha George <sabitha.george@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: ks7010: fix space related style issues in ks7010_sdio.cAkshay Mariyanna2016-10-161-3/+3
| | | | | | | | | This fixes the following checkpatch warnings: WARNING: Unnecessary space before function pointer arguments WARNING: unnecessary whitespace before a quoted newline Signed-off-by: Akshay Mariyanna <akmlkcc@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: ks7010: fix indent style in ks7010_sdio.cAkshay Mariyanna2016-10-161-6/+6
| | | | | | | | This patch fixes the following checkpatch error: ERROR: code indent should use tabs where possible Signed-off-by: Akshay Mariyanna <akmlkcc@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: ks7010: Replace header filesSabitha George2016-10-161-2/+2
| | | | | | | | This patch replaces inclusion of asm/atomic.h with linux/atomic.h and asm/io.h with linux/io.h to fix checkpatch warning in ks_wlan.h Signed-off-by: Sabitha George <sabitha.george@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* Staging: ks7010: Delete unnecessary return statementMihaela Muraru2016-10-161-8/+0
| | | | | | | | | | | | This is a patch to ks_hostif.c file that fixes up a checkpatch.pl WARNING: void function return statements are not generally useful. The 'return' statement is not useful here, because it is not necessary to be forced the exit of the function. Signed-off-by: Mihaela Muraru <mihaela.muraru21@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* Staging: ks7010: __packed instedad of __attribute__((packed))Mihaela Muraru2016-10-161-4/+4
| | | | | | | | | | | Fix a issue found by checkpatch.pl tool: "WARNING: __packed is preferred over __attribute__((packed))". Replace __attribute__((packed)) with __packed. Signed-off-by: Mihaela Muraru <mihaela.muraru21@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: ks7010: remove unnecessary else statementEbru Akagunduz2016-10-161-2/+2
| | | | | | | | This patch removes else statement which is not usefull after a return. Issue found by checkpatch.pl. Signed-off-by: Ebru Akagunduz <ebru.akagunduz@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: ks7010: Use printk format specifier for MAC addressesPontus Fuchs2016-10-162-36/+9
| | | | | | | Convert to %pM instead of custom code. Signed-off-by: Pontus Fuchs <pontus.fuchs@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: ks7010: Remove unnecessary castPontus Fuchs2016-10-161-3/+2
| | | | | | | sdio functions takes unsigned int as address. No need to cast. Signed-off-by: Pontus Fuchs <pontus.fuchs@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* Staging: ks7010: fix brace coding style issueMuraru Mihaela2016-10-161-82/+73
| | | | | | | | This is a patch to the ks_wlan_net.c file that fixes up a brace coding style warning found by checkpatch.pl tool, by deleting the unnecessary braces for single statement blocks. Signed-off-by: Muraru Mihaela <mihaela.muraru21@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* Staging: ks7010: add blank line after declarationMuraru Mihaela2016-10-161-0/+4
| | | | | | | | | This patch fixes a coding style WARNING: Missing a blank line after declaration, found by checkpatch.pl. By adding a blank line after declaration of a variable. Signed-off-by: Muraru Mihaela <mihaela.muraru21@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: ks7010: fix checkpatch "space after #ifdef" errorPhilipp Hoefflin2016-10-161-1/+1
| | | | | | | | Fix checkpatch "ERROR: exactly one space required after that #ifdef" error in ks_hostif.c. Signed-off-by: Philipp Hoefflin <p.hoefflin@posteo.de> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: ks7010: reformat makro ps_confirm_wait_inc()Philipp Hoefflin2016-10-161-4/+5
| | | | | | | | | | | | | | | Reformat the makro ps_confirm_wait_inc() to fix several checkpatch errors and warnings: - ERROR: space required before the open brace '{' - ERROR: space required before the open parenthesis '(' - ERROR: code indent should use tabs where possible - ERROR: space required after that close brace '}' - ERROR: space required before the open parenthesis '(' - WARNING: line over 80 characters - WARNING: please, no spaces at the start of a line Signed-off-by: Philipp Hoefflin <p.hoefflin@posteo.de> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: ks7010: use tabs for indentationPhilipp Hoefflin2016-10-161-3/+3
| | | | | | | | Fix all occurences of checkpatch "ERROR: code indent should use tabs where possible" errors in ks_hostif.c. Signed-off-by: Philipp Hoefflin <p.hoefflin@posteo.de> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: ks7010: fix "prohibited space" errors reported by checkpatchPhilipp Hoefflin2016-10-161-4/+4
| | | | | | | | | | Fix all occurences of the following checkpatch errors in ks_hostif.c: - ERROR: space prohibited after that '&' (ctx:WxW) - ERROR: space prohibited after that open parenthesis '(' - ERROR: space prohibited before that close parenthesis ')' Signed-off-by: Philipp Hoefflin <p.hoefflin@posteo.de> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* Staging : ks7010 : Fix block comments warninigMuraru Mihaela2016-10-021-8/+16
| | | | | | | | | | Move final */ to a new line, to conform to the kernel coding style for block comments. Issue found by checkpatch. Signed-off-by: Muraru Mihaela <mihaela.muraru21@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: ks7010: declare private functions staticSergio Paracuellos2016-09-281-3/+3
| | | | | | | | | Private functions in ks7010_sdio.c can be declared static. Fixes sparse warnings 'was not declared. Should it be static?'. Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: ks7010: Use __packed over __attribute__((packed))Matt Kilgore2016-09-273-54/+59
| | | | | | | | | This replaces uses of __attribute__((packed)) with __packed, which is recommended to be used over the direct __attribute__. This patch then includes <linux/compiler.h> as necessary to use __packed. Signed-off-by: Matthew Kilgore <mattkilgore12@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: ks7010: Fix warnings on printk() usageSabitha George2016-09-271-7/+10
| | | | | | | | | | This patch fixes the following warnings on ks7010_sdio.c 1. printk() should include KERN_ facility level 2. Prefer [subsystem eg: netdev]_err([subsystem]dev, ... then dev_err(dev, ... then pr_err(... to printk(KERN_ERR ... Signed-off-by: Sabitha George <sabitha.george@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: ks7010: ks_wlan_net: Use netdev_info instead of printkGeorgiana Rodica Chelu2016-09-271-38/+38
| | | | | | | | Pass the net_device structure to print_hif_event function in order to use netdev_info instead of printk. Signed-off-by: Georgiana Rodica Chelu <georgiana.chelu93@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: ks7010: ks_wlan_net: Use netdev_ instead of printkGeorgiana Rodica Chelu2016-09-271-10/+10
| | | | | | | | | | | | | | | | | | | The checkpatch.pl script found the following warning: WARNING: printk() should include KERN_ facility level After adding the KERN_ facility level to printk(), the script showed another warning: WARNING: Prefer [subsystem eg: netdev]_info([subsystem]dev, ... then dev_info(dev, ... then pr_info(... to printk(KERN_INFO ... The warning is similar for KERN_ERR and KERN_DEBUG. In conclusion, use netdev_info(), netdev_err() or netdev_dbg() when there is a netdev device. Signed-off-by: Georgiana Rodica Chelu <georgiana.chelu93@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: ks7010: ks_wlan_net: Remove return statement from void functionGeorgiana Rodica Chelu2016-09-251-4/+0
| | | | | | | | | | Remove the return statement from the end of a void function to clean up the code. Issue found by checkpatch.pl script. Signed-off-by: Georgiana Rodica Chelu <georgiana.chelu93@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: ks7010: ks_wlan_net: Remove unnecessary variable used to store ↵Georgiana Rodica Chelu2016-09-251-2/+1
| | | | | | | | | | | | | return value Remove unneeded code in order to make clear that the function returns 0(success) in all cases. Done using returnvar.cocci script. Signed-off-by: Georgiana Rodica Chelu <georgiana.chelu93@gmail.com> Acked-by: Julia Lawall <julia.lawall@lip6.fr> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
OpenPOWER on IntegriCloud