summaryrefslogtreecommitdiffstats
path: root/drivers/staging/keucr
Commit message (Collapse)AuthorAgeFilesLines
* staging: Convert __FUNCTION__ to __func__Joe Perches2014-05-251-1/+1
| | | | | | | Use the normal mechanism for emitting a function name. Signed-off-by: Joe Perches <joe@perches.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: keucr: smilmain.c: cosmetic updatesTair Rzayev2014-05-232-21/+17
| | | | | | | | | * Move Check_D_MediaFmt() implementation up in smilmain.c to keep all the non-static functions at the top of the file; * Remove unnecessary extern and newlines from "init.h"; Signed-off-by: Tair Rzayev <tair.rzayev@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: keucr: fix sparse warningRui Miguel Silva2014-04-253-3/+2
| | | | | | | | | | | fix sparse warning: drivers/staging/keucr/smilmain.c:163:5: warning: symbol 'Check_D_MediaFmt' was not declared. Should it be static? by declaring it in the right header. And remove duplication of definition of SM_INIT Signed-off-by: Rui Miguel Silva <rmfrfs@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: keucr: Fix warning about missing blank lines after declarationsJonas Hahnfeld2014-04-252-0/+2
| | | | | | | | This patches fixes two warnings of checkpatch.pl, both of the type WARNING: Missing a blank line after declarations Signed-off-by: Jonas Hahnfeld <hahnjo@hahnjo.de> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging:keucr: Remove typedefsHimangi Saraogi2014-03-1612-297/+289
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | As suggested by Pablo, this patch uses a coccinelle script to remove the typedefs: typedef u8 BOOLEAN; <-- use "bool" instead. typedef u8 BYTE; <-- use "u8" typedef u8 *PBYTE; <-- use "u8 *" typedef u16 WORD; <-- use "u16" typedef u16 *PWORD; <-- use "u16 *" typedef u32 DWORD; <-- use "u32" typedef u32 *PDWORD; <-- use "u32 *" in common.h. The coccinelle script is: /* coccinelle script to remove typedefs. */ @remove_typedef@ @@ -typedef bool BOOLEAN; -typedef u8 BYTE; -typedef u8 *PBYTE; -typedef u16 WORD; -typedef u16 *PWORD; -typedef u32 DWORD; -typedef u32 *PDWORD; @fix_usage@ typedef BOOLEAN; @@ -BOOLEAN +bool @fix_usage1@ typedef BYTE; @@ -BYTE +u8 @fix_usage2@ typedef PBYTE; @@ -PBYTE +u8 * @fix_usage3@ typedef WORD; @@ -WORD +u16 @fix_usage4@ typedef PWORD; @@ -PWORD +u16 * @fix_usage5@ typedef DWORD; identifier f; @@ -DWORD +u32 @fix_usage6@ typedef PDWORD; @@ -PDWORD +u32 * Signed-off-by: Himangi Saraogi <himangi774@gmail.com> Signed-off-by: Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com>
* static: keucr: Fix sparse warning of static declarationsHimangi Saraogi2014-03-161-1/+1
| | | | | | | | | | This patch fixes the warning: drivers/staging/keucr/smilsub.c:603:6: warning: symbol '_Check_D_DevCode' was not declared. Should it be static? by making function static as it is used within the file. Signed-off-by: Himangi Saraogi <himangi774@gmail.com> Acked-by: Pablo Neira Ayuso <pablo@gnumonks.org> Signed-off-by: Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com>
* staging: keucr: Fix typo in keucr driverMasanari Iida2013-12-174-4/+4
| | | | | | | Correct spelling typo in comment and printk. Signed-off-by: Masanari Iida <standby24x7@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: delete non-required instances of include <linux/init.h>Paul Gortmaker2013-12-171-1/+0
| | | | | | | | | | None of these files are actually using any __init type directives and hence don't need to include <linux/init.h>. Most are just a left over from __devinit and __cpuinit removal, or simply due to code getting copied from one driver to the next. Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* Staging: keucr: Move the declaration of variable IsXDCompliance in smilsub.cRashika Kheria2013-11-113-5/+1
| | | | | | | | | | This patch moves the declaration of variable IsXDCompliance to file smilsub.c since this is the only file which uses it. Hence, it also removes extern declaration from the header file smil.h and unnecessary declaration in smilmain.c Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* Staging: keucr: Move the declaration of variable IsSSFDCCompliance in smilsub.cRashika Kheria2013-11-113-3/+1
| | | | | | | | | | This patch moves the declaration of variable IsSSFDCCompliance to file smilsub.c since this is the only file which uses it. Hence, it also removes extern declaration from the header file smil.h and unnecessary declaration in smilmain.c Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* Staging: keucr: Move the declaration of variable ErrCode in smilmain.cRashika Kheria2013-11-112-2/+1
| | | | | | | | | | This patch moves the declaration of variable ErrCode to file smilmain.c since this is the only file which uses it. Hence, it also removes extern declaration from the header file smil.h. Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com> Reviewed-by: Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* Staging: keucr: Move the declaration of variable ErrXDCode in smilsub.cRashika Kheria2013-11-113-2/+1
| | | | | | | | | | | This patch moves the declaration of variable ErrXDCode to file smilsub.c since this is the only file which uses it. Hence, it also removes extern declaration from the header file smil.h and unnecessary declaration in smilmain.c Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com> Reviewed-by: Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* Staging: keucr: Fix externs are avoided in smscsi.cRashika Kheria2013-11-101-16/+12
| | | | | | | | This patch fixes the following checkpatch.pl warning in smscsi.c- WARNING: externs should be avoided in .c files Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* Staging: keucr: Fix externs are avoided in smilsub.cRashika Kheria2013-11-101-33/+1
| | | | | | | | This patch fixes the following checkpatch.pl warning in smilsub.c- WARNING: externs should be avoided in .c files Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* Staging: keucr: Fix externs are avoided in smilmain.cRashika Kheria2013-11-101-55/+35
| | | | | | | | This patch fixes the following checkpatch.pl warning in smilmain.c- WARNING: externs should be avoided in .c files Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* Staging: keucr: fix quoted string split across linesEbru Akagunduz2013-10-061-3/+1
| | | | | | | | Fix checkpatch.pl issues quoted string split across lines in usb.c Signed-off-by: Ebru Akagunduz <ebru.akagunduz@gmail.com> Reviewed-by: Josh Triplett <josh@joshtriplett.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: keucr: be explicit to the sysfs file permissionsGreg Kroah-Hartman2013-08-241-10/+3
| | | | | | | | Use the DEVICE_ATTR_RW() macro to be clearer as to the permissions for the sysfs file, making it easier to audit the code. Cc: Al Cho <acho@novell.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: keucr: removed unnecessary variables and commentsLaura Lawniczak2013-06-171-14/+0
| | | | | | | | | | blen and bn were only used in commented code fragments. since comments should be informative and not for storing old code, both, commented code and variables, were removed. Signed-off-by: Laura Lawniczak <laura.lawniczak@googlemail.com> Signed-off-by: Johannes Schilling <of82ecuq@cip.cs.fau.de> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* keucr: fix some alignment- and whitespace-problemsJohannes Schilling2013-06-066-98/+106
| | | | | | | | | resolves checkpatch errors and warnings regarding whitespace around operators, line lengths and indentation. Signed-off-by: Laura Lawniczak <laura.lawniczak@googlemail.com> Signed-off-by: Johannes Schilling <of82ecuq@cip.cs.fau.de> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* keucr: moved function to other fileLaura Lawniczak2013-06-063-52/+50
| | | | | | | | | Function usb_stor_print_cmd was declared in init.c but only used in transport.c. So it was reasonable to move it there and declare it static Signed-off-by: Laura Lawniczak <laura.lawniczak@googlemail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* keucr: more readable and friendly error messagesLaura Lawniczak2013-06-062-11/+23
| | | | | | Signed-off-by: Laura Lawniczak <laura.lawniczak@googlemail.com> Signed-off-by: Johannes Schilling <of82ecuq@cip.cs.fau.de> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* keucr: migrate printk to dev_dbg/info/warn/errLaura Lawniczak2013-06-066-50/+48
| | | | | | | | | | | as per suggestion of checkpatch.pl; this resolves warnings like "Prefer netdev_info .. then dev_info .. to printk". Changed signature of function usb_stor_print_cmd in init.c to enable usage of dev_err Signed-off-by: Laura Lawniczak <laura.lawniczak@googlemail.com> Signed-off-by: Johannes Schilling <of82ecuq@cip.cs.fau.de> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* keucr: use more specific max_t(int, ..Johannes Schilling2013-06-061-2/+2
| | | | | | | | as advised by checkpatch, changed generic max(..) to max_t(int, .. Signed-off-by: Laura Lawniczak <laura.lawniczak@googlemail.com> Signed-off-by: Johannes Schilling <of82ecuq@cip.cs.fau.de> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* keucr: remove some unneccesary typedefsJohannes Schilling2013-06-065-37/+21
| | | | | | | | | resolves checkpatch.pl warning "do not add new typedefs" and renames allcaps structures. Signed-off-by: Laura Lawniczak <laura.lawniczak@googlemail.com> Signed-off-by: Johannes Schilling <of82ecuq@cip.cs.fau.de> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: keucr: remove needless check before usb_free_coherent()Wei Yongjun2013-05-301-6/+3
| | | | | | | | usb_free_coherent() is safe with NULL addr and this check is not required. Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* keucr: fixes line over 80 characters warningAmarjargal Gundjalam2013-05-195-50/+99
| | | | | | | | This patch fixes the following checkpatch warning, WARNING: line over 80 characters Signed-off-by: Amarjargal Gundjalam <amarjargal16@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* keucr: fixes trailing whitespace errorAmarjargal Gundjalam2013-05-192-4/+4
| | | | | | | | This patch fixes the following checkpatch error, ERROR: trailing whitespace Signed-off-by: Amarjargal Gundjalam <amarjargal16@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* keucr: fixes no spaces at the start of a line warningAmarjargal Gundjalam2013-05-194-34/+34
| | | | | | | | This patch fixes the following checkpatch warning, WARNING: please, no spaces at the start of a line Signed-off-by: Amarjargal Gundjalam <amarjargal16@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* keucr: fixes do not use C99 // comments errorAmarjargal Gundjalam2013-05-192-48/+50
| | | | | | | | This patch fixes the following checkpatch error, ERROR: do not use C99 // comments Signed-off-by: Amarjargal Gundjalam <amarjargal16@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* keucr: removes unused code from smilmain.cAmarjargal Gundjalam2013-05-191-1063/+3
| | | | | Signed-off-by: Amarjargal Gundjalam <amarjargal16@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* keucr: fixes space prohibited before warningAmarjargal Gundjalam2013-05-192-2/+2
| | | | | | | | | This patch fixes the following checkpatch error and warning, ERROR: space prohibited before open square bracket '[' WARNING: space prohibited before semicolon Signed-off-by: Amarjargal Gundjalam <amarjargal16@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* keucr: fixed space prohibited between warningAmarjargal Gundjalam2013-05-192-41/+41
| | | | | | | | This patch fixes the following checkpatch warning, WARNING: space prohibited between function name and open parenthesis '(' Signed-off-by: Amarjargal Gundjalam <amarjargal16@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* keurc: fixes spaces required around errorAmarjargal Gundjalam2013-05-191-134/+138
| | | | | | | | This patch fixes the following checkpatch error, ERROR: spaces required around that ' ' Signed-off-by: Amarjargal Gundjalam <amarjargal16@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* keucr: fixes space required before open parenthesis errorAmarjargal Gundjalam2013-05-191-14/+14
| | | | | | | | This patch fixes the following checkpatch error, ERROR: space required before the open parenthesis '(' Signed-off-by: Amarjargal Gundjalam <amarjargal16@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* keucr: fixes space required after errorAmarjargal Gundjalam2013-05-192-28/+28
| | | | | | | | This patch fixes the following checkpatch error, ERROR: space required after that ' ' Signed-off-by: Amarjargal Gundjalam <amarjargal16@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* keucr: fixes open brace go on the next line errorAmarjargal Gundjalam2013-05-191-2/+4
| | | | | | | | | This patch fixes the following checkpatch error, ERROR: open brace '{' following function declarations go on the next line Signed-off-by: Amarjargal Gundjalam <amarjargal16@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* keucr: fixes else should follow close brace errorAmarjargal Gundjalam2013-05-191-8/+4
| | | | | | | | This patch fixes the following checkpatch error, ERROR: else should follow close brace '}' Signed-off-by: Amarjargal Gundjalam <amarjargal16@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* keucr: fixes open brace should be on the previous line errorAmarjargal Gundjalam2013-05-191-156/+140
| | | | | | | | This patch fixes the following checkpatch error, ERROR: that open brace { should be on the previous line Signed-off-by: Amarjargal Gundjalam <amarjargal16@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* keucr: Fixes return is not a function error in smilmain.cAmarjargal Gundjalam2013-05-191-216/+216
| | | | | | | | Fixes the following checkpatch error, ERROR: return is not a function, parentheses are not required Signed-off-by: Amarjargal Gundjalam <amarjargal16@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* Staging: keucr: fixed CamelCase warningKatrina Prosise2013-05-133-5/+5
| | | | | | | This patch fixes the checkpatch warning of CamelCase ENE_Read_BYTE Signed-off-by: Katrina Prosise <katrina.prosise@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* keucr: switch to ->show_info()Al Viro2013-04-091-32/+13
| | | | Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
* staging: Remove unnecessary OOM messagesJoe Perches2013-02-111-3/+2
| | | | | | | | | | | | | | | | | alloc failures already get standardized OOM messages and a dump_stack. For the affected mallocs around these OOM messages: Converted kzallocs with multiplies to kcalloc. Converted kmallocs with multiplies to kmalloc_array. Converted a kmalloc/strlen/strncpy to kstrdup. Moved a spin_lock below a removed OOM message and removed a now unnecessary spin_unlock. Neatened alignment and whitespace. Signed-off-by: Joe Perches <joe@perches.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: keucr: Fix parens/bracesKurt Kanzenbach2013-01-071-73/+37
| | | | | | | | | Fixed a coding style issue. Fixed positions of braces regarding to linux coding style. Signed-off-by: Kurt Kanzenbach <shifty91@gmail.com> Acked-by: Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: keucr: Removed trailing whitespacesKurt Kanzenbach2013-01-071-2/+2
| | | | | | | | | Fixed a coding style issue. Removed trailing whitespaces in code. Signed-off-by: Kurt Kanzenbach <shifty91@gmail.com> Acked-by: Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: keucr: Replaced c99 commentsKurt Kanzenbach2013-01-071-52/+21
| | | | | | | | | | Fixed a coding style issue. Replaced all c99 comments by c89 ones and deleted commented out code. Signed-off-by: Kurt Kanzenbach <shifty91@gmail.com> Acked-by: Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* Merge tag 'usb-3.6' of git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usbLinus Torvalds2012-10-011-1/+1
|\ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Pull USB changes from Greg Kroah-Hartman: "Here is the big USB pull request for 3.7-rc1 There are lots of gadget driver changes (including copying a bunch of files into the drivers/staging/ccg/ directory so that the other gadget drivers can be fixed up properly without breaking that driver), and we remove the old obsolete ub.c driver from the tree. There are also the usual XHCI set of updates, and other various driver changes and updates. We also are trying hard to remove the old dbg() macro, but the final bits of that removal will be coming in through the networking tree before we can delete it for good. All of these patches have been in the linux-next tree. Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>" Fix up several annoying - but fairly mindless - conflicts due to the termios structure having moved into the tty device, and often clashing with dbg -> dev_dbg conversion. * tag 'usb-3.6' of git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb: (339 commits) USB: ezusb: move ezusb.c from drivers/usb/serial to drivers/usb/misc USB: uas: fix gcc warning USB: uas: fix locking USB: Fix race condition when removing host controllers USB: uas: add locking USB: uas: fix abort USB: uas: remove aborted field, replace with status bit. USB: uas: fix task management USB: uas: keep track of command urbs xhci: Intel Panther Point BEI quirk. powerpc/usb: remove checking PHY_CLK_VALID for UTMI PHY USB: ftdi_sio: add TIAO USB Multi-Protocol Adapter (TUMPA) support Revert "usb : Add sysfs files to control port power." USB: serial: remove vizzini driver usb: host: xhci: Fix Null pointer dereferencing with 71c731a for non-x86 systems Increase XHCI suspend timeout to 16ms USB: ohci-at91: fix null pointer in ohci_hcd_at91_overcurrent_irq USB: sierra_ms: don't keep unused variable fsl/usb: Add support for USB controller version 2.4 USB: qcaux: add Pantech vendor class match ...
| * usb: remove libusualSebastian Andrzej Siewior2012-09-051-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | The "Low Performance USB Block driver" has been removed which a user of libusual. Now we have only the usb-storage driver as the only driver in tree. This makes libusual needless. This patch removes libusal, fixes up all users. The usual-table is now linked into usb-storage. usb_usual.h remains in public include directory because some staging users seem to need it. Signed-off-by: Sebastian Andrzej Siewior <sebastian@breakpoint.cc> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* | staging: keucr: remove String func prototypesDavidlohr Bueso2012-09-131-2/+0
|/ | | | | | | | Commit 1b9f644dfeb638e0146ce54f4e48c87a2841a603 already got rid of StringCopy and StringCmp, so remove the left over prototypes. Signed-off-by: Davidlohr Bueso <dave@gnu.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* Staging: keucr: scsiglue: fixed a do while coding style issueWilliam Blair2012-06-131-3/+8
| | | | | | | Added a do ... while (0) to a multi statement macro and reformatted a similar macro. Signed-off-by: William Blair <wdblair@bu.edu> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* Staging: keucr: init: fixed a brace coding style issueWilliam Blair2012-06-121-2/+1
| | | | | | | Fixed a coding style issue. Signed-off-by: William Blair <wdblair@bu.edu> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
OpenPOWER on IntegriCloud