summaryrefslogtreecommitdiffstats
path: root/drivers/staging/hv
Commit message (Collapse)AuthorAgeFilesLines
* staging: hv: Fixed lockup problem with bounce_buffer scatter listHank Janssen2010-09-031-2/+5
| | | | | | | | | | | | | | | | Fixed lockup problem with bounce_buffer scatter list which caused crashes in heavy loads. And minor code indentation cleanup in effected area. Removed whitespace and noted minor indentation changes in description as pointed out by Joe Perches. (Thanks for reviewing Joe) Signed-off-by: Hank Janssen <hjanssen@microsoft.com> Signed-off-by: Haiyang Zhang <haiyangz@microsoft.com> Cc: stable <stable@kernel.org> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
* staging: hv: Increased storvsc ringbuffer and max_io_requestsHank Janssen2010-09-031-2/+2
| | | | | | | | | | | | | | | | | | | | | | Increased storvsc ringbuffer and max_io_requests. This now more closely mimics the numbers on Hyper-V. And will allow more IO requests to take place for the SCSI driver. Max_IO is set to double from what it was before, Hyper-V allows it and we have had appliance builder requests to see if it was a problem to increase the number. Ringbuffer size for storvsc is now increased because I have seen A few buffer problems on extremely busy systems. They were Set pretty low before. And since max_io_requests is increased I Really needed to increase the buffer as well. Signed-off-by:Hank Janssen <hjanssen@microsoft.com> Signed-off-by:Haiyang Zhang <haiyangz@microsoft.com> Cc: stable <stable@kernel.org> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
* staging: hv: Fixed the value of the 64bit-hole inside ring bufferHaiyang Zhang2010-09-031-2/+1
| | | | | | | | | | | | | | | | | | | | Fixed the value of the 64bit-hole inside ring buffer, this caused a problem on Hyper-V when running checked Windows builds. Checked builds of Windows are used internally and given to external system integrators at times. They are builds that for example that all elements in a structure follow the definition of that Structure. The bug this fixed was for a field that we did not fill in at all (Because we do Not use it on the Linux side), and the checked build of windows gives errors on it internally to the Windows logs. This fixes that error. Signed-off-by:Hank Janssen <hjanssen@microsoft.com> Signed-off-by:Haiyang Zhang <haiyangz@microsoft.com> Cc: stable <stable@kernel.org> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
* staging: hv: Fixed bounce kmap problem by using correct indexHank Janssen2010-09-031-2/+2
| | | | | | | | | | | | | Fixed bounce offset kmap problem by using correct index. The symptom of the problem is that in some NAS appliances this problem represents Itself by a unresponsive VM under a load with many clients writing small files. Signed-off-by:Hank Janssen <hjanssen@microsoft.com> Signed-off-by:Haiyang Zhang <haiyangz@microsoft.com> Cc: stable <stable@kernel.org> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
* staging: hv: Fix missing functions for net_device_opsHaiyang Zhang2010-09-031-0/+3
| | | | | | | | | | | | | | | | | | | Fix missing functions for net_device_ops. It's a bug when porting the drivers from 2.6.27 to 2.6.32. In 2.6.27, the default functions for Ethernet, like eth_change_mtu(), were assigned by ether_setup(). But in 2.6.32, these function pointers moved to net_device_ops structure and no longer be assigned in ether_setup(). So we need to set these functions in our driver code. It will ensure the MTU won't be set beyond 1500. Otherwise, this can cause an error on the server side, because the HyperV linux driver doesn't support jumbo frame yet. Signed-off-by: Haiyang Zhang <haiyangz@microsoft.com> Signed-off-by: Hank Janssen <hjanssen@microsoft.com> Cc: stable <stable@kernel.org> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
* Merge branch 'for-2.6.36' of git://git.kernel.dk/linux-2.6-blockLinus Torvalds2010-08-101-3/+10
|\ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * 'for-2.6.36' of git://git.kernel.dk/linux-2.6-block: (149 commits) block: make sure that REQ_* types are seen even with CONFIG_BLOCK=n xen-blkfront: fix missing out label blkdev: fix blkdev_issue_zeroout return value block: update request stacking methods to support discards block: fix missing export of blk_types.h writeback: fix bad _bh spinlock nesting drbd: revert "delay probes", feature is being re-implemented differently drbd: Initialize all members of sync_conf to their defaults [Bugz 315] drbd: Disable delay probes for the upcomming release writeback: cleanup bdi_register writeback: add new tracepoints writeback: remove unnecessary init_timer call writeback: optimize periodic bdi thread wakeups writeback: prevent unnecessary bdi threads wakeups writeback: move bdi threads exiting logic to the forker thread writeback: restructure bdi forker loop a little writeback: move last_active to bdi writeback: do not remove bdi from bdi_list writeback: simplify bdi code a little writeback: do not lose wake-ups in bdi threads ... Fixed up pretty trivial conflicts in drivers/block/virtio_blk.c and drivers/scsi/scsi_error.c as per Jens.
| * block: push down BKL into .open and .releaseArnd Bergmann2010-08-071-0/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The open and release block_device_operations are currently called with the BKL held. In order to change that, we must first make sure that all drivers that currently rely on this have no regressions. This blindly pushes the BKL into all .open and .release operations for all block drivers to prepare for the next step. The drivers can subsequently replace the BKL with their own locks or remove it completely when it can be shown that it is not needed. The functions blkdev_get and blkdev_put are the only remaining users of the big kernel lock in the block layer, besides a few uses in the ioctl code, none of which need to serialize with blkdev_{get,put}. Most of these two functions is also under the protection of bdev->bd_mutex, including the actual calls to ->open and ->release, and the common code does not access any global data structures that need the BKL. Signed-off-by: Arnd Bergmann <arnd@arndb.de> Acked-by: Christoph Hellwig <hch@infradead.org> Signed-off-by: Jens Axboe <jaxboe@fusionio.com>
| * block: remove wrappers for request type/flagsChristoph Hellwig2010-08-071-3/+5
| | | | | | | | | | | | | | | | | | Remove all the trivial wrappers for the cmd_type and cmd_flags fields in struct requests. This allows much easier grepping for different request types instead of unwinding through macros. Signed-off-by: Christoph Hellwig <hch@lst.de> Signed-off-by: Jens Axboe <jaxboe@fusionio.com>
* | Staging: Merge staging-next into Linus's treeGreg Kroah-Hartman2010-08-0521-665/+174
|\ \ | |/ |/| | | | | | | | | | | | | | | | | Conflicts: drivers/staging/Kconfig drivers/staging/batman-adv/bat_sysfs.c drivers/staging/batman-adv/device.c drivers/staging/batman-adv/hard-interface.c drivers/staging/cx25821/cx25821-audups11.c Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
| * Staging: hv: remove RING_BUFFER typedefGreg Kroah-Hartman2010-07-272-6/+6
| | | | | | | | | | | | | | | | typedefs are bad, kill them. Cc: Hank Janssen <hjanssen@microsoft.com> Cc: Haiyang Zhang <haiyangz@microsoft.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
| * Staging: hv: remove RING_BUFFER_INFO typedefGreg Kroah-Hartman2010-07-273-35/+37
| | | | | | | | | | | | | | | | typedefs are bad, kill them. Cc: Hank Janssen <hjanssen@microsoft.com> Cc: Haiyang Zhang <haiyangz@microsoft.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
| * Staging: hv: remove RING_BUFFER_DEBUG_INFO typedefGreg Kroah-Hartman2010-07-273-11/+11
| | | | | | | | | | | | | | | | typedefs are bad, kill them. Cc: Hank Janssen <hjanssen@microsoft.com> Cc: Haiyang Zhang <haiyangz@microsoft.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
| * staging: hv: Fix Kconfig dependency of hv_blkvscHaiyang Zhang2010-07-261-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | LBDAF is not available nor necessary on 64BIT kernel. This patch fixed the dependency for hv_blkvsc module on 64BIT kernel. Thanks vrataj2 [vrataj2@comcast.net] for reporting this problem. Reported-by: vrataj2 <vrataj2@comcast.net> Signed-off-by: Haiyang Zhang <haiyangz@microsoft.com> Signed-off-by: Hank Janssen <hjanssen@microsoft.com> Cc: stable <stable@kernel.org> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
| * Staging: hv: remove DPRINT_EXIT macroGreg Kroah-Hartman2010-07-2216-348/+14
| | | | | | | | | | | | | | | | | | No need for it, use the built-in kernel function tracing instead if you really need something like this. Cc: Hank Janssen <hjanssen@microsoft.com> Cc: Haiyang Zhang <haiyangz@microsoft.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
| * Staging: hv: remove DPRINT_ENTER macroGreg Kroah-Hartman2010-07-2216-262/+0
| | | | | | | | | | | | | | | | | | We have ftrace to look at function traces if its really needed. Don't roll custom macros for this. Cc: Hank Janssen <hjanssen@microsoft.com> Cc: Haiyang Zhang <haiyangz@microsoft.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
| * staging: hv: check kzalloc() resultKulikov Vasiliy2010-07-221-0/+2
| | | | | | | | | | | | | | If kzalloc() fails free allocated resources and exit. Signed-off-by: Kulikov Vasiliy <segooon@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
| * Staging: hyperv: add clocksource driverKy Srinivasan2010-07-082-1/+102
| | | | | | | | | | | | | | | | | | | | | | | | This patch is a clocksource implementation suitable for guests hosted on HyperV. Time keeping in Linux guests hosted on HyperV is unstable. This clocksource driver fixes the problem. This driver uses the hyperv detection code integrated into the kernel. Signed-off-by: K. Y. Srinivasan <ksrinivasan@novell.com> Cc: Hank Janssen <hjanssen@microsoft.com> Cc: Haiyang Zhang <haiyangz@microsoft.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
| * Staging: hv: Storage class should be before const qualifierTobias Klauser2010-06-181-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | The C99 specification states in section 6.11.5: The placement of a storage-class specifier other than at the beginning of the declaration specifiers in a declaration is an obsolescent feature. Signed-off-by: Tobias Klauser <tklauser@distanz.ch> Cc: Haiyang Zhang <haiyangz@microsoft.com> Cc: Hank Janssen <hjanssen@microsoft.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
* | Staging: hv: fix hv_utils module to properly autoloadHaiyang Zhang2010-06-301-0/+28
| | | | | | | | | | | | | | | | | | | | Added autoloading based on pci id and dmi strings. Signed-off-by: Haiyang Zhang <haiyangz@microsoft.com> Signed-off-by: Hank Janssen <hjanssen@microsoft.com> Cc: stable <stable@kernel.org> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
* | staging: hv: Fix race condition on vmbus channel initializationHaiyang Zhang2010-06-303-11/+35
|/ | | | | | | | | | | | | There is a possible race condition when hv_utils starts to load immediately after hv_vmbus is loading - null pointer error could happen. This patch added wait/completion to ensure all channels are ready before vmbus loading completes. So another module won't have any uninitialized channel. Signed-off-by: Haiyang Zhang <haiyangz@microsoft.com> Signed-off-by: Hank Janssen <hjanssen@microsoft.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
* Merge staging-next tree into Linus's latest versionGreg Kroah-Hartman2010-05-2139-475/+1301
|\ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Conflicts: drivers/staging/arlan/arlan-main.c drivers/staging/comedi/drivers/cb_das16_cs.c drivers/staging/cx25821/cx25821-alsa.c drivers/staging/dt3155/dt3155_drv.c drivers/staging/hv/hv.c drivers/staging/netwave/netwave_cs.c drivers/staging/wavelan/wavelan.c drivers/staging/wavelan/wavelan_cs.c drivers/staging/wlags49_h2/wl_cs.c This required a bit of hand merging due to the conflicts that happened in the later .34-rc releases, as well as some staging driver changing coming in through other trees (v4l and pcmcia). Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
| * staging: hv: Added heartbeat functionality to hv_utilsHank Janssen2010-05-174-3/+92
| | | | | | | | | | | | | | | | Add heartbeat functionality to hv_utils/Hyper-V Signed-off-by: Haiyang Zhang <haiyangz@microsoft.com> Signed-off-by: Hank Janssen <hjanssen@microsoft.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
| * Staging: Use kmemdupJulia Lawall2010-05-171-2/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Use kmemdup when some other buffer is immediately copied into the allocated region. A simplified version of the semantic patch that makes this change is as follows: (http://coccinelle.lip6.fr/) // <smpl> @@ expression from,to,size,flag; statement S; @@ - to = \(kmalloc\|kzalloc\)(size,flag); + to = kmemdup(from,size,flag); if (to==NULL || ...) S - memcpy(to, from, size); // </smpl> Signed-off-by: Julia Lawall <julia@diku.dk> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
| * staging: hv: Fix error checking in channel.cHaiyang Zhang2010-05-141-4/+4
| | | | | | | | | | | | | | | | | | | | Fixed errors in return value checking code, which caused vmbus channel not functioning. Signed-off-by: Haiyang Zhang <haiyangz@microsoft.com> Signed-off-by: Hank Janssen <hjanssen@microsoft.com> Cc: Bill Pemberton <wfp5p@virginia.edu> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
| * Staging: hv: auto-load MSFT PV NIC driverK. Y. Srinivasan2010-05-141-0/+26
| | | | | | | | | | | | | | Signed-off-by: K. Y. Srinivasan <ksrinivasan@novell.com> Cc: Hank Janssen <hjanssen@microsoft.com> Cc: Haiyang Zhang <haiyangz@microsoft.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
| * staging: hv: Optimize adj_guesttime function and add more detailed commentsHaiyang Zhang2010-05-111-10/+23
| | | | | | | | | | | | | | | | | | Credits go to Joe Perches <joe@perches.com> for suggesting the changes. Cc: Joe Perches <joe@perches.com> Signed-off-by: Hank Janssen <hjanssen@microsoft.com> Signed-off-by: Haiyang Zhang <haiyangz@microsoft.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
| * Staging: hv: storvsc module descriptionsStephen Hemminger2010-05-111-1/+3
| | | | | | | | | | | | | | Signed-off-by: Stephen Hemminger <shemminger@vyatta.com> Cc: Hank Janssen <hjanssen@microsoft.com> Cc: Haiyang Zhang <haiyangz@microsoft.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
| * Staging: hv: block_operations can be constStephen Hemminger2010-05-111-1/+1
| | | | | | | | | | | | | | Signed-off-by: Stephen Hemminger <shemminger@vyatta.com> Cc: Hank Janssen <hjanssen@microsoft.com> Cc: Haiyang Zhang <haiyangz@microsoft.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
| * Staging: hv: add module description to blkvscStephen Hemminger2010-05-111-2/+3
| | | | | | | | | | | | | | Signed-off-by: Stephen Hemminger <shemminger@vyatta.com> Cc: Hank Janssen <hjanssen@microsoft.com> Cc: Haiyang Zhang <haiyangz@microsoft.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
| * Staging: hv: rename VersionInfo.h to version_info.hGreg Kroah-Hartman2010-05-117-6/+6
| | | | | | | | | | | | | | | | The great renaming of the hv code is now complete. Cc: Hank Janssen <hjanssen@microsoft.com> Cc: Haiyang Zhang <haiyangz@microsoft.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
| * Staging: hv: rename VmbusPacketFormat.h to vmbus_packet_format.hGreg Kroah-Hartman2010-05-115-4/+4
| | | | | | | | | | | | Cc: Hank Janssen <hjanssen@microsoft.com> Cc: Haiyang Zhang <haiyangz@microsoft.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
| * Staging: hv: rename VmbusChannelInterface.h to vmbus_channel_interface.hGreg Kroah-Hartman2010-05-114-3/+3
| | | | | | | | | | | | Cc: Hank Janssen <hjanssen@microsoft.com> Cc: Haiyang Zhang <haiyangz@microsoft.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
| * Staging: hv: rename VmbusPrivate.h to vmbus_private.hGreg Kroah-Hartman2010-05-118-7/+7
| | | | | | | | | | | | Cc: Hank Janssen <hjanssen@microsoft.com> Cc: Haiyang Zhang <haiyangz@microsoft.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
| * Staging: hv: rename VmbusApi.h to vmbus_api.hGreg Kroah-Hartman2010-05-117-6/+6
| | | | | | | | | | | | Cc: Hank Janssen <hjanssen@microsoft.com> Cc: Haiyang Zhang <haiyangz@microsoft.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
| * Staging: hv: rename StorVscApi.h to storvsc_api.hGreg Kroah-Hartman2010-05-114-3/+3
| | | | | | | | | | | | Cc: Hank Janssen <hjanssen@microsoft.com> Cc: Haiyang Zhang <haiyangz@microsoft.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
| * Staging: hv: rename NetVscApi.h to netvsc_api.hGreg Kroah-Hartman2010-05-114-3/+3
| | | | | | | | | | | | Cc: Hank Janssen <hjanssen@microsoft.com> Cc: Haiyang Zhang <haiyangz@microsoft.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
| * Staging: hv: rename ChannelInterface.c and .h to channel_interface.c and .hGreg Kroah-Hartman2010-05-114-2/+2
| | | | | | | | | | | | | | | | All of the uppercase .c files are now gone. Cc: Hank Janssen <hjanssen@microsoft.com> Cc: Haiyang Zhang <haiyangz@microsoft.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
| * Staging: hv: rename ChannelMgmt.c and .h to channel_mgmt.c and .hGreg Kroah-Hartman2010-05-115-3/+3
| | | | | | | | | | | | Cc: Hank Janssen <hjanssen@microsoft.com> Cc: Haiyang Zhang <haiyangz@microsoft.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
| * Staging: hv: rename RndisFilter.c and .h to rndis_filter.c and .hGreg Kroah-Hartman2010-05-114-3/+3
| | | | | | | | | | | | Cc: Hank Janssen <hjanssen@microsoft.com> Cc: Haiyang Zhang <haiyangz@microsoft.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
| * Staging: hv: rename StorVsc.c to storvsc.cGreg Kroah-Hartman2010-05-113-2/+2
| | | | | | | | | | | | Cc: Hank Janssen <hjanssen@microsoft.com> Cc: Haiyang Zhang <haiyangz@microsoft.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
| * Staging: hv: rename NetVsc.c and .h to netvsc.c and .hGreg Kroah-Hartman2010-05-114-3/+3
| | | | | | | | | | | | Cc: Hank Janssen <hjanssen@microsoft.com> Cc: Haiyang Zhang <haiyangz@microsoft.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
| * Staging: hv: rename Vmbus.c to vmbus.cGreg Kroah-Hartman2010-05-112-1/+1
| | | | | | | | | | | | Cc: Hank Janssen <hjanssen@microsoft.com> Cc: Haiyang Zhang <haiyangz@microsoft.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
| * Staging: hv: rename BlkVsc.c to blkvsc.cGreg Kroah-Hartman2010-05-112-1/+1
| | | | | | | | | | | | Cc: Hank Janssen <hjanssen@microsoft.com> Cc: Haiyang Zhang <haiyangz@microsoft.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
| * Staging: hv: rename RingBuffer.c and .h to ring_buffer.c and .hGreg Kroah-Hartman2010-05-115-4/+4
| | | | | | | | | | | | Cc: Hank Janssen <hjanssen@microsoft.com> Cc: Haiyang Zhang <haiyangz@microsoft.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
| * Staging: hv: rename Connection.c to connection.cGreg Kroah-Hartman2010-05-112-1/+1
| | | | | | | | | | | | Cc: Hank Janssen <hjanssen@microsoft.com> Cc: Haiyang Zhang <haiyangz@microsoft.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
| * Staging: hv: rename Channel.c and .h to channel.c and .hGreg Kroah-Hartman2010-05-115-3/+3
| | | | | | | | | | | | Cc: Hank Janssen <hjanssen@microsoft.com> Cc: Haiyang Zhang <haiyangz@microsoft.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
| * Staging: hv: rename Hv.h to hv.hGreg Kroah-Hartman2010-05-112-1/+1
| | | | | | | | | | | | Cc: Hank Janssen <hjanssen@microsoft.com> Cc: Haiyang Zhang <haiyangz@microsoft.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
| * Staging: hv: rename Hv.c to hv.cGreg Kroah-Hartman2010-05-112-1/+1
| | | | | | | | | | | | | | | | No CamelCase in file names. Cc: Hank Janssen <hjanssen@microsoft.com> Cc: Haiyang Zhang <haiyangz@microsoft.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
| * Staging: hv: rename hyperv_utils.c to hv_utils.cGreg Kroah-Hartman2010-05-112-1/+0
| | | | | | | | | | | | | | | | | | As the module only has one .c file in it, just name the file the same as the desired module. Cc: Hank Janssen <hjanssen@microsoft.com> Cc: Haiyang Zhang <haiyangz@microsoft.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
| * Staging: hv: util.h: fix up space mess againGreg Kroah-Hartman2010-05-111-11/+11
| | | | | | | | | | | | | | | | Again, use tabs, not spaces, it's not difficult to remember... Cc: Hank Janssen <hjanssen@microsoft.com> Cc: Haiyang Zhang <haiyangz@microsoft.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
OpenPOWER on IntegriCloud