summaryrefslogtreecommitdiffstats
path: root/drivers/staging/gs_fpgaboot
Commit message (Collapse)AuthorAgeFilesLines
* Staging: gs_fpgaboot: remove FSF's mailing address from io.hShubham Kumaram2018-01-081-5/+0
| | | | | | | | This patch removes FSF's mailing address issue from io.h found by checkpatch.pl tool. Signed-off-by: Shubham Kumaram <shubhamkumaram@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: gs_fpgaboot: pr_err() strings should end with newlinesArvind Yadav2017-10-031-1/+1
| | | | | | | | pr_err() messages should end with a new-line to avoid other messages being concatenated. Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: gs_fpgaboot: return valid error codesJacob von Chorus2017-07-281-7/+7
| | | | | | | | The return values on error are modified to be valid error codes. Theses error codes are propagated back to the init function's return. Signed-off-by: Jacob von Chorus <jacobvonchorus@cwphoto.ca> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: gs_fpgaboot: change char to u8Jacob von Chorus2017-07-282-13/+13
| | | | | | | | | | The bitstream storage variables were changed from char to u8 arrays to prevent issues such as negative lengths. This change makes the code compatible with the "data" field in "struct firmware" which is of type u8. Signed-off-by: Jacob von Chorus <jacobvonchorus@cwphoto.ca> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: gs_fpgaboot: add buffer overflow checksJacob von Chorus2017-07-281-14/+40
| | | | | | | | | | | | | | | Four fields in struct fpgaimage are char arrays of length MAX_STR (256). The amount of data read into these buffers is controlled by a length field in the bitstream file read from userspace. If a corrupt or malicious firmware file was supplied, kernel data beyond these buffers can be overwritten arbitrarily. This patch adds a check of the bitstream's length value to ensure it fits within the bounds of the allocated buffers. An error condition is returned from gs_read_bitstream if any of the reads fail. Signed-off-by: Jacob von Chorus <jacobvonchorus@cwphoto.ca> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: gs_fpgaboot: remove FSF address from GPL noticeJacob von Chorus2017-07-181-4/+0
| | | | | | | | This patch removes the FSF address from the GPL notice to fix a checkpatch.cl CHECK message. Signed-off-by: Jacob von Chorus <jacobvonchorus@cwphoto.ca> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* scripts/spelling.txt: add "followings" pattern and fix typo instancesMasahiro Yamada2017-02-271-1/+1
| | | | | | | | | | | | | | | | | | Fix typos and add the following to the scripts/spelling.txt: followings||following While we are here, add a missing colon in the boilerplate in DT binding documents. The "you SoC" in allwinner,sunxi-pinctrl.txt was fixed as well. I reworded "as the followings:" to "as follows:" for drivers/usb/gadget/udc/renesas_usb3.c. Link: http://lkml.kernel.org/r/1481573103-11329-32-git-send-email-yamada.masahiro@socionext.com Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
* Staging: gs_fpgaboot: Use octal permissions '0444'Shyam Saini2016-10-251-1/+1
| | | | | | | | | Fixed following checkpatch warning WARNING: Symbolic permissions 'S_IRUGO' are not preferred. Consider using octal permissions '0444'. Signed-off-by: Shyam Saini <mayhs11saini@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: gs_fpgaboot: Remove FSF address from GPL noticeRehas Sachdeva2016-09-162-9/+0
| | | | | | | | | | | | This patch fixes the checkpatch.pl warning: CHECK: Do not include the paragraph about writing to the Free Software Foundation's mailing address from the sample GPL notice. The FSF has changed addresses in the past, and may do so again. Linux already includes a copy of the GPL. Signed-off-by: Rehas Sachdeva <aquannie@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: gs_fpga_boot: Remove multiple blank linessayli karnik2016-09-131-2/+0
| | | | | | | | | | This patch fixes the following checkpatch warning for the gs_fpgaboot driver: CHECK: Please don't use multiple blank lines. Signed-off-by: sayli karnik <karniksayli1995@gmail.com> Acked-by: Julia Lawall <julia.lawall@lip6.fr> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* Staging: gs_fpgaboot: remove blank line in io.cBen Marsh2016-03-291-1/+0
| | | | | | | Removes a blank line in order to silence a checkpatch.pl warning. Signed-off-by: Ben Marsh <bmarsh94@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* Staging: gs_fpgaboot: Replace 'int32_t' with 'int'.Sandhya Bankar2016-03-281-1/+1
| | | | | | | Replace 'int32_t' with 'int'. Signed-off-by: Sandhya Bankar <bankarsandhya512@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* Staging: gs_fpgaboot: Add space around '+'.Sandhya Bankar2016-03-281-1/+1
| | | | | | | Add space around '+'. Signed-off-by: Sandhya Bankar <bankarsandhya512@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* Staging: gs_fpgaboot: Remove unnecessary blank lines.Sandhya Bankar2016-03-281-2/+0
| | | | | | | Remove unnecessary blank lines. Signed-off-by: Sandhya Bankar <bankarsandhya512@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* Staging: gs_fpgaboot: Fix alignment to match open parenthesis.Sandhya Bankar2016-03-281-2/+2
| | | | | | | Fix alignment to match open parenthesis. Signed-off-by: Sandhya Bankar <bankarsandhya512@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: gs_fpgaboot: drop wrapper function 'finish_driver'Eva Rachel Retuya2016-03-111-7/+2
| | | | | | | | | | | | | | | | | | | | | | | | Remove the function 'finish_driver' since a direct call to platform_device_unregister() is intuitive enough to signify the original intention of the function being removed. Coccinelle semantic patch used to detect this: @@ identifier wrapper, func; type T; @@ *T wrapper(...) { ( return func(...); | func(...); ) } Signed-off-by: Eva Rachel Retuya <eraretuya@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* Staging: gs_fpgaboot: fix data types in gs_fpgaboot.cBen Marsh2016-02-071-2/+2
| | | | | | | | This is a patch to gs_fpgaboot.c to convert data types to kernel types as identified by checkpatch.pl. Signed-off-by: Ben Marsh <bmarsh94@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* Staging: gs_fpgaboot: fix memory allocation in gs_fpgaboot.cBen Marsh2016-02-071-1/+1
| | | | | | | | This is a patch for gs_fpgaboot.c that fixes a memory allocation problem identified by checkpatch.pl. Signed-off-by: Ben Marsh <bmarsh94@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: Remove <linux/moduleparam.h> header.Navya Sri Nizamkari2015-03-011-1/+0
| | | | | | | | | | | | | | | | | This patch drops #include <linux/moduleparam.h> in all the staging driver files that also include #include <linux/module.h> as module.h includes moduleparam.h already. The following semantic patch is used to make these changes: @ includesmodule @ @@ @ depends on includesmodule @ @@ - #include <linux/moduleparam.h> Signed-off-by: Navya Sri Nizamkari <navyasri.tech@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: gs_fpgaboot: io.c: Remove unused functionRickard Strandqvist2015-01-171-9/+0
| | | | | | | | | | Remove the function bitswap() that is not used anywhere. This was partially found by using a static code analysis program called cppcheck. Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se> Reviewed-by: Insop Song <Insop.Song@gainspeed.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: gs_fpgaboot: fix a compiler warning with make W=2Devendra Naga2014-10-291-4/+4
| | | | | | | | | | | | | The below warning is fixed: drivers/staging/gs_fpgaboot/gs_fpgaboot.c: In function ‘gs_load_image’: drivers/staging/gs_fpgaboot/gs_fpgaboot.c:196:58: warning: declaration of ‘file’ shadows a global declaration [-Wshadow] drivers/staging/gs_fpgaboot/gs_fpgaboot.c:45:14: warning: shadowed declaration is here [-Wshadow] by renaming file function argument of gs_load_image with fw_file. Signed-off-by: Devendra Naga <devendranaga4@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: gs_fpgpaboot: fix compiler warning with make W=1Devendra Naga2014-10-291-2/+0
| | | | | | | | | | | | | | | the following compiler warning has been fixed: drivers/staging/gs_fpgaboot/gs_fpgaboot.c: In function ‘gs_read_bitstream’: drivers/staging/gs_fpgaboot/gs_fpgaboot.c:160:6: warning: variable ‘size’ set but not used [-Wunused-but-set-variable] CC drivers/staging/gs_fpgaboot/io.o LD drivers/staging/gs_fpgaboot/gs_fpga.o LD drivers/staging/gs_fpgaboot/built-in.o by removing the size variable. Signed-off-by: Devendra Naga <devendranaga4@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: gs_fpgaboot: cleanup in gs_fpgaboot_init functionDevendra Naga2014-10-291-10/+5
| | | | | | | | the error path is cleanup to return the correct (function call return value) error code. Signed-off-by: Devendra Naga <devendranaga4@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: gs_fpgaboot: Fix "out of memory" error handlingDzmitry Sledneu2014-10-201-3/+2
| | | | | | | Fix "out of memory" error handling Signed-off-by: Dzmitry Sledneu <dzmitry.sledneu@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: gs_fpgaboot: Use print_hex_dump_bytes instead of pr_infoJoe Perches2014-10-201-23/+2
| | | | | | | | Use print_hex_dump_bytes instead of pr_info Signed-off-by: Dzmitry Sledneu <dzmitry.sledneu@gmail.com> Reviewed-by: Insop Song <insop.song@gainspeed.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: gs_fpgaboot: remove unnecessary 'out of memory' messageEbru Akagunduz2014-10-201-3/+1
| | | | | | | | This patch fixes "Possible unnecessary 'out of memory' message" checkpatch.pl warning in gs_fpgaboot.c Signed-off-by: Ebru Akagunduz <ebru.akagunduz@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: gs_fpgaboot Fix trailing whitespace.Aybuke Ozdemir2014-09-191-2/+1
| | | | | | | | Fix checkpatch.pl issues with trailing whitespace in README. Signed-off-by: Aybuke Ozdemir <aybuke.147@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: gs_fpgaboot: remove checks for CONFIG_B4860G100Paul Bolle2014-09-081-163/+0
| | | | | | | | | There are two checks for CONFIG_B4860G100 in this driver. But there's no Kconfig symbol B4860G100. These checks will always evaluate to false. Remove them and the code they hide. Signed-off-by: Paul Bolle <pebolle@tiscali.nl> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: gs_fpgaboot: remove unnecessary return statementsMichał Bartoszkiewicz2014-09-061-6/+0
| | | | | | | | | This fixes "void function return statements are not generally useful" warnings from checkpatch.pl. Signed-off-by: Michał Bartoszkiewicz <mbartoszkiewicz@gmail.com> Reviewed-by: Insop Song <insop.song@gainspeed.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: gs_fpgaboot: Fixed code style issuesRocco Folino2014-05-152-1/+7
| | | | | | | Fixed missing a blank line after declarations warning Signed-off-by: Rocco Folino <lordzen87@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: gs_fpgaboot: remove __TIMESTAMP__ macroArnd Bergmann2014-04-151-1/+0
| | | | | | | | | | | | | | | We specifically build the kernel with -Werror=date-time to detect such macros, which gives us this error: gs_fpgaboot/gs_fpgaboot.c:376:44: error: macro "__TIMESTAMP__" might prevent reproducible builds [-Werror=date-time] pr_info("built at %s UTC\n", __TIMESTAMP__); The obvious fix is to remove the printk output line. Signed-off-by: Arnd Bergmann <arnd@arndb.de> Signed-off-by: Insop Song <insop.song@gainspeed.com> Acked-by: Geert Uytterhoeven <geert@linux-m68k.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: fpgaboot: clean up MakefilePaul Bolle2014-04-151-2/+0
| | | | | | | | | | This Makefile tries to set the DEBUG macro but it uses an unknown Kconfig macro to do so. Since no code appears to even care about the DEBUG macro this line can safely be removed. Signed-off-by: Paul Bolle <pebolle@tiscali.nl> Reviewed-by: Insop Song <insop.song@gainspeed.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* Staging: gs_gpgaboot: Fix Bad function definition in io.cMonam Agarwal2014-03-071-2/+2
| | | | | | | | | This patch fixes the following checkpatch.pl issues in io.c WARNING: Bad function definition Signed-off-by: Monam Agarwal <monamagarwal123@gmail.com> Acked-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: fpgaboot: fix coccinelle warningsFengguang Wu2014-02-141-1/+1
| | | | | | | | | | | | drivers/staging/gs_fpgaboot/gs_fpgaboot.c:191:2-3: Unneeded semicolon Removes unneeded semicolon. Generated by: coccinelle/misc/semicolon.cocci CC: Insop Song <insop.song@gainspeed.com> Signed-off-by: Fengguang Wu <fengguang.wu@intel.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: fpgaboot: fix coccinelle warningsFengguang Wu2014-02-141-4/+1
| | | | | | | | | | | | drivers/staging/gs_fpgaboot/gs_fpgaboot.c:305:1-3: WARNING: PTR_RET can be used Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR Generated by: coccinelle/api/ptr_ret.cocci CC: Insop Song <insop.song@gainspeed.com> Signed-off-by: Fengguang Wu <fengguang.wu@intel.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: fpgaboot: Xilinx FPGA firmware download driverInsop Song2014-02-078-0/+955
This driver downloads Xilinx FPGA firmware using gpio pins. It loads Xilinx FPGA bitstream format firmware image and program the Xilinx FPGA using SelectMAP (parallel) mode. Signed-off-by: Insop Song <insop.song@gainspeed.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
OpenPOWER on IntegriCloud