summaryrefslogtreecommitdiffstats
path: root/drivers/staging/fwserial
Commit message (Collapse)AuthorAgeFilesLines
...
* | | staging/fwserial: Remove reference to removed constantPeter Hurley2013-01-291-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | FWSERIAL_TTY_START_MINOR was removed. The minor_start is allocated by tty_alloc_driver(). Signed-off-by: Peter Hurley <peter@hurleysoftware.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* | | staging/fwserial: Don't use deprecated alloc_tty_driver()Peter Hurley2013-01-291-12/+9
| | | | | | | | | | | | | | | | | | | | | Use tty_alloc_driver() instead. Signed-off-by: Peter Hurley <peter@hurleysoftware.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* | | staging/fwserial: Factor unstable stats/debug/status info to debugfsPeter Hurley2013-01-292-0/+84
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Add the following file hierarchy to debugfs: <debugfs>-+ +- firewire_serial -+- <unit> -+- peers | +- stats | +- <unit> -+- peers +- stats The 'peers' file (read-only) contains status and configuration info for attached peers for the given fwserial unit. The 'stats' file (read-only) contains statistics and data profiling information for each tty port for the given fwserial unit. Signed-off-by: Peter Hurley <peter@hurleysoftware.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* | | staging/fwserial: Cleanup /proc/tty/driver/ filePeter Hurley2013-01-291-24/+15
| | | | | | | | | | | | | | | | | | | | | | | | Factor out extra stats, data profiles, debugging info and peer info from procfs file in preparation for using debugfs instead. Signed-off-by: Peter Hurley <peter@hurleysoftware.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* | | staging/fwserial: Create loop device the 'tty' wayPeter Hurley2013-01-292-96/+93
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Register a second tty driver to create loopback devices for each firewire node. Note that the loopback devices are numbered from 0; the tty->index is transformed when used to index the port table. Remove the hack that previously enabled this. Signed-off-by: Peter Hurley <peter@hurleysoftware.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* | | staging/fwserial: Fix sparse build warningsPeter Hurley2013-01-292-2/+4
| | | | | | | | | | | | | | | | | | Reported-by: Stefan Richter <stefanr@s5r6.in-berlin.de> Signed-off-by: Peter Hurley <peter@hurleysoftware.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* | | staging/fwserial: Release port regardless of unplug response codePeter Hurley2013-01-291-3/+2
| | | | | | | | | | | | | | | | | | | | | | | | After sending the unplug response, release the port even if an error occurred. Signed-off-by: Peter Hurley <peter@hurleysoftware.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* | | staging/fwserial: Only reset port status for attached peersPeter Hurley2013-01-291-9/+12
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When a port has been reserved in an attempt to connect to a peer but that attempt does not succeed, releasing the port should not reset the port line status. Although resetting is functionally harmless, it can appear as if a remote peer dropped carrier to a port it was not attached to (which can be confusing). Signed-off-by: Peter Hurley <peter@hurleysoftware.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* | | staging/fwserial: Drop suggestion for helper fn integrationPeter Hurley2013-01-291-2/+0
| | | | | | | | | | | | | | | | | | | | | | | | The firewire core does not require or want the suggested helper fns; drop suggestion from TODO file. Signed-off-by: Peter Hurley <peter@hurleysoftware.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* | | staging/fwserial: Assume firmware is OHCI-complaintPeter Hurley2013-01-291-2/+7
| | | | | | | | | | | | | | | | | | | | | | | | | | | Devices which are OHCI v1.0/ v1.1/ v1.2-draft compliant or RFC 2734 compliant are required by specification to support max_rec of 8 (512 bytes) or more. Accept reported value. Signed-off-by: Peter Hurley <peter@hurleysoftware.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* | | staging/fwserial: Fold constant MAX_ASYNC_PAYLOADPeter Hurley2013-01-291-2/+1
| | | | | | | | | | | | | | | | | | | | | | | | Since peer->max_payload is now limited to 1394-2008 spec maximum of 4096, the port->max_payload limit can now be simplified. Signed-off-by: Peter Hurley <peter@hurleysoftware.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* | | staging/fwserial: Simplify max payload calculationPeter Hurley2013-01-291-2/+2
| | | | | | | | | | | | | | | Signed-off-by: Peter Hurley <peter@hurleysoftware.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* | | staging/fwserial: Refer to fw_device as "node"Peter Hurley2013-01-291-1/+1
| | | | | | | | | | | | | | | Signed-off-by: Peter Hurley <peter@hurleysoftware.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* | | staging/fwserial: Remove bandwidth limit logicPeter Hurley2013-01-292-12/+6
| |/ |/| | | | | | | | | | | | | | | | | | | Self-limiting asynchronous bandwidth (via reducing the payload) is not necessary and does not work, because 1) asynchronous traffic will absorb all available bandwidth (less that being used for isochronous traffic) 2) isochronous arbitration always wins. Signed-off-by: Peter Hurley <peter@hurleysoftware.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* | staging/fwserial: Update TODO file per reviewer commentsPeter Hurley2013-01-071-8/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Pursuant to this review https://lkml.org/lkml/2012/11/12/500 by Stefan Richter, update the TODO file. - Clarify purpose of TODO file - Remove firewire item #4. As discussed in this conversation https://lkml.org/lkml/2012/11/13/564 knowing the AR buffer size is not a hard requirement. The required rx buffer size can be determined experimentally. - Remove firewire item #5. This was a private note for further experimentation. - Change firewire item #1. Change suggested header from uapi header to kernel-only header. Signed-off-by: Peter Hurley <peter@hurleysoftware.com> Acked-by: Stefan Richter <stefanr@s5r6.in-berlin.de> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* | staging/fwserial: Limit tx/rx to 1394-2008 spec maximumPeter Hurley2013-01-073-7/+4
| | | | | | | | | | | | | | | | | | | | Per this conversation https://lkml.org/lkml/2012/11/27/587 limit the maximum transmission to the IEEE 1394-2008 specification maximum size of 4096 bytes for asynchronous packets. Signed-off-by: Peter Hurley <peter@hurleysoftware.com> Acked-by: Stefan Richter <stefanr@s5r6.in-berlin.de> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* | staging/fwserial: Refine Kconfig help textPeter Hurley2013-01-071-1/+3
|/ | | | | | | | | Users should be informed upfront that this is a Linux-only affair currently. Signed-off-by: Peter Hurley <peter@hurleysoftware.com> Acked-by: Stefan Richter <stefanr@s5r6.in-berlin.de> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging/fwserial: Remove superfluous freePeter Hurley2012-11-281-1/+0
| | | | | | | | Now that the dma fifo is allocated on activate and freed on shutdown, this extra free is harmless but unnecessary. Signed-off-by: Peter Hurley <peter@hurleysoftware.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging/fwserial: Use WARN_ONCE when port table is corruptedPeter Hurley2012-11-281-8/+3
| | | | | Signed-off-by: Peter Hurley <peter@hurleysoftware.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging/fwserial: Destruct embedded tty_port on teardownPeter Hurley2012-11-281-1/+4
| | | | | | | | | | For TTY drivers that manage the port lifetime, the tty_port should to be specifically destructed when the port lifetime ends. Now that a method has been added to do this, use it. Signed-off-by: Peter Hurley <peter@hurleysoftware.com> Cc: Jiri Slaby <jslaby@suse.cz> Cc: Alan Cox <alan@linux.intel.com>
* staging/fwserial: Fix build breakage when !CONFIG_BUGPeter Hurley2012-11-281-4/+1
| | | | | | | | | Use WARN() as intended. Reported-by: Randy Dunlap <rdunlap@infradead.org> Acked-by: Randy Dunlap <rdunlap@infradead.org> Signed-off-by: Peter Hurley <peter@hurleysoftware.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: fwserial: Add TTY-over-Firewire serial driverPeter Hurley2012-11-287-0/+3821
This patch provides the kernel driver for high-speed TTY communication over the IEEE 1394 bus. Signed-off-by: Peter Hurley <peter@hurleysoftware.com> Acked-by: Stefan Richter <stefanr@s5r6.in-berlin.de> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
OpenPOWER on IntegriCloud