summaryrefslogtreecommitdiffstats
path: root/drivers/staging/dgnc
Commit message (Collapse)AuthorAgeFilesLines
* Staging: dgnc: avoiding buffer overflowAshvini Varatharaj2013-10-191-1/+1
| | | | | | | | | | drivers/staging/dgnc/dgnc_neo.c:1969 neo_vpd() error: buffer overflow 'brd->vpd' 128 <= 128 drivers/staging/dgnc/dgnc_neo.c:1970 neo_vpd() warn: buffer overflow 'brd->vpd' 128 <= 130 drivers/staging/dgnc/dgnc_neo.c:1970 neo_vpd() warn: buffer overflow 'brd->vpd' 128 <= 130 Signed-off-by: Ashvini Varatharaj <ashvinivaratharaj@gmail.com> Reviewed-by: Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* Staging: dgnc: removing the comparison 'board<0'Ashvini Varatharaj2013-10-191-1/+1
| | | | | | | | Fix dgnc_mgmt_ioctl() warn: unsigned 'board' is never less than zero. Signed-off-by: Ashvini Varatharaj <ashvinivaratharaj@gmail.com> Reviewed-by: Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: dgnc: braces {} are not necessary for single statement in dgnc_driver.cArchana kumari2013-10-191-2/+1
| | | | | | | | | Fixes "braces {} are not necessary for single statement blocks" warning in dgnc_driver.c Signed-off-by: Archana kumari <archanakumari959@gmail.com> Reviewed-by: Josh Triplett <josh@joshtriplett.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: dgnc:Removed unecessary error messages in dgnc_driver.cArchana kumari2013-10-191-2/+0
| | | | | | | | Fixed removal of unecessary error messages in staging:dgnc:dgnc_driver.c Signed-off-by: Archana kumari <archanakumari959@gmail.com> Reviewed-by: Josh Triplett <josh@joshtriplett.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: dgnc: braces {} are not necessary for single statement in dgnc_cls.cArchana kumari2013-10-171-14/+7
| | | | | | | | Fix checkpatch.pl issues with braces {} are not necessary for single statement blocks in dgnc_cls.c Signed-off-by: Archana kumari <archanakumari959@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging:dgnc:Fixes use of deprecated headers in dgnc_cls.cArchana kumari2013-10-161-1/+1
| | | | | | | Fixes use of deprecated header <asm/io.h> in staging:dgnc:dgnc_cls.c Signed-off-by: Archana kumari <archanakumari959@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: dgnc: dgnc_tty: Do not use 0 for NULL pointerSachin Kamat2013-10-111-1/+1
| | | | | | | | Do not use 0 for NULL pointer. Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org> Cc: Lidza Louina <lidza.louina@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: dgnc: changes arguments in sizeofLidza Louina2013-10-053-15/+15
| | | | | | | | | | | | | The arguments that were passed into sizeof were generic. This patch changes this by putting the actual item that we need a size of instead. For example: - kzalloc(sizeof(struct dgnc_board), GFP_KERNEL); + kzalloc(sizeof(*brd), GFP_KERNEL); Signed-off-by: Lidza Louina <lidza.louina@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: dgnc: Remove KERNEL_VERSION checkSachin Kamat2013-09-301-5/+0
| | | | | | | | This check is not required. Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org> Acked-by: Lidza Louina <lidza.louina@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: dgnc: Remove casting the return value which is a void pointerJingoo Han2013-09-262-13/+13
| | | | | | | | | | | Casting the return value which is a void pointer is redundant. The conversion from void pointer to any other pointer type is guaranteed by the C programming language. CC: Lidza Louina <lidza.louina@gmail.com> Signed-off-by: Jingoo Han <jg1.han@samsung.com> Signed-off-by: Fengguang Wu <fengguang.wu@intel.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: dgnc: removes LINUX_VERSION_CODE conditionalsLidza Louina2013-09-253-95/+2
| | | | | | | | | This patch removes the conditionals that make sure the driver supports various versions of the kernel. They aren't needed. Signed-off-by: Lidza Louina <lidza.louina@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* Merge 3.12-rc2 into staging-next.Greg Kroah-Hartman2013-09-251-2/+2
|\ | | | | | | | | | | | | | | This resolves the merge problem with two iio drivers that Stephen Rothwell pointed out. Reported-by: Stephen Rothwell <sfr@canb.auug.org.au> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
| * staging: dgnc: fix potential format string flawKees Cook2013-09-171-2/+2
| | | | | | | | | | | | | | | | Make sure that format strings cannot leak into printk() calls from the msgbuf string. Signed-off-by: Kees Cook <keescook@chromium.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* | staging: dgnc: Fix typo in staging/dgncMasanari Iida2013-09-175-7/+7
| | | | | | | | | | | | | | Correct spelling typo in comments Signed-off-by: Masanari Iida <standby24x7@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* | staging: dgnc: removes parentheses around return statementsLidza Louina2013-09-176-236/+236
| | | | | | | | | | | | | | | | This patch removes parentheses around return statements. They aren't needed. Signed-off-by: Lidza Louina <lidza.louina@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* | staging: dgnc: renames board_t to dgnc_boardLidza Louina2013-09-178-82/+82
|/ | | | | | | | This patch renames the struct board_t to dgnc_board. board_t wasn't a good name for it since the _t suffix is for typedefs. Signed-off-by: Lidza Louina <lidza.louina@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: dgnc: adds TODOLidza Louina2013-08-301-0/+17
| | | | | | | This patchs adds a TODO for the driver. Signed-off-by: Lidza Louina <lidza.louina@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: dgnc: driver.c and .h: removes dgnc_driver_kzmalloc funcLidza Louina2013-08-272-16/+0
| | | | | | | | | This patch removes the dgnc_driver_kzmalloc function from driver.c and driver.h. A previous patch replaced all dgnc_driver_kzmalloc function calls with kzalloc. Signed-off-by: Lidza Louina <lidza.louina@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: dgnc: driver.c and tty.c: replaces dgnc_driver_kzmalloc with kzallocLidza Louina2013-08-272-13/+13
| | | | | | | | | This patch replaces dgnc_driver_kzmalloc with kzalloc. A patch that follows removes the dgnc_driver_kzmalloc function. Signed-off-by: Lidza Louina <lidza.louina@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: dgnc: tty.c: updates uart_struct declaration for sparseLidza Louina2013-08-271-3/+3
| | | | | | | | | | | | | | | | | | This patch edits the type casts neo_uart_struct and cls_uart_struct. A previous patch added the marker __iomem to these structs. This patch ensures that the change to the marker is consistent. This also removes these sparse warnings: warning: incorrect type in assignment (different address spaces) expected struct neo_uart_struct [noderef] <asn:2>*ch_neo_uart got struct neo_uart_struct *<noident> warning: incorrect type in assignment (different address spaces) expected struct cls_uart_struct [noderef] <asn:2>*ch_cls_uart got struct cls_uart_struct *<noident> Signed-off-by: Lidza Louina <lidza.louina@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: dgnc: tty.c: edits var in init func for sparseLidza Louina2013-08-261-1/+1
| | | | | | | | | | | | This patch edits the vaddr variable in dgnc_tty_init. The variable gets set to board_t->re_map_membase. A previous patch changed the re_map_membase variable's marker and type. This patch makes sure that the changes are consistent and that it doesn't cause sparse warnings. Signed-off-by: Lidza Louina <lidza.louina@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: dgnc: neo.c: changes param in neo_read_eeprom function for sparseLidza Louina2013-08-261-1/+1
| | | | | | | | | | | | | | | | | | | | | | This patch adds a marker to neo_read_eeprom function's base parameter. It removes these warnings found in neo.c: warning: incorrect type in argument 1 (different address spaces) expected unsigned char *base got unsigned char [noderef] [usertype] <asn:2>*re_map_membase warning: incorrect type in argument 2 (different address spaces) expected void volatile [noderef] <asn:2>*addr got unsigned char * These warnings happen because this function gets called with a board_t->re_map_base variable. A previous patch added the __iomem marker to this variable. This patch ensures that the changes are consistent. Signed-off-by: Lidza Louina <lidza.louina@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: dgnc: cls.c: changes var in cls_vpd function for sparseLidza Louina2013-08-261-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | This patch changes cls_vpd function's re_map_vpdbase variable type and marker. It removes these warnings found in cls.c: warning: incorrect type in assignment (different address spaces) expected unsigned char [usertype] *re_map_vpdbase got void [noderef] <asn:2>* warning: incorrect type in argument 1 (different address spaces) expected void const volatile [noderef] <asn:2>*addr got unsigned char [usertype] * warning: incorrect type in argument 1 (different address spaces) expected void volatile [noderef] <asn:2>*addr got unsigned char [usertype] *re_map_vpdbase The variables passed to readb needs to be of type u8 with a __iomem marker. re_map_vpdbase is passed into readb in the code. Signed-off-by: Lidza Louina <lidza.louina@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: dgnc: driver.h: changes a struct board_t var's type and marker for ↵Lidza Louina2013-08-261-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | sparse This patch changes the board_t->re_map_membase variable type and marker. It removes these warnings found in the neo.c, driver.c and cls.c files: warning: incorrect type in argument 1 (different address spaces) expected void const volatile [noderef] <asn:2>*addr got unsigned char volatile *<noident> warning: incorrect type in argument 2 (different address spaces) expected void volatile [noderef] <asn:2>*addr got unsigned char volatile *<noident> The variables passed to readb and writeb need to be of type u8 with a __iomem marker. These warnings were popping up everytime the readb and writeb functions were called with a board_t->re_map_membase variable. The change made to the driver.h file adds the marker and changes the variable type. Signed-off-by: Lidza Louina <lidza.louina@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: dgnc: neo_uart_struct: adds marker and changes vars' types for sparseLidza Louina2013-08-262-22/+22
| | | | | | | | | | | | | | | | | | | | | | | This patch fixes these warnings found in the neo.c file: warning: incorrect type in argument 1 (different address spaces) expected void const volatile [noderef] <asn:2>*addr got unsigned char volatile *<noident> warning: incorrect type in argument 2 (different address spaces) expected void volatile [noderef] <asn:2>*addr got unsigned char volatile *<noident> The variables passed to readb and writeb need to be of type u8 with a __iomem marker. These warnings were popping up everytime the readb and writeb functions were called with a neo_uart_struct variable. The change made to the driver.h file adds the marker to the neo_uart_struct and the changes in neo.h changes the variables' types. Signed-off-by: Lidza Louina <lidza.louina@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: dgnc: cls_uart_struct: adds marker and changes vars' types for sparseLidza Louina2013-08-262-9/+9
| | | | | | | | | | | | | | | | | | | | | | | This patch removes these sparse warnings found in the cls.c file: warning: incorrect type in argument 1 (different address spaces) expected void const volatile [noderef] <asn:2>*addr got unsigned char volatile *<noident> warning: incorrect type in argument 2 (different address spaces) expected void volatile [noderef] <asn:2>*addr got unsigned char volatile *<noident> The variables passed to readb and writeb need to be of type u8 with a __iomem marker. These warnings were popping up everytime the readb and writeb functions were called with a cls_uart_struct variable. The change made to the driver.h file adds the marker to the cls_uart_struct and the changes in cls.h changes its variables' types. Signed-off-by: Lidza Louina <lidza.louina@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: dgnc: Kconfig: add dependency PCI for itChen Gang2013-08-261-1/+1
| | | | | | | | | | | | | | DGNC is based on PCI, so need add related dependency, or when compiled with PCI disabled, it will be fail. The related error (randconfig for PCI disabled under s390): drivers/staging/dgnc/dgnc_cls.c:1394:2: error: implicit declaration of function ‘ioremap’ [-Werror=implicit-function-declaration] drivers/staging/dgnc/dgnc_cls.c:1407:3: error: implicit declaration of function ‘iounmap’ [-Werror=implicit-function-declaration] Cc: Lidza Louina <lidza.louina@gmail.com> Signed-off-by: Chen Gang <gang.chen@asianux.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: dgnc: driver.c: removes dgnc_mbuf functionLidza Louina2013-08-221-40/+0
| | | | | | | | | | | | | | | | | | | | This patch removes the dgnc_mbuf function. This function was causing the errors: drivers/staging/dgnc/dgnc_driver.c: In function 'dgnc_mbuf.constprop.0': drivers/staging/dgnc/dgnc_driver.c:945:1: warning: the frame size of 1032 bytes is larger than 1024 bytes [-Wframe-larger-than=] drivers/staging/dgnc/dgnc_tty.c: In function 'dgnc_sniff_nowait_nolock': drivers/staging/dgnc/dgnc_tty.c:614:1: warning: the frame size of 1056 bytes is larger than 1024 bytes [-Wframe-larger-than=] This patch removes it so the kernel won't be making noise when its device is found on the system. Reported-by: Fengguang Wu <fengguang.wu@intel.com> Signed-off-by: Lidza Louina <lidza.louina@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: dgnc: driver.c: Need to include slab.hTushar Behera2013-08-221-0/+1
| | | | | | | | | | | | | | | | With 'allyesconfig', we get following error without this. drivers/staging/dgnc/dgnc_driver.c: In function ‘dgnc_cleanup_board’: drivers/staging/dgnc/dgnc_driver.c:459:3: error: implicit declaration of function ‘kfree’ [-Werror=implicit-function-declaration] kfree(brd->msgbuf_head); ^ drivers/staging/dgnc/dgnc_driver.c: In function ‘dgnc_driver_kzmalloc’: drivers/staging/dgnc/dgnc_driver.c:905:2: error: implicit declaration of function ‘kmalloc’ [-Werror=implicit-function-declaration] void *p = kmalloc(size, priority); Signed-off-by: Tushar Behera <tushar.behera@linaro.org> Cc: Lidza Louina <lidza.louina@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: dgnc: tty.c: fixes code indent errorLidza Louina2013-08-211-78/+78
| | | | | | | | This patch fixes the error "code indent should use tabs where possible" in dgnc_tty.c. Signed-off-by: Lidza Louina <lidza.louina@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: dgnc: sysfs.c: fixes code indent errorLidza Louina2013-08-211-2/+2
| | | | | | | | This patch fixes the error "code indent should use tabs where possible" in dgnc_sysfs.c. Signed-off-by: Lidza Louina <lidza.louina@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: dgnc: neo.c: fixes code indent errorLidza Louina2013-08-211-23/+23
| | | | | | | | This patch fixes the error "code indent should use tabs where possible" in dgnc_neo.c. Signed-off-by: Lidza Louina <lidza.louina@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: dgnc: driver.h: fixes code indent errorLidza Louina2013-08-211-15/+15
| | | | | | | | This patch fixes the error "code indent should use tabs where possible" in dgnc_driver.h. Signed-off-by: Lidza Louina <lidza.louina@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: dgnc: driver.c: fixes code indent errorLidza Louina2013-08-211-35/+35
| | | | | | | | This patch fixes the error "code indent should use tabs where possible" in dgnc_driver.c. Signed-off-by: Lidza Louina <lidza.louina@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: dgnc: fixes struct declarationLidza Louina2013-08-212-4/+2
| | | | | | | | This patch fixes the error: open brace '{' following struct go on the same line. Signed-off-by: Lidza Louina <lidza.louina@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: dgnc: tty.c: fixes pointer syntaxLidza Louina2013-08-211-2/+2
| | | | | | | This patch fixes the error: "foo* bar" should be "foo *bar". Signed-off-by: Lidza Louina <lidza.louina@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: dgnc: removes CVS code from filesLidza Louina2013-08-2110-18/+0
| | | | | | | | This patch removes the code supporting CVS from its files. Signed-off-by: Lidza Louina <lidza.louina@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: dgnc: dpacompat.h: removes trailing whitespaceLidza Louina2013-08-211-2/+2
| | | | | | | | This patch removes trailing whitespace in the dpacompat.h file. Signed-off-by: Lidza Louina <lidza.louina@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: dgnc: digi.h: removes trailing whitespaceLidza Louina2013-08-211-15/+15
| | | | | | | | This patch removes trailing whitespace in the digi.h file. Signed-off-by: Lidza Louina <lidza.louina@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: dgnc: tty.c: removes trailing whitespaceLidza Louina2013-08-211-89/+89
| | | | | | | | This patch removes trailing whitespace in the dgnc_tty.c file. Signed-off-by: Lidza Louina <lidza.louina@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: dgnc: trace.c: removes trailing whitespaceLidza Louina2013-08-211-8/+8
| | | | | | | | This patch removes trailing whitespace in the dgnc_trace.c file. Signed-off-by: Lidza Louina <lidza.louina@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: dgnc: sysfs.h: removes trailing whitespaceLidza Louina2013-08-211-1/+1
| | | | | | | | This patch removes trailing whitespace in the dgnc_sysfs.h file. Signed-off-by: Lidza Louina <lidza.louina@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: dgnc: sysfs.c: removes trailing whitespaceLidza Louina2013-08-211-9/+9
| | | | | | | | This patch removes trailing whitespace in the sysfs.c file. Signed-off-by: Lidza Louina <lidza.louina@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: dgnc: neo.h: removes trailing whitespaceLidza Louina2013-08-211-6/+6
| | | | | | | | This patch removes trailing whitespace in the neo.h file. Signed-off-by: Lidza Louina <lidza.louina@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: dgnc: neo.c: removes trailing whitespaceLidza Louina2013-08-211-23/+23
| | | | | | | | This patch removes trailing whitespace in the dgnc_neo.c file. Signed-off-by: Lidza Louina <lidza.louina@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: dgnc: mgmt.c: removes trailing whitespaceLidza Louina2013-08-211-19/+19
| | | | | | | | This patch removes trailing whitespace in the dgnc_mgmt.c file. Signed-off-by: Lidza Louina <lidza.louina@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: dgnc: kcompat.h: removes trailing whitespaceLidza Louina2013-08-211-2/+2
| | | | | | | | This patch removes trailing whitespace in the kcompat.h file. Signed-off-by: Lidza Louina <lidza.louina@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: dgnc: driver.h: removes trailing whitespaceLidza Louina2013-08-211-9/+9
| | | | | | | | This patch removes trailing whitespace in the driver.h file. Signed-off-by: Lidza Louina <lidza.louina@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: dgnc: driver.c: removes trailing whitespaceLidza Louina2013-08-211-13/+13
| | | | | | | | This patch removes trailing whitespace in the dgnc_driver.c file. Signed-off-by: Lidza Louina <lidza.louina@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: dgnc: cls.h: removes trailing whitespaceLidza Louina2013-08-211-3/+3
| | | | | | | | This patch removes trailing whitespace in the dgnc_cls.h file. Signed-off-by: Lidza Louina <lidza.louina@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
OpenPOWER on IntegriCloud