summaryrefslogtreecommitdiffstats
path: root/drivers/staging/bcm2835-audio/bcm2835-vchiq.c
Commit message (Collapse)AuthorAgeFilesLines
* staging: bcm2835-audio: Move driver under vc04_servicesMichael Zoran2017-03-061-910/+0
| | | | | | | | | The bcm2835-audio driver is part of v04_services, so it makes sense for it to be located under vc04_services to make configuration clearer. Signed-off-by: Michael Zoran <mzoran@crowfest.net> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: bcm2835-audio: Removed braces of single statement blocksAbhijit Naik2017-03-061-4/+5
| | | | | | | | bcm2835-vchiq.c: fixing WARNING: braces {} are not necessary for single statement blocks Signed-off-by: Abhijit Naik <abhijitnaik27@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: bcm2835-audi: Removed return statement from void functionsAbhijit Naik2017-03-061-3/+0
| | | | | | | | bcm2835-vchiq.c: fixing WARNING: void function return statements are not generally useful Signed-off-by: Abhijit Naik <abhijitnaik27@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: bcm2835-audio: allocate enough data for work queuesDan Carpenter2017-02-161-6/+9
| | | | | | | | | We accidentally allocate sizeof(void *) bytes instead of 112 bytes. It results in memory corruption. Fixes: 23b028c871e1 ("staging: bcm2835-audio: initial staging submission") Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: bcm2835-audio: Fixed checkpatch warning due to line spacingAbhijit Naik2017-02-141-1/+17
| | | | | | | | | bcm2835-vchiq.c: fixing ERROR: Checkpatch warnings due to extra blank lines or absence of blank lines where needed. Signed-off-by: Abhijit Naik <abhijitnaik27@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: bcm2835-audio: fix trailing statementsAbdAllah-MEZITI2017-02-121-1/+3
| | | | | | | Trailing statements should be on next line. Signed-off-by: AbdAllah-MEZITI <abdallah.meziti.pro@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: bcm2835-audio: Make internal symbols staticSimon Sandström2017-02-101-4/+4
| | | | | | | | Fixes sparse warnings: warning: symbol 'xxx' was not declared. Should it be static? Signed-off-by: Simon Sandström <simon@nikanor.nu> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: bcm2835-audio: Fixed initialization of global to "false"Abhijit Naik2017-02-101-1/+1
| | | | | | | | | | | bcm2835-vchiq.c: fixing ERROR: do not initialise globals to false Instead of explicitly initializing global variable force_bulk to "false", declared force_bulk as static variable. Signed-off-by: Abhijit Naik <abhijitnaik27@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* Staging: bcm2835-audio: remove unneeded NULL checkDan Carpenter2017-02-091-4/+3
| | | | | | | | We just dereferenced "instance" on the line before so checking it here is pointless. Anyway, it can't be NULL here so let's remove the check. Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* Staging: bcm2835-audio: fix an uninitialized return valueDan Carpenter2017-02-091-0/+1
| | | | | | | "ret" isn't necessarily initialized on the success path. Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* Staging: bcm2835-audio: removed spaces around parenthesisMichael Rupprecht2017-02-051-8/+8
| | | | | | | Removed unnecessary spaces around parenthesis as reported by checkpatch.pl Signed-off-by: Michael Rupprecht <mail.michaelrupprecht@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: bcm2835: cleanup: remove deprecated <asm/uaccess.h> includeSeraphime Kirkovski2017-02-031-1/+1
| | | | | | | | This replaces the last occurrence of the deprecated <asm/uaccess.h> include in the staging directory with the newer <linux/uaccess.h> Signed-off-by: Seraphime Kirkovski <kirkseraph@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: bcm2835-audio: use | instead of || otherwise result is just boolean 1Colin Ian King2017-02-021-2/+2
| | | | | | | | | | | | | The incorrect or operator is being used resulting in cookies being set to 1 (true) rather than the intended hex value. Fix this by using | instead of ||. Issue found with static analysis with cppcheck Fixes: 0cec463e391e05b807a ("staging: bcm2835-audio: Simplify callback structure for write data") Signed-off-by: Colin Ian King <colin.king@canonical.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: bcm2835-audio: fix empty-body warningArnd Bergmann2017-02-021-3/+3
| | | | | | | | | | | | | | gcc-7 warns about debug statements being left out here: drivers/staging/bcm2835-audio/bcm2835-vchiq.c: In function 'bcm2835_audio_set_ctls': drivers/staging/bcm2835-audio/bcm2835-vchiq.c:572:54: error: suggest braces around empty body in an 'else' statement [-Werror=empty-body] It's better to use no_printk(), which has the added advantage of checking the format strings. Fixes: 23b028c871e1 ("staging: bcm2835-audio: initial staging submission") Signed-off-by: Arnd Bergmann <arnd@arndb.de> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: bcm2835-audio: Replace call to vchi_msg_queue with ↵Michael Zoran2017-02-021-12/+3
| | | | | | | | | | | | vchi_queue_kernel_message The function vchi_msg_queue was made static in vc04_services and replaced with vchi_queue_kernel_message. Change the call to vchi_msg_queue to vchi_queue_kernel_message Signed-off-by: Michael Zoran <mzoran@crowfest.net> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: bcm2835-audio: Simplify callback structure for write dataMichael Zoran2017-01-311-19/+16
| | | | | | | | | | | | | | The device sends data to the audio devices by sending a message with the data through VC04_SERVICES/VCHIQ. This message contains a callback pointer that is always filled in with the same function. This is prone to corruption issues. Instead fill the callback fields with a fixed cookie value to perforam some validation on the message response and call the handler function directly instead of through the callback pointer. Signed-off-by: Michael Zoran <mzoran@crowfest.net> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: bcm2835-audio: initial staging submissionMichael Zoran2017-01-271-0/+903
Initial cleanup of bcm2835-audio driver for the bcm2535(Raspberry PI) Driver provides HDMI audio through ALSA and is built on top of the vc04_services driver. Original version of the driver is available at: http://www.github.com/raspberry/linux Driver compiles without any build errors or warnings. Tested on a RPI 3 running in ARM64 mode with the vlc player and alsautils. Signed-off-by: Michael Zoran <mzoran@crowfest.net> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
OpenPOWER on IntegriCloud