summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
...
* Staging: lustre: lov: Pull assignments out of function callBhumika Goyal2016-02-201-1/+2
| | | | | | | | | | | | | Assignments in function call arguments are undesirable. So pull such assignments out before function call. Made a coccinelle script to detect such cases: @@ expression fn,b,d; @@ * fn(...,d=b,...); Signed-off-by: Bhumika Goyal <bhumirks@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: lustre: osc: osc_request: Declare local function and structure as ↵Amitoj Kaur Chawla2016-02-201-3/+2
| | | | | | | | | | | | | | | | | | | static Declare osc_cleanup() function and osc_obd_ops structure as static since they are defined and called only in this file. Removed osc_cleanup() function prototype since it wasn't required. This fixes the following sparse warnings: drivers/staging/lustre/lustre/osc/osc_request.c:3210:5: warning: symbol 'osc_cleanup' was not declared. Should it be static? drivers/staging/lustre/lustre/osc/osc_request.c:3259:16: warning: symbol 'osc_obd_ops' was not declared. Should it be static? Signed-off-by: Amitoj Kaur Chawla <amitoj1606@gmail.com> Reviewed-by: Arnd Bergmann <arnd@arndb.de> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: lustre: obdclass: obd_mount: Declare function as staticAmitoj Kaur Chawla2016-02-201-1/+1
| | | | | | | | | | | | | Declare lustre_mount() function static since it is defined and called in this file only. This fixes the following sparse warning: drivers/staging/lustre/lustre/obdclass/obd_mount.c:1169:15: warning: symbol 'lustre_mount' was not declared. Should it be static? Signed-off-by: Amitoj Kaur Chawla <amitoj1606@gmail.com> Reviewed-by: Arnd Bergmann <arnd@arndb.de> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: lustre: Fixed the parenthesisShalin Mehta2016-02-201-2/+2
| | | | | | | | | The parentehsis are fixed in the macro for the ldlm lock to set and clear the flags. Signed-off-by: Shalin Mehta <shalinmehta85@gmail.com> Acked-by: Oleg Drokin <oleg.drokin@intel.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging/lustre: Convert cfs_str2num_check to use kstrtoulOleg Drokin2016-02-201-8/+3
| | | | | | | simple_strtoul is obsolete Signed-off-by: Oleg Drokin <green@linuxhacker.ru> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging/lustre: Convert cfs_trace_daemon_command to use kstrtoulOleg Drokin2016-02-201-6/+9
| | | | | | | simple_strtoul is obsolete Signed-off-by: Oleg Drokin <green@linuxhacker.ru> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging/lustre: Remove space after cast in cfs_crypto_hash_final()Oleg Drokin2016-02-201-1/+1
| | | | | | | This is against kernel-code style. Signed-off-by: Oleg Drokin <green@linuxhacker.ru> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging/lustre/libcfs: Get rid of multiple assignmentsOleg Drokin2016-02-202-5/+8
| | | | | | | | They make checkpatch unhappy, and I guess overall might confuse people too. Signed-off-by: Oleg Drokin <green@linuxhacker.ru> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging/lustre: Get rid of cfs_trace_buf_type_t typedefOleg Drokin2016-02-202-4/+4
| | | | | | | Replace it with enum cfs_trace_buf_type Signed-off-by: Oleg Drokin <green@linuxhacker.ru> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging/lustre: Update cfs_cpu_notify switch statement with a commentOleg Drokin2016-02-201-0/+1
| | | | | | | | We do really mean to fall through to that default case statement from all previous ones, so add a comment to unconfuse verious tools Signed-off-by: Oleg Drokin <green@linuxhacker.ru> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging/lustre/libcfs: Remove empty lines after/before bracesOleg Drokin2016-02-204-8/+0
| | | | | | | | | No need for an empty line after opening curvy brace and no need for an empty line before the closing one too. Remove them. Signed-off-by: Oleg Drokin <green@linuxhacker.ru> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging/lustre/libcfs: Remove useless returns in void functionsOleg Drokin2016-02-204-9/+0
| | | | | | | | Return at the end of a void function does not serve any particular purpose and makes checkpatch unhappy, so eliminate them. Signed-off-by: Oleg Drokin <green@linuxhacker.ru> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging/lustre/libcfs: Update comments style to match kernelOleg Drokin2016-02-2012-40/+65
| | | | | | | | checkpatch complains that the trailing */ on the multiline comments should be on it's own line. Signed-off-by: Oleg Drokin <green@linuxhacker.ru> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging/lustre/libcfs: Move private tracefile structs out of headerOleg Drokin2016-02-202-51/+45
| | | | | | | | | the struct page_collection, struct cfs_trace_page and struct tracefiled_ctl are only used by tracefile.c, so move them there. Signed-off-by: Oleg Drokin <green@linuxhacker.ru> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging/lustre/libcfs: Remove unused cfs_tcd_owns_tage() functionOleg Drokin2016-02-202-13/+0
| | | | | | | Does not appear to be used anywhere. Signed-off-by: Oleg Drokin <green@linuxhacker.ru> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging/lustre/libcfs: Shortened too long linesOleg Drokin2016-02-203-6/+9
| | | | | | | | Lines that were too long for not good reason were shortened in this patch. Found with checkpatch. Signed-off-by: Oleg Drokin <green@linuxhacker.ru> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging/lustre/libcfs: Remove stray spaces after function nameOleg Drokin2016-02-204-9/+7
| | | | | | | Problem highlighted by checkpatch. Signed-off-by: Oleg Drokin <green@linuxhacker.ru> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging/lustre/libcfs: reformat cfs_tcd_for_each_type_lock defineOleg Drokin2016-02-201-3/+3
| | | | | | | Avoid using leading spaces that make checkpatch unhappy. Signed-off-by: Oleg Drokin <green@linuxhacker.ru> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging/lustre/libcfs: style change to add missing spaces for operationsOleg Drokin2016-02-204-6/+7
| | | | | | | | This fixes checkpatch messages about "spaces preferred around that '-' (ctx:VxV)" Signed-off-by: Oleg Drokin <green@linuxhacker.ru> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging/lustre/libcfs: Move EXPORT_SYMBOLs under function/variableOleg Drokin2016-02-204-10/+7
| | | | | | | Found with checkpatch Signed-off-by: Oleg Drokin <green@linuxhacker.ru> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging/lustre/libcfs: Cleanup: parenthesis alignment adjustmentsOleg Drokin2016-02-208-45/+36
| | | | | | | | | Adjust alignment of argments that were pushed to next lines to conform to kernel code style. Found with checkpatch. Signed-off-by: Oleg Drokin <green@linuxhacker.ru> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging/lustre: Remove the "write to FSF to get a copy of GPL" wordingOleg Drokin2016-02-2014-57/+0
| | | | | | | | Checkpatch highlighted that some of our Lustre files carry this extra paragraph and indeed it does seem somewhat redundant, so remove it. Signed-off-by: Oleg Drokin <green@linuxhacker.ru> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging/lustre/ptlrpc: Adjust NULL comparison codestyleOleg Drokin2016-02-2022-276/+244
| | | | | | | | | | All instances of "x == NULL" are changed to "!x" and "x != NULL" to "x" Also remove some redundant assertions. Signed-off-by: Oleg Drokin <green@linuxhacker.ru> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging/lustre/osc: Adjust NULL comparison codestyleOleg Drokin2016-02-2010-197/+189
| | | | | | | | | | All instances of "x == NULL" are changed to "!x" and "x != NULL" to "x" Also remove some redundant assertions. Signed-off-by: Oleg Drokin <green@linuxhacker.ru> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging/lustre/obdecho: Adjust NULL comparison codestyleOleg Drokin2016-02-201-32/+29
| | | | | | | | | | All instances of "x == NULL" are changed to "!x" and "x != NULL" to "x" Also remove some redundant assertions. Signed-off-by: Oleg Drokin <green@linuxhacker.ru> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging/lustre/obdclass: Adjust NULL comparison codestyleOleg Drokin2016-02-2018-294/+267
| | | | | | | | | | All instances of "x == NULL" are changed to "!x" and "x != NULL" to "x" Also remove some redundant assertions. Signed-off-by: Oleg Drokin <green@linuxhacker.ru> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging/lustre/mgc: Adjust NULL comparison codestyleOleg Drokin2016-02-201-21/+20
| | | | | | | | | | All instances of "x == NULL" are changed to "!x" and "x != NULL" to "x" Also remove some redundant assertions. Signed-off-by: Oleg Drokin <green@linuxhacker.ru> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging/lustre/mdc: Adjust NULL comparison codestyleOleg Drokin2016-02-204-109/+90
| | | | | | | | | | All instances of "x == NULL" are changed to "!x" and "x != NULL" to "x" Also remove some redundant assertions. Signed-off-by: Oleg Drokin <green@linuxhacker.ru> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging/lustre/include: Adjust NULL comparison codestyleOleg Drokin2016-02-2016-94/+72
| | | | | | | | | | All instances of "x == NULL" are changed to "!x" and "x != NULL" to "x" Also remove some redundant assertions. Signed-off-by: Oleg Drokin <green@linuxhacker.ru> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging/lustre/lclient: Adjust NULL comparison codestyleOleg Drokin2016-02-201-16/+16
| | | | | | | | All instances of "x == NULL" are changed to "!x" and "x != NULL" to "x" Signed-off-by: Oleg Drokin <green@linuxhacker.ru> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging/lustre/fld: Adjust NULL comparison codestyleOleg Drokin2016-02-204-33/+22
| | | | | | | | All instances of "x == NULL" are changed to "!x" and "x != NULL" to "x" Signed-off-by: Oleg Drokin <green@linuxhacker.ru> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging/lustre/fid: Adjust NULL comparison codestyleOleg Drokin2016-02-202-19/+9
| | | | | | | | All instances of "x == NULL" are changed to "!x" and "x != NULL" to "x" Signed-off-by: Oleg Drokin <green@linuxhacker.ru> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging/lustre/lmv: Adjust NULL comparison codestyleOleg Drokin2016-02-204-75/+61
| | | | | | | | | | All instances of "x == NULL" are changed to "!x" and "x != NULL" to "x" Also remove some redundant assertions. Signed-off-by: Oleg Drokin <green@linuxhacker.ru> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging/lustre/ldlm: Adjust NULL comparison codestyleOleg Drokin2016-02-209-134/+123
| | | | | | | | | | All instances of "x == NULL" are changed to "!x" and "x != NULL" to "x" Also remove some redundant assertions. Signed-off-by: Oleg Drokin <green@linuxhacker.ru> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging/lustre/llite: Adjust NULL comparison codestyleOleg Drokin2016-02-2022-297/+241
| | | | | | | | | | | | | | | All instances of "x == NULL" are changed to "!x" and "x != NULL" to "x" The only exception is ll_update_inode where dropping != NULL in the construction below would break the logic. I guess we could change lsm != NULL to !!lsm, but that's uglier. (lsm != NULL) == ((body->valid & OBD_MD_FLEASIZE) != 0) Also removed some redundant assertions. Signed-off-by: Oleg Drokin <green@linuxhacker.ru> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging/lustre/lov: Adjust NULL comparison codestyleOleg Drokin2016-02-2017-173/+152
| | | | | | | | | All instances of "x == NULL" are changed to "!x" and "x != NULL" to "x" Also removed some redundant assertions. Signed-off-by: Oleg Drokin <green@linuxhacker.ru> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging/lustre/libcfs: Adjust NULL comparison codestyleOleg Drokin2016-02-2015-157/+143
| | | | | | | | | All instances of "x == NULL" are changed to "!x" and "x != NULL" to "x" Also removed some redundant assertions. Signed-off-by: Oleg Drokin <green@linuxhacker.ru> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging/lustre/osc: Remove commented out osc_page_protected()Oleg Drokin2016-02-201-99/+0
| | | | | | | | | The complicated version of osc_page_protected and osc_page_is_dlocked are unsafe and were commented out for ages, so probably no point in carrying them on. Signed-off-by: Oleg Drokin <green@linuxhacker.ru> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging/lustre: Remove commented out lock_lock_multi_matchOleg Drokin2016-02-201-39/+0
| | | | | | | | lock_lock_multi_match stayed commented out unused for ages now, so let's just remove it. Signed-off-by: Oleg Drokin <green@linuxhacker.ru> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging/lustre: Remove server code from class_get_type()Oleg Drokin2016-02-201-9/+0
| | | | | | | | class_get_type has some references to various server modules that could not exist on the server, so get rid of them. Signed-off-by: Oleg Drokin <green@linuxhacker.ru> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging/lustre: Remove server code from client_obd_setup()Oleg Drokin2016-02-201-16/+0
| | | | | | | | In client_obd_setup references to LUSTRE_OSP_NAME could only happen on metadata servers, so remove them as never true Signed-off-by: Oleg Drokin <green@linuxhacker.ru> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging/lustre: Remove unused osc_on_mdt functionOleg Drokin2016-02-202-28/+1
| | | | | | | | | This only makes sense on metadata server, so get rid of it. Also remove now unused MDS_OSC_MAX_RIF_DEFAULT define Signed-off-by: Oleg Drokin <green@linuxhacker.ru> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging/lustre: Remove unused function oti_initOleg Drokin2016-02-201-28/+0
| | | | | | | All the users seems to have disappeared. Signed-off-by: Oleg Drokin <green@linuxhacker.ru> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging/lustre/lov: Get rid of /proc references in commentsOleg Drokin2016-02-201-2/+2
| | | | | | | | Now that the sysfs conversion is complete, also convert all the remaining comments Signed-off-by: Oleg Drokin <green@linuxhacker.ru> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging/lustre/llite: Get rid of /proc references in commentsOleg Drokin2016-02-202-2/+2
| | | | | | | | Now that the sysfs conversion is complete, also convert all the remaining comments Signed-off-by: Oleg Drokin <green@linuxhacker.ru> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging/lustre/libcfs: Get rid of /proc references in commentsOleg Drokin2016-02-203-9/+6
| | | | | | | | Now that the sysfs conversion is complete, also convert all the remaining comments Signed-off-by: Oleg Drokin <green@linuxhacker.ru> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging/lustre/obdclass: Get rid of /proc references in comments.Oleg Drokin2016-02-205-11/+12
| | | | | | | | Now that the sysfs conversion is complete, also convert all the remaining comments Signed-off-by: Oleg Drokin <green@linuxhacker.ru> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging/lustre/ptlrpc: Get rid of /proc references in commentsOleg Drokin2016-02-204-4/+4
| | | | | | | | Now that the sysfs conversion is complete, also convert all the remaining comments Signed-off-by: Oleg Drokin <green@linuxhacker.ru> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: lustre: DLC Feature dynamic net configAmir Shehata2016-02-203-292/+518
| | | | | | | | | | | | | | | | | | | | | | | | | This is the third patch of a set of patches that enables DLC. This patch adds the following features to LNET. Currently these features are not driven by user space. - Adding/Deleting Networks dynamically Two new functions were added: - lnet_dyn_add_ni() add an NI. if the NI is already added then fail with appropriate error code - lnet_dyn_del_ni() delete an existing NI. If NI doesn't exist fail with appropriate failure code. These functions shall be called from IOCTL. Signed-off-by: Amir Shehata <amir.shehata@intel.com> Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-2456 Reviewed-on: http://review.whamcloud.com/9832 Reviewed-by: James Simmons <uja.ornl@gmail.com> Reviewed-by: Doug Oucharek <doug.s.oucharek@intel.com> Reviewed-by: Liang Zhen <liang.zhen@intel.com> Reviewed-by: Oleg Drokin <oleg.drokin@intel.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: lustre: Dynamic LNet Configuration (DLC) dynamic routingAmir Shehata2016-02-205-82/+304
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This is the second patch of a set of patches that enables DLC. This patch adds the following features to LNET. Currently these features are not driven by user space. - Enabling Routing on Demand. The default number of router buffers are allocated. - Disable Routing on demand. Unused router buffers are freed and used router buffers are freed when they are no longer in use. The following time routing is enabled the default router buffer values are used. It has been decided that remembering the user set router buffer values should be remembered and re-set by user space scripts. - Increase the number of router buffers on demand, by allocating new ones. - Decrease the number of router buffers. Exccess buffers are freed if they are not in use. Otherwise they are freed once they are no longer in use. Signed-off-by: Amir Shehata <amir.shehata@intel.com> Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-2456 Change-Id: Id07d4ad424d8f5ba72475d4149380afe2ac54e77 Reviewed-on: http://review.whamcloud.com/9831 Reviewed-by: James Simmons <uja.ornl@gmail.com> Reviewed-by: Doug Oucharek <doug.s.oucharek@intel.com> Reviewed-by: Liang Zhen <liang.zhen@intel.com> Reviewed-by: Oleg Drokin <oleg.drokin@intel.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
OpenPOWER on IntegriCloud