summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
...
* staging: unisys: fix spaces after cast visorchipset.cErik Arfvidson2016-02-111-3/+3
| | | | | | | | This patch fixes checkpatch's no space is necessary after a cast Signed-off-by: Erik Arfvidson <erik.arfvidson@unisys.com> Signed-off-by: Benjamin Romer <benjamin.romer@unisys.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: unisys: fix blank lines in visorchipset.cErik Arfvidson2016-02-111-2/+1
| | | | | | | | | | this patch removes the following checkpatch warnings: please use a blank line after … Please don’t use multiple blank lines Signed-off-by: Erik Arfvidson <erik.arfvidson@unisys.com> Signed-off-by: Benjamin Romer <benjamin.romer@unisys.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: unisys: fix comparison to NULL in visorchipset.cErik Arfvidson2016-02-111-7/+7
| | | | | | | | | This patch fixes the following type of check patch warnings: Comparison to NULL could be written Signed-off-by: Erik Arfvidson <erik.arfvidson@unisys.com> Signed-off-by: Benjamin Romer <benjamin.romer@unisys.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: unisys: fix spacing in visorchipset.cErik Arfvidson2016-02-111-3/+2
| | | | | | | | | This patch fixes the following checkpatch warning: spaces preferred around that ‘*’ or ‘|’ Signed-off-by: Erik Arfvidson <erik.arfvidson@unisys.com> Signed-off-by: Benjamin Romer <benjamin.romer@unisys.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: unisys: fix comments in visorchipsetErik Arfvidson2016-02-111-6/+10
| | | | | | | | | This patch fixes all the Block comments by using a trailing */ on a separate line Signed-off-by: Erik Arfvidson <erik.arfvidson@unisys.com> Signed-off-by: Benjamin Romer <benjamin.romer@unisys.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: unisys: fix trailing comment in vbusdeviceinfo.hErik Arfvidson2016-02-111-1/+2
| | | | | | | | Fixes checkpatch trailing */ comment in vbusdeviceinfo.h Signed-off-by: Erik Arfvidson <erik.arfvidson@unisys.com> Signed-off-by: Benjamin Romer <benjamin.romer@unisys.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: unisys: Fix NULL comparison vbusdeviceinfo.hErik Arfvidson2016-02-111-2/+2
| | | | | | | | This patches resolves the NULL comparison checkpatch warnings Signed-off-by: Erik Arfvidson <erik.arfvidson@unisys.com> Signed-off-by: Benjamin Romer <benjamin.romer@unisys.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: unisys: fix comments for controlvmchannel.hErik Arfvidson2016-02-111-118/+119
| | | | | | | | | This patch simply fixes all trailing */ by modifying the comments structures while trying to reduce the total number of lines Signed-off-by: Erik Arfvidson <erik.arfvidson@unisys.com> Signed-off-by: Benjamin Romer <benjamin.romer@unisys.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: unisys: Fix guestlinuxdebug.h commentsErik Arfvidson2016-02-111-6/+7
| | | | | | | | This patch simply cleans up all checkpatch comment issues Signed-off-by: Erik Arfvidson <erik.arfvidson@unisys.com> Signed-off-by: Benjamin Romer <benjamin.romer@unisys.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: iio: Remove parentheses on the right hand side of assignmentJanani Ravichandran2016-02-112-4/+4
| | | | | | | | | | | | | | | | | | | | Remove parentheses on the right hand side of assignment as they are not needed. Semantic patch used: @@ expression a, b, c, d; @@ ( a = (c == d) | a = - ( b - ) ) Signed-off-by: Janani Ravichandran <janani.rvchndrn@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: rtl8*: fix my email address upGreg Kroah-Hartman2016-02-112-2/+2
| | | | | | | | For some reason I had an old linux.com address in these TODO files, point to my linuxfoundation.org address as that works properly here. Reported-by: Luca Ceresoli <luca@lucaceresoli.net> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: wilc1000: spelling correctionsRoger H. Newell2016-02-111-3/+3
| | | | | | | This patch fixes spelling warnings generated by checkpatch.pl Signed-off-by: Roger H. Newell <newell.roger@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: wilc1000: Remove unneeded parentheses in assignmentJanani Ravichandran2016-02-111-1/+1
| | | | | | | | | | | | | | | | | | | | | | Remove parentheses around the right hand side of assignments. They are unnecessary. Semantic patch: @@ expression a, b, c; @@ ( a = (b == c) | a = - ( b - ) ) Signed-off-by: Janani Ravichandran <janani.rvchndrn@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: wilc1000: remove parentheses on right hand side of assignmentAlison Schofield2016-02-111-2/+2
| | | | | | | | | | | | | | | | Remove the unnecessary parens on right hand side of assignment. Found using Coccinelle: @@ identifier x; expression e1, e2; @@ - x = (e1 << e2) + x = e1 << e2 Signed-off-by: Alison Schofield <amsfield22@gmail.com> Acked-by: Julia Lawall <julia.lawall@lip6.fr> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: wilc1000: rename counter in wilc_send_config_pktChaehyun Lim2016-02-111-16/+15
| | | | | | | | | This patch renames the name of counter variable to i. This change makes more readability because wilc_send_config_pkt has a similar argument name as count. Signed-off-by: Chaehyun Lim <chaehyun.lim@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: wilc1000: remove initialization code of counter variableChaehyun Lim2016-02-111-1/+0
| | | | | | | | | There is no need to set to 0 for counter variable before entering next for-loop statement because counter is initialized again in for-loop statement, so just remove it. Signed-off-by: Chaehyun Lim <chaehyun.lim@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: wilc1000: use int type for counter variableChaehyun Lim2016-02-111-1/+1
| | | | | | | | | | counter is used as for-loop control variable and indicating index of struct wid array so that it is better to use int type. There is no need to set to 0 when it is declared at the top of this function. It is initialized as 0 in for-loop statement. Signed-off-by: Chaehyun Lim <chaehyun.lim@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: wilc1000: fix return type of wilc_send_config_pktChaehyun Lim2016-02-112-3/+4
| | | | | | | | | wilc_send_config_pkt is returned 0 or -ETIMEDOUT according to return value of wilc_wlan_cfg_set or wilc_wlan_cfg_set. It is better to use int type to represent linux standard error code. Signed-off-by: Chaehyun Lim <chaehyun.lim@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: wilc1000: fix mgmt_tx()Dan Carpenter2016-02-111-2/+3
| | | | | | | | | There was a missing curly brace so this function returns failure instead of succeeding. Fixes: 06fb9336acdc ('staging: wilc1000: wilc_wfi_cfgoperations.c: replaces PRINT_ER with netdev_err') Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging/lustre: Remove unused LUSTRE_VERSION_ALLOWED_OFFSET defineOleg Drokin2016-02-111-6/+3
| | | | | | | | LUSTRE_VERSION_ALLOWED_OFFSET is only used on the server to disallow connection of old userspace clients. Signed-off-by: Oleg Drokin <green@linuxhacker.ru> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging/lustre: Update internal client version.Oleg Drokin2016-02-111-6/+3
| | | | | | | | | | | | While initial code drop was corresponding to 2.3.64, lots of different changes went in since then, and also quite a bunch of fixes, but almost none of the new features. Code-wise we are almost at 2.5.0, so let's call it 2.4.60 - this is a version that was never reached in the actual pre-2.5 development, so it should be a clear distinction of where we are now. Signed-off-by: Oleg Drokin <green@linuxhacker.ru> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging/lustre: Adjust import state history output formatOleg Drokin2016-02-111-7/+7
| | | | | | | | New test scripts expect spaces around state names and square brackets when parsing debugfs output, so add them to avoid false failures. Signed-off-by: Oleg Drokin <green@linuxhacker.ru> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging/lustre/obdecho: Better handle invalid create requestsOleg Drokin2016-02-111-7/+4
| | | | | | | | When gettng an invalid create request in echo code (wrong group, or no group at all), just return an error instead of crashing. Signed-off-by: Oleg Drokin <green@linuxhacker.ru> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging/lustre/obdecho: Remove always true conditionOleg Drokin2016-02-111-4/+2
| | | | | | | | | | | Dan Carpenter noticed that since we already checked for (oa->o_valid & OBD_MD_FLID) == 0, that means (oa->o_valid & OBD_MD_FLID) is always true after that so no point in checking for it. Signed-off-by: Oleg Drokin <green@linuxhacker.ru> Reported-by: Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: lustre: Modify arguments of sizeof() to pointer variablesJanani Ravichandran2016-02-111-7/+7
| | | | | | | | | | | Take the size of a dereference to a variable rather than the associated type, to make the code more resistant to type changes in the future. The type of the pointer variable here is the same as the type in the argument that is being replaced in sizeof(). Signed-off-by: Janani Ravichandran <janani.rvchndrn@gmail.com> Acked-by: Julia Lawall <julia.lawall@lip6.fr> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: lustre: lov_pool: Fixed a return coding style warning.Rakhi Sharma2016-02-111-1/+0
| | | | | | | | | | | Remove unusefull return at the end of void function. WARNING: void function return statements are not generally useful. Signed-off-by: Rakhi Sharma <rakhish1994@gmail.com> Changes in v3: shortened the subject line and make the discription more clear. Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* Staging: lustre: lnet: Remove explicit NULL comparisionBhumika Goyal2016-02-111-6/+6
| | | | | | | | | | | | | | | Replaced explicit NULL comparision with its simplier form. Found using coccinelle: @replace_rule@ expression e; @@ -e == NULL + !e Signed-off-by: Bhumika Goyal <bhumirks@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* misc: panel, convert struct to bitmapDaniel Chromik2016-02-111-47/+40
| | | | | | | | | | | | | | | | | There is an anonymous struct which is actually used as a bitmap. So convert the struct to a bitmap and change code accordingly where needed. This also allows for a cleanup of set_data_bits and set_ctrl_bits as they can use a common helper now. The helper can also be converted to a for loop instead of doing bit OR. And given it is a for loop now, bit masking (using BIT_MSK) is moved from the callers there too. Signed-off-by: Daniel Chromik <daniel.chromik@seznam.cz> Signed-off-by: Jiri Slaby <jslaby@suse.cz> Cc: Ksenija Stanojevic <ksenija.stanojevic@gmail.com> Acked-by: Willy Tarreau <willy@haproxy.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: iio: Remove parantheses around right hand side of assignmentJanani Ravichandran2016-02-092-5/+5
| | | | | | | | | | | | | | | | | | | | Remove parantheses on the right hand side of assignments as they are not needed. Coccinelle patch used: @@ expression a, b, c, d; @@ ( a = (c == d) | a = - ( b - ) ) Signed-off-by: Janani Ravichandran <janani.rvchndrn@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: nvec: Remove unneeded commentJanani Ravichandran2016-02-091-2/+0
| | | | | | | Remove this comment as it does not have a meaning here. Signed-off-by: Janani Ravichandran <janani.rvchndrn@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: goldfish: Change form of NULL comparisonsJanani Ravichandran2016-02-091-3/+3
| | | | | | | | Change null comparisons of the form x == NULL to !x. This was suggested by checkpatch. Signed-off-by: Janani Ravichandran <janani.rvchndrn@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: rdma: Use kcalloc instead of kzallocJanani Ravichandran2016-02-091-2/+1
| | | | | | | | Use kcalloc rather than kzalloc when multiplied by size to prevent integer overflows. This change also makes code nicer to read. Signed-off-by: Janani Ravichandran <janani.rvchndrn@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* Staging: rts5208: remove unnecessary paranthesesHaneen Mohammed2016-02-091-1/+1
| | | | | | | | This patch removes unnecessary parantheses around rtsx->pci->dev. Signed-off-by: Haneen Mohammed <hamohammed.sa@gmail.com> Acked-by: Julia Lawall <julia.lawall@lip6.fr> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* Staging: rts5208: fix check for dma mapping errorHaneen Mohammed2016-02-091-1/+1
| | | | | | | | | use dma_mapping_error() instead of comparing the returned address with zero after dma_map_single(). Signed-off-by: Haneen Mohammed <hamohammed.sa@gmail.com> Acked-by: Julia Lawall <julia.lawall@lip6.fr> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* Staging:wlan-ng:Merged two lines into oneBhumika Goyal2016-02-091-16/+4
| | | | | | | | | | | | | | | | | The last two lines of these functions are compressed into one. Also removed the variable ret as it is now not used. Found using coccinelle: @@ expression e, ret; @@ -ret = +return e; -return ret; Signed-off-by: Bhumika Goyal <bhumirks@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: emxx_udc: Alligned to match '('Anjali Menon2016-02-071-20/+18
| | | | | | | | | | Allignment matched to the open parenthesis to avoid the check detected by the checkpatch.pl. CHECK: Alignment should match open parenthesis Signed-off-by: Anjali Menon <cse.anjalimenon@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: r8192U: Fix check pointer after usage problemLarry Finger2016-02-071-8/+13
| | | | | | | | | | | | | In routine rtl8192_tx_isr(), pointer skb is dereferenced before it is checked for NULL. This patch has only been compile-tested, as I do not have the hardware. This problem was reported at https://bugzilla.kernel.org/show_bug.cgi?id=109951. Fixes: bugzilla.kernel.org: #109951 Reported-by: Yong Shi <brave_shi@163.com> Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net> Cc: Yong Shi <brave_shi@163.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: lusture: obdclass: Remove return statement in void functionBhaktipriya Shridhar2016-02-071-1/+0
| | | | | | | | Fix the following checkpatch.pl warning: WARNING: void function return statements are not generally useful Signed-off-by: Bhaktipriya Shridhar <bhaktipriya96@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* drivers: staging: xgifb: vgatypes.h: fixed coding style warningsSaatvik Arya2016-02-071-3/+4
| | | | | | | fixed warnings about comment block coding style Signed-off-by: Saatvik Arya <aryasaatvik@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: xgifb: Don't use multiple blank linesBenoit Hiller2016-02-071-2/+0
| | | | | | | | Remove multiple blank lines. Problem found using checkpatch.pl "CHECK: Please don't use multiple blank lines" Signed-off-by: Benoit Hiller <benoit.hiller@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: mt29f: clean up existing kernel-docManuel Pégourié-Gonnard2016-02-071-31/+31
| | | | | | | | | | | | | | | The existing kerneldoc blocs had a few issues: - some of them didn't start with /** - some used -- instead of - to separate the short description - some descriptions had text looking like section headers - some descriptions started with "to" while some used the imperative: use the imperative everywhere - some had a "with:" at the end of the shortdesc that didn't make sense once formatted by kernel-docs - two argument names where out of sync with the prototype Signed-off-by: Manuel Pégourié-Gonnard <mpg@elzevir.fr> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: mt29f: fix usage of coma operatorManuel Pégourié-Gonnard2016-02-071-5/+5
| | | | | | | | Using the coma operator for multiple assignments is unnecessary and just looks weird here. Signed-off-by: Manuel Pégourié-Gonnard <mpg@elzevir.fr> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: mt29f: fix unchecked malloc()Manuel Pégourié-Gonnard2016-02-071-1/+4
| | | | | | | | The pointer is unconditionally dereferenced a few lines later, we need to make sure it isn't NULL. Signed-off-by: Manuel Pégourié-Gonnard <mpg@elzevir.fr> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* Staging: gdm72xx: Prefer using the BIT macroShraddha Barke2016-02-072-6/+6
| | | | | | | Replace bit shifting on 1 with the BIT(x) macro Signed-off-by: Shraddha Barke <shraddha.6596@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* Staging: gdm72xx: Remove multiple blank linesShraddha Barke2016-02-072-2/+0
| | | | | | | | Remove extra blank line which is not necessary. Warning detected using checkpatch. Signed-off-by: Shraddha Barke <shraddha.6596@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* Staging: gdm72xx: Remove space after castShraddha Barke2016-02-071-1/+1
| | | | | | | Fix the checkpatch warning "No space is necessary after cast" Signed-off-by: Shraddha Barke <shraddha.6596@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* Staging: gdm72xx: Add appropriate comment for spinlock_t definitionShraddha Barke2016-02-075-7/+7
| | | | | | | Fix checkpatch issue: "CHECK: spinlock_t definition without comment". Signed-off-by: Shraddha Barke <shraddha.6596@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* Staging: gdm72xx: Add space around that "+", "&" and "|"Shraddha Barke2016-02-071-32/+32
| | | | | | | | Add missing spaces around "+", "&" and "|" to follow kernel coding style. Warning detected by checkpatch. Signed-off-by: Shraddha Barke <shraddha.6596@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* Staging: gs_fpgaboot: fix data types in gs_fpgaboot.cBen Marsh2016-02-071-2/+2
| | | | | | | | This is a patch to gs_fpgaboot.c to convert data types to kernel types as identified by checkpatch.pl. Signed-off-by: Ben Marsh <bmarsh94@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* Staging: gs_fpgaboot: fix memory allocation in gs_fpgaboot.cBen Marsh2016-02-071-1/+1
| | | | | | | | This is a patch for gs_fpgaboot.c that fixes a memory allocation problem identified by checkpatch.pl. Signed-off-by: Ben Marsh <bmarsh94@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
OpenPOWER on IntegriCloud