diff options
Diffstat (limited to 'drivers/staging/vc04_services/interface/vchi')
| -rw-r--r-- | drivers/staging/vc04_services/interface/vchi/TODO | 21 | ||||
| -rw-r--r-- | drivers/staging/vc04_services/interface/vchi/vchi_cfg.h | 2 |
2 files changed, 4 insertions, 19 deletions
diff --git a/drivers/staging/vc04_services/interface/vchi/TODO b/drivers/staging/vc04_services/interface/vchi/TODO index 03aa651..df93154 100644 --- a/drivers/staging/vc04_services/interface/vchi/TODO +++ b/drivers/staging/vc04_services/interface/vchi/TODO @@ -1,24 +1,9 @@ -1) Port to aarch64 - -This driver won't be very useful unless we also have it working on -Raspberry Pi 3. This requires, at least: - - - Figure out an alternative to the dmac_map_area() hack. - - - Decide what to use instead of dsb(). - - - Do something about (int) cast of bulk->data in - vchiq_bulk_transfer(). - - bulk->data is a bus address going across to the firmware. We know - our bus addresses are <32bit. - -2) Write a DT binding doc and get the corresponding DT node merged to +1) Write a DT binding doc and get the corresponding DT node merged to bcm2835. This will let the driver probe when enabled. -3) Import drivers using VCHI. +2) Import drivers using VCHI. VCHI is just a tool to let drivers talk to the firmware. Here are some of the ones we want: @@ -41,7 +26,7 @@ some of the ones we want: to manage these buffers as dmabufs so that we can zero-copy import camera images into vc4 for rendering/display. -4) Garbage-collect unused code +3) Garbage-collect unused code One of the reasons this driver wasn't upstreamed previously was that there's a lot code that got built that's probably unnecessary these diff --git a/drivers/staging/vc04_services/interface/vchi/vchi_cfg.h b/drivers/staging/vc04_services/interface/vchi/vchi_cfg.h index 26bc2d3..b6f42b8 100644 --- a/drivers/staging/vc04_services/interface/vchi/vchi_cfg.h +++ b/drivers/staging/vc04_services/interface/vchi/vchi_cfg.h @@ -173,7 +173,7 @@ * under the carpet. */ #if VCHI_RX_MSG_QUEUE_SIZE < (VCHI_MAX_MSG_SIZE/16 + 1) * VCHI_NUM_READ_SLOTS # undef VCHI_RX_MSG_QUEUE_SIZE -# define VCHI_RX_MSG_QUEUE_SIZE (VCHI_MAX_MSG_SIZE/16 + 1) * VCHI_NUM_READ_SLOTS +# define VCHI_RX_MSG_QUEUE_SIZE ((VCHI_MAX_MSG_SIZE/16 + 1) * VCHI_NUM_READ_SLOTS) #endif /* How many bulk transmits can we have pending. Once exhausted, vchi_bulk_queue_transmit |
