summaryrefslogtreecommitdiffstats
path: root/virt
diff options
context:
space:
mode:
authorMichael S. Tsirkin <mst@redhat.com>2011-03-17 10:53:33 +0200
committerAvi Kivity <avi@redhat.com>2011-04-06 13:15:55 +0300
commit9e02fb963352c5ad075d80dd3e852fbee9585575 (patch)
treed88553e3c2bb6affac29b529ce618eed95b8e918 /virt
parent6221f222c0ebf1acdf7abcf927178f40e1a65e2a (diff)
downloadop-kernel-dev-9e02fb963352c5ad075d80dd3e852fbee9585575.zip
op-kernel-dev-9e02fb963352c5ad075d80dd3e852fbee9585575.tar.gz
KVM: fix crash on irqfd deassign
irqfd in kvm used flush_work incorrectly: it assumed that work scheduled previously can't run after flush_work, but since kvm uses a non-reentrant workqueue (by means of schedule_work) we need flush_work_sync to get that guarantee. Signed-off-by: Michael S. Tsirkin <mst@redhat.com> Reported-by: Jean-Philippe Menil <jean-philippe.menil@univ-nantes.fr> Tested-by: Jean-Philippe Menil <jean-philippe.menil@univ-nantes.fr> Signed-off-by: Avi Kivity <avi@redhat.com>
Diffstat (limited to 'virt')
-rw-r--r--virt/kvm/eventfd.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/virt/kvm/eventfd.c b/virt/kvm/eventfd.c
index 3656849..0d1fd51 100644
--- a/virt/kvm/eventfd.c
+++ b/virt/kvm/eventfd.c
@@ -90,7 +90,7 @@ irqfd_shutdown(struct work_struct *work)
* We know no new events will be scheduled at this point, so block
* until all previously outstanding events have completed
*/
- flush_work(&irqfd->inject);
+ flush_work_sync(&irqfd->inject);
/*
* It is now safe to release the object's resources
OpenPOWER on IntegriCloud