diff options
| author | Roopa Prabhu <roopa@cumulusnetworks.com> | 2014-05-01 11:40:30 -0700 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2014-05-05 13:11:36 -0400 |
| commit | 56bfa7ee7c8892f1aa61797e4b8fec84b31d29b3 (patch) | |
| tree | 658ae69210432c27c2c22a3cfc2397408eae9fe2 /virt/kvm/async_pf.c | |
| parent | f4a7b5eec2848400af7670b36ac17aea9e1ccc6f (diff) | |
| download | op-kernel-dev-56bfa7ee7c8892f1aa61797e4b8fec84b31d29b3.zip op-kernel-dev-56bfa7ee7c8892f1aa61797e4b8fec84b31d29b3.tar.gz | |
unregister_netdevice : move RTM_DELLINK to until after ndo_uninit
This patch fixes ordering of rtnl notifications during unregister_netdevice
by moving RTM_DELLINK notification to until after ndo_uninit.
The problem was seen with unregistering bond netdevices.
bond ndo_uninit callback generates a few RTM_NEWLINK notifications for
NETDEV_CHANGEADDR and NETDEV_FEAT_CHANGE. This is seen mostly when the
bond is deleted with slaves still enslaved to the bond.
During unregister netdevice (rollback_registered_many to be specific)
bond ndo_uninit is called after RTM_DELLINK notification goes out.
This results in userspace seeing RTM_DELLINK followed by a couple of
RTM_NEWLINK's.
In userspace problem was seen with libnl. libnl cache deletes the bond
when it sees RTM_DELLINK and re-adds the bond with the following
RTM_NEWLINK. Resulting in a stale bond entry in libnl cache when the kernel
has already deleted the bond.
This patch has been tested for bond, bridges and vlan devices.
Signed-off-by: Roopa Prabhu <roopa@cumulusnetworks.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'virt/kvm/async_pf.c')
0 files changed, 0 insertions, 0 deletions
