diff options
author | Jeff Layton <jlayton@redhat.com> | 2011-07-18 11:26:30 -0400 |
---|---|---|
committer | Trond Myklebust <Trond.Myklebust@netapp.com> | 2011-07-25 15:00:21 -0400 |
commit | 73ca1001ed6881b476e8252adcd0eede1ea368ea (patch) | |
tree | 41aca7b930405f1d50e552e22a272ece61835995 /usr | |
parent | 2773395b34883fe54418de188733a63bb38e0ad6 (diff) | |
download | op-kernel-dev-73ca1001ed6881b476e8252adcd0eede1ea368ea.zip op-kernel-dev-73ca1001ed6881b476e8252adcd0eede1ea368ea.tar.gz |
nfs: don't use d_move in nfs_async_rename_done
If the task that initiated the sillyrename ends up being killed by a
fatal signal, then it will eventually return back to userspace and end
up releasing the i_mutex. d_move however needs to be done while holding
the i_mutex.
Instead of using d_move here, just unhash the old and new dentries to
prevent them from being found by lookups. With this change though, the
dentries are now incorrect post-rename and do not reflect the actual
name of the file on the server. I'm proceeding under the assumption
that since they are unhashed that this isn't really a problem.
In order for the sillydelete to still work though, the dname must be
copied earlier when setting up the sillydelete info, and the name must
be recopied if the sillydelete info has to be moved to a new dentry.
Reported-by: Al Viro <viro@ZenIV.linux.org.uk>
Signed-off-by: Jeff Layton <jlayton@redhat.com>
Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>
Diffstat (limited to 'usr')
0 files changed, 0 insertions, 0 deletions