summaryrefslogtreecommitdiffstats
path: root/tools
diff options
context:
space:
mode:
authorBruce Merry <bmerry@ska.ac.za>2015-01-15 11:20:22 +0200
committerArnaldo Carvalho de Melo <acme@redhat.com>2015-02-22 23:10:56 -0300
commite17fdaeaec066c725f73cd3cda1feae52b2646f5 (patch)
tree6fcf188b779d1db89c2ff54f98584105ae30ac60 /tools
parent2a6730c8b6e075adf826a89a3e2caa705807afdb (diff)
downloadop-kernel-dev-e17fdaeaec066c725f73cd3cda1feae52b2646f5.zip
op-kernel-dev-e17fdaeaec066c725f73cd3cda1feae52b2646f5.tar.gz
perf bench: Fix order of arguments to memcpy_alloc_mem
This was causing the destination instead of the source to be filled. As a result, the source was typically all mapped to one zero page, and hence very cacheable. Signed-off-by: Bruce Merry <bmerry@ska.ac.za> Acked-by: Ingo Molnar <mingo@kernel.org> Cc: Paul Mackerras <paulus@samba.org> Cc: Peter Zijlstra <peterz@infradead.org> Link: http://lkml.kernel.org/r/20150115092022.GA11292@kryton Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Diffstat (limited to 'tools')
-rw-r--r--tools/perf/bench/mem-memcpy.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/tools/perf/bench/mem-memcpy.c b/tools/perf/bench/mem-memcpy.c
index 6c14afe..db1d3a2 100644
--- a/tools/perf/bench/mem-memcpy.c
+++ b/tools/perf/bench/mem-memcpy.c
@@ -289,7 +289,7 @@ static u64 do_memcpy_cycle(const struct routine *r, size_t len, bool prefault)
memcpy_t fn = r->fn.memcpy;
int i;
- memcpy_alloc_mem(&src, &dst, len);
+ memcpy_alloc_mem(&dst, &src, len);
if (prefault)
fn(dst, src, len);
@@ -312,7 +312,7 @@ static double do_memcpy_gettimeofday(const struct routine *r, size_t len,
void *src = NULL, *dst = NULL;
int i;
- memcpy_alloc_mem(&src, &dst, len);
+ memcpy_alloc_mem(&dst, &src, len);
if (prefault)
fn(dst, src, len);
OpenPOWER on IntegriCloud