summaryrefslogtreecommitdiffstats
path: root/tools/virtio
diff options
context:
space:
mode:
authorMark Rutland <mark.rutland@arm.com>2016-11-24 10:25:12 +0000
committerMichael S. Tsirkin <mst@redhat.com>2016-12-16 00:13:36 +0200
commit5da889c795b1fbefc9d8f058b54717ab8ab17891 (patch)
tree6fc38e34603ed1ad8e63de38725fc5d84b26507b /tools/virtio
parentdbaf0624ffa57ae6e7d87a823185ccd9a7852d3c (diff)
downloadop-kernel-dev-5da889c795b1fbefc9d8f058b54717ab8ab17891.zip
op-kernel-dev-5da889c795b1fbefc9d8f058b54717ab8ab17891.tar.gz
tools/virtio: fix READ_ONCE()
The virtio tools implementation of READ_ONCE() has a single parameter called 'var', but erroneously refers to 'val' for its cast, and thus won't work unless there's a variable of the correct type that happens to be called 'var'. Fix this with s/var/val/, making READ_ONCE() work as expected regardless. Fixes: a7c490333df3cff5 ("tools/virtio: use virt_xxx barriers") Signed-off-by: Mark Rutland <mark.rutland@arm.com> Cc: Jason Wang <jasowang@redhat.com> Cc: Michael S. Tsirkin <mst@redhat.com> Cc: linux-kernel@vger.kernel.org Cc: virtualization@lists.linux-foundation.org Signed-off-by: Michael S. Tsirkin <mst@redhat.com> Reviewed-by: Cornelia Huck <cornelia.huck@de.ibm.com> Reviewed-by: Jason Wang <jasowang@redhat.com>
Diffstat (limited to 'tools/virtio')
-rw-r--r--tools/virtio/linux/compiler.h2
1 files changed, 1 insertions, 1 deletions
diff --git a/tools/virtio/linux/compiler.h b/tools/virtio/linux/compiler.h
index 845960e..c9ccfd4 100644
--- a/tools/virtio/linux/compiler.h
+++ b/tools/virtio/linux/compiler.h
@@ -4,6 +4,6 @@
#define WRITE_ONCE(var, val) \
(*((volatile typeof(val) *)(&(var))) = (val))
-#define READ_ONCE(var) (*((volatile typeof(val) *)(&(var))))
+#define READ_ONCE(var) (*((volatile typeof(var) *)(&(var))))
#endif
OpenPOWER on IntegriCloud