diff options
| author | Steven Rostedt (Red Hat) <rostedt@goodmis.org> | 2013-01-30 12:28:15 -0500 |
|---|---|---|
| committer | Steven Rostedt <rostedt@goodmis.org> | 2013-01-30 12:28:15 -0500 |
| commit | 35275685bf6123529e67c1dc91b8c05e479124e8 (patch) | |
| tree | 06622dcbb6a7d47a7b6fd679cef45bf8a31c6f74 /tools/testing | |
| parent | 319ab14f051aeb04d6da20d82b389ad875083041 (diff) | |
| download | op-kernel-dev-35275685bf6123529e67c1dc91b8c05e479124e8.zip op-kernel-dev-35275685bf6123529e67c1dc91b8c05e479124e8.tar.gz | |
ktest: Strip off '\n' when reading which files were modified
The patchcheck test looks at what files are modified for each patch it
checks and makes sure that those files do not produce any warnings.
Unfortunately, when it read the diffstat, the newlines were added on the
files and this made compares miss warnings, and commits that should not
have passed, ktest let pass.
Fix this by using the perl command "chomp" that strips off whitespace at
the end of lines.
Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
Diffstat (limited to 'tools/testing')
| -rwxr-xr-x | tools/testing/ktest/ktest.pl | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/tools/testing/ktest/ktest.pl b/tools/testing/ktest/ktest.pl index d6690df..cc9925a 100755 --- a/tools/testing/ktest/ktest.pl +++ b/tools/testing/ktest/ktest.pl @@ -1925,6 +1925,10 @@ sub check_buildlog { my @files = `git show $patch | diffstat -l`; + foreach my $file (@files) { + chomp $file; + } + open(IN, "git show $patch |") or dodie "failed to show $patch"; while (<IN>) { |
