diff options
author | Nick Desaulniers <ndesaulniers@google.com> | 2017-08-11 11:16:07 -0700 |
---|---|---|
committer | Pablo Neira Ayuso <pablo@netfilter.org> | 2017-08-24 18:48:05 +0200 |
commit | eee6ebbac18a189ef33d25ea9b8bcae176515e49 (patch) | |
tree | c544b5e80d6bbbdc0e44c0043bcf05f14e346f28 /tools/scripts | |
parent | 6b5dc98e8fac041a3decfc3186e08c1c570ea691 (diff) | |
download | op-kernel-dev-eee6ebbac18a189ef33d25ea9b8bcae176515e49.zip op-kernel-dev-eee6ebbac18a189ef33d25ea9b8bcae176515e49.tar.gz |
netfilter: nf_nat_h323: fix logical-not-parentheses warning
Clang produces the following warning:
net/ipv4/netfilter/nf_nat_h323.c:553:6: error:
logical not is only applied to the left hand side of this comparison
[-Werror,-Wlogical-not-parentheses]
if (!set_h225_addr(skb, protoff, data, dataoff, taddr,
^
add parentheses after the '!' to evaluate the comparison first
add parentheses around left hand side expression to silence this warning
There's not necessarily a bug here, but it's cleaner to return early,
ex:
if (x)
return
...
rather than:
if (x == 0)
...
else
return
Also added a return code check that seemed to be missing in one
instance.
Signed-off-by: Nick Desaulniers <ndesaulniers@google.com>
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
Diffstat (limited to 'tools/scripts')
0 files changed, 0 insertions, 0 deletions