summaryrefslogtreecommitdiffstats
path: root/tools/power
diff options
context:
space:
mode:
authorJacob Tanenbaum <jtanenba@redhat.com>2015-12-01 17:14:17 +0100
committerRafael J. Wysocki <rafael.j.wysocki@intel.com>2015-12-03 02:30:30 +0100
commite98f033f94f385a9cf498d4e9f2ac1e6198b545a (patch)
treeb461a9ef90be234d203f29cf935a72d91064e5f1 /tools/power
parent562e5f1a352977f45d0d0ed3279b556d3e41e1ba (diff)
downloadop-kernel-dev-e98f033f94f385a9cf498d4e9f2ac1e6198b545a.zip
op-kernel-dev-e98f033f94f385a9cf498d4e9f2ac1e6198b545a.tar.gz
cpupower: fix how "cpupower frequency-info" interprets latency
the intel-pstate driver does not support the ondemand governor and does not have a valid value in /sys/devices/system/cpu/cpu[x]/cpufreq/cpuinfo_transition_latency. The intel-pstate driver sets cpuinfo_transition_latency to CPUFREQ_ETERNAL (-1), the value written into cpuinfo_transition_latency is defind as an unsigned int so checking the read value against max unsigned int will determine if the value is valid. Signed-off-by: Jacob Tanenbaum <jtanenba@redhat.com> Signed-off-by: Thomas Renninger <trenn@suse.com> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Diffstat (limited to 'tools/power')
-rw-r--r--tools/power/cpupower/utils/cpufreq-info.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/tools/power/cpupower/utils/cpufreq-info.c b/tools/power/cpupower/utils/cpufreq-info.c
index c13bc8c..8f3f5bb 100644
--- a/tools/power/cpupower/utils/cpufreq-info.c
+++ b/tools/power/cpupower/utils/cpufreq-info.c
@@ -434,8 +434,8 @@ static int get_latency(unsigned int cpu, unsigned int human)
unsigned long latency = cpufreq_get_transition_latency(cpu);
printf(_(" maximum transition latency: "));
- if (!latency) {
- printf(_(" Cannot determine latency.\n"));
+ if (!latency || latency == UINT_MAX) {
+ printf(_(" Cannot determine or is not supported.\n"));
return -EINVAL;
}
OpenPOWER on IntegriCloud