diff options
author | Adrian Hunter <adrian.hunter@intel.com> | 2015-11-06 15:59:29 +0200 |
---|---|---|
committer | Arnaldo Carvalho de Melo <acme@redhat.com> | 2015-11-12 18:58:17 -0300 |
commit | 866548dd6e22c3795ae5146a9746a5cf659698f1 (patch) | |
tree | 3c4be29fc56052163e715e909e8ae4e0d3ecc4a0 /tools/perf/ui/browsers/hists.c | |
parent | f6ba98c5dc78708cb7fd29950c4a50c4c7e88f95 (diff) | |
download | op-kernel-dev-866548dd6e22c3795ae5146a9746a5cf659698f1.zip op-kernel-dev-866548dd6e22c3795ae5146a9746a5cf659698f1.tar.gz |
perf symbols: Rebuild rbtree when adjusting symbols for kcore
Normally symbols are read from the DSO and adjusted, if need be, so that
the symbol start matches the file offset in the DSO file (we want the
file offset because that is what we know from MMAP events). That is done
by dso__load_sym() which inserts the symbols *after* adjusting them.
In the case of kcore, the symbols have been read from kallsyms and the
symbol start is the memory address. The symbols have to be adjusted to
match the kcore file offsets. dso__split_kallsyms_for_kcore() does that,
but now the adjustment is being done *after* the symbols have been
inserted. It appears dso__split_kallsyms_for_kcore() was assuming that
changing the symbol start would not change the order in the rbtree -
which is, of course, not guaranteed.
Signed-off-by: Adrian Hunter <adrian.hunter@intel.com>
Tested-by: Wang Nan <wangnan0@huawei.com>
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Zefan Li <lizefan@huawei.com>
Cc: pi3orama@163.com
Link: http://lkml.kernel.org/r/563CB241.2090701@intel.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Diffstat (limited to 'tools/perf/ui/browsers/hists.c')
0 files changed, 0 insertions, 0 deletions