diff options
author | Paul Mackerras <paulus@samba.org> | 2009-08-25 15:17:20 +1000 |
---|---|---|
committer | Ingo Molnar <mingo@elte.hu> | 2009-08-25 09:34:38 +0200 |
commit | fa289beca9de9119c7760bd984f3640da21bc94c (patch) | |
tree | bb952b339092ac18dd1057e1edc89ead56777a98 /tools/perf/builtin-top.c | |
parent | 96d6e48bc6b38342a59ccd23e25907d12caaeaf8 (diff) | |
download | op-kernel-dev-fa289beca9de9119c7760bd984f3640da21bc94c.zip op-kernel-dev-fa289beca9de9119c7760bd984f3640da21bc94c.tar.gz |
perf_counter: Start counting time enabled when group leader gets enabled
Currently, if a group is created where the group leader is
initially disabled but a non-leader member is initially
enabled, and then the leader is subsequently enabled some time
later, the time_enabled for the non-leader member will reflect
the whole time since it was created, not just the time since
the leader was enabled.
This is incorrect, because all of the members are effectively
disabled while the leader is disabled, since none of the
members can go on the PMU if the leader can't.
Thus we have to update the ->tstamp_enabled for all the enabled
group members when a group leader is enabled, so that the
time_enabled computation only counts the time since the leader
was enabled.
Similarly, when disabling a group leader we have to update the
time_enabled and time_running for all of the group members.
Also, in update_counter_times, we have to treat a counter whose
group leader is disabled as being disabled.
Reported-by: Stephane Eranian <eranian@googlemail.com>
Signed-off-by: Paul Mackerras <paulus@samba.org>
Acked-by: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: <stable@kernel.org>
LKML-Reference: <19091.29664.342227.445006@drongo.ozlabs.ibm.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
Diffstat (limited to 'tools/perf/builtin-top.c')
0 files changed, 0 insertions, 0 deletions