summaryrefslogtreecommitdiffstats
path: root/tools/perf/builtin-timechart.c
diff options
context:
space:
mode:
authorMartin Kepplinger <martink@posteo.de>2017-09-13 21:14:19 +0200
committerArnaldo Carvalho de Melo <acme@redhat.com>2017-09-18 09:40:21 -0300
commitc896f85a7c15ab9d040ffac8b8003e47996602a2 (patch)
treef65e995175ee475efdb93622228ba5425a8ec8c1 /tools/perf/builtin-timechart.c
parent333b566559019b146905c623bde7f455c1d5add3 (diff)
downloadop-kernel-dev-c896f85a7c15ab9d040ffac8b8003e47996602a2.zip
op-kernel-dev-c896f85a7c15ab9d040ffac8b8003e47996602a2.tar.gz
perf tools: Fix leaking rec_argv in error cases
Let's free the allocated rec_argv in case we return early, in order to avoid leaking memory. This adds free() at a few very similar places across the tree where it was missing. Signed-off-by: Martin Kepplinger <martink@posteo.de> Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com> Cc: Martin kepplinger <martink@posteo.de> Cc: Peter Zijlstra <peterz@infradead.org> Link: http://lkml.kernel.org/r/20170913191419.29806-1-martink@posteo.de Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Diffstat (limited to 'tools/perf/builtin-timechart.c')
-rw-r--r--tools/perf/builtin-timechart.c4
1 files changed, 3 insertions, 1 deletions
diff --git a/tools/perf/builtin-timechart.c b/tools/perf/builtin-timechart.c
index 4e2e616..01de01c 100644
--- a/tools/perf/builtin-timechart.c
+++ b/tools/perf/builtin-timechart.c
@@ -1732,8 +1732,10 @@ static int timechart__io_record(int argc, const char **argv)
if (rec_argv == NULL)
return -ENOMEM;
- if (asprintf(&filter, "common_pid != %d", getpid()) < 0)
+ if (asprintf(&filter, "common_pid != %d", getpid()) < 0) {
+ free(rec_argv);
return -ENOMEM;
+ }
p = rec_argv;
for (i = 0; i < common_args_nr; i++)
OpenPOWER on IntegriCloud