diff options
author | Arnaldo Carvalho de Melo <acme@redhat.com> | 2016-10-03 11:07:24 -0300 |
---|---|---|
committer | Arnaldo Carvalho de Melo <acme@redhat.com> | 2016-10-03 11:24:13 -0300 |
commit | 18ef15c675a5d5d97f844ebcf340a2a6c7cf3142 (patch) | |
tree | 08616a05632dbbea3281e040069f5cbdca9878d8 /tools/build/Makefile.build | |
parent | ead1a57457c0324a167f3f9e3a70e26c2d75fb12 (diff) | |
download | op-kernel-dev-18ef15c675a5d5d97f844ebcf340a2a6c7cf3142.zip op-kernel-dev-18ef15c675a5d5d97f844ebcf340a2a6c7cf3142.tar.gz |
perf tools: Experiment with cppcheck
Experimenting a bit using cppcheck[1], a static checker brought to my
attention by Colin, reducing the scope of some variables, reducing the
line of source code lines in the process:
$ cppcheck --enable=style tools/perf/util/thread.c
Checking tools/perf/util/thread.c...
[tools/perf/util/thread.c:17]: (style) The scope of the variable 'leader' can be reduced.
[tools/perf/util/thread.c:133]: (style) The scope of the variable 'err' can be reduced.
[tools/perf/util/thread.c:273]: (style) The scope of the variable 'err' can be reduced.
Will continue later, but these are already useful, keep them.
1: https://sourceforge.net/p/cppcheck/wiki/Home/
Cc: Adrian Hunter <adrian.hunter@intel.com>
Cc: Colin Ian King <colin.king@canonical.com>
Cc: David Ahern <dsahern@gmail.com>
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Wang Nan <wangnan0@huawei.com>
Link: http://lkml.kernel.org/n/tip-ixws7lbycihhpmq9cc949ti6@git.kernel.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Diffstat (limited to 'tools/build/Makefile.build')
0 files changed, 0 insertions, 0 deletions