summaryrefslogtreecommitdiffstats
path: root/sound
diff options
context:
space:
mode:
authorSudip Mukherjee <sudipm.mukherjee@gmail.com>2016-01-21 17:27:59 +0530
committerMark Brown <broonie@kernel.org>2016-01-22 16:42:03 +0000
commitc14a82c781f8df50c4c5215ab92affdc60d72c01 (patch)
tree8b6d1d3773e1bfac45187539d668a8e2168cb1d7 /sound
parent822ad70a2f5c420da5baa9f4354e6b7813ca6da9 (diff)
downloadop-kernel-dev-c14a82c781f8df50c4c5215ab92affdc60d72c01.zip
op-kernel-dev-c14a82c781f8df50c4c5215ab92affdc60d72c01.tar.gz
ASoC: Intel: Skylake: Fix memory leak
If snd_soc_tplg_component_load() fails we just printed an error message and returned the error code but we missed releasing the firmware. Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org> Signed-off-by: Mark Brown <broonie@kernel.org>
Diffstat (limited to 'sound')
-rw-r--r--sound/soc/intel/skylake/skl-topology.c1
1 files changed, 1 insertions, 0 deletions
diff --git a/sound/soc/intel/skylake/skl-topology.c b/sound/soc/intel/skylake/skl-topology.c
index 5315b74..c7816d5 100644
--- a/sound/soc/intel/skylake/skl-topology.c
+++ b/sound/soc/intel/skylake/skl-topology.c
@@ -1511,6 +1511,7 @@ int skl_tplg_init(struct snd_soc_platform *platform, struct hdac_ext_bus *ebus)
release_firmware(fw);
if (ret < 0) {
dev_err(bus->dev, "tplg component load failed%d\n", ret);
+ release_firmware(fw);
return -EINVAL;
}
OpenPOWER on IntegriCloud