summaryrefslogtreecommitdiffstats
path: root/sound
diff options
context:
space:
mode:
authorDan Carpenter <error27@gmail.com>2011-06-20 10:11:25 +0300
committerMark Brown <broonie@opensource.wolfsonmicro.com>2011-06-20 18:46:33 +0100
commitc20974090e9093b8b69b37543cba381336c41ab7 (patch)
treed2170dfc919dd547cbf105b1e52b8dcdaa4615fd /sound
parent29376bc7e2bbb745c9ad47e48ca706ac5a24897f (diff)
downloadop-kernel-dev-c20974090e9093b8b69b37543cba381336c41ab7.zip
op-kernel-dev-c20974090e9093b8b69b37543cba381336c41ab7.tar.gz
ASoC: adau1701: signedness bug in adau1701_write()
"ret" is supposed to be signed here. The current code will only return -EIO on error, instead of a more appropriate error code such as -EAGAIN etc. Signed-off-by: Dan Carpenter <error27@gmail.com> Acked-by: Lars-Peter Clausen <lars@metafoo.de> Acked-by: Liam Girdwood <lrg@ti.com> Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
Diffstat (limited to 'sound')
-rw-r--r--sound/soc/codecs/adau1701.c3
1 files changed, 2 insertions, 1 deletions
diff --git a/sound/soc/codecs/adau1701.c b/sound/soc/codecs/adau1701.c
index 6c01bb6..2758d5f 100644
--- a/sound/soc/codecs/adau1701.c
+++ b/sound/soc/codecs/adau1701.c
@@ -140,9 +140,10 @@ static unsigned int adau1701_register_size(struct snd_soc_codec *codec,
static int adau1701_write(struct snd_soc_codec *codec, unsigned int reg,
unsigned int value)
{
- unsigned int i, ret;
+ unsigned int i;
unsigned int size;
uint8_t buf[4];
+ int ret;
size = adau1701_register_size(codec, reg);
if (size == 0)
OpenPOWER on IntegriCloud