diff options
| author | Takashi Iwai <tiwai@suse.de> | 2015-01-23 15:08:40 +0100 |
|---|---|---|
| committer | Takashi Iwai <tiwai@suse.de> | 2015-01-28 07:21:06 +0100 |
| commit | 9fb754b79e536eb35d69a4678687addff589e45b (patch) | |
| tree | 5cbe5201e93281325d61c9899759b72a3275ff52 /sound/usb/line6/pcm.c | |
| parent | f2a76225b962f00642002fb109aee2e5b0dc4259 (diff) | |
| download | op-kernel-dev-9fb754b79e536eb35d69a4678687addff589e45b.zip op-kernel-dev-9fb754b79e536eb35d69a4678687addff589e45b.tar.gz | |
ALSA: line6: Use incremental loop
Using a decremental loop without particular reasons worsens the
readability a lot. Use incremental loops instead.
Tested-by: Chris Rorvick <chris@rorvick.com>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Diffstat (limited to 'sound/usb/line6/pcm.c')
| -rw-r--r-- | sound/usb/line6/pcm.c | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/sound/usb/line6/pcm.c b/sound/usb/line6/pcm.c index adbcac4..43474c4 100644 --- a/sound/usb/line6/pcm.c +++ b/sound/usb/line6/pcm.c @@ -273,7 +273,7 @@ static int snd_line6_control_playback_get(struct snd_kcontrol *kcontrol, int i; struct snd_line6_pcm *line6pcm = snd_kcontrol_chip(kcontrol); - for (i = 2; i--;) + for (i = 0; i < 2; i++) ucontrol->value.integer.value[i] = line6pcm->volume_playback[i]; return 0; @@ -286,7 +286,7 @@ static int snd_line6_control_playback_put(struct snd_kcontrol *kcontrol, int i, changed = 0; struct snd_line6_pcm *line6pcm = snd_kcontrol_chip(kcontrol); - for (i = 2; i--;) + for (i = 0; i < 2; i++) if (line6pcm->volume_playback[i] != ucontrol->value.integer.value[i]) { line6pcm->volume_playback[i] = @@ -330,7 +330,7 @@ static void line6_cleanup_pcm(struct snd_pcm *pcm) int i; struct snd_line6_pcm *line6pcm = snd_pcm_chip(pcm); - for (i = LINE6_ISO_BUFFERS; i--;) { + for (i = 0; i < LINE6_ISO_BUFFERS; i++) { if (line6pcm->urb_audio_out[i]) { usb_kill_urb(line6pcm->urb_audio_out[i]); usb_free_urb(line6pcm->urb_audio_out[i]); |
