diff options
author | Thomas Gleixner <tglx@linutronix.de> | 2013-03-07 14:53:45 +0100 |
---|---|---|
committer | Thomas Gleixner <tglx@linutronix.de> | 2014-05-03 23:15:39 +0200 |
commit | 1e77d0a1ed7417d2a5a52a7b8d32aea1833faa6c (patch) | |
tree | 410c5ce4fea37cd802d0acfab51211398421d7c1 /sound/soc/codecs/tlv320aic3x.c | |
parent | 0384dcae2b18db80c49117ac57ea15211ca48751 (diff) | |
download | op-kernel-dev-1e77d0a1ed7417d2a5a52a7b8d32aea1833faa6c.zip op-kernel-dev-1e77d0a1ed7417d2a5a52a7b8d32aea1833faa6c.tar.gz |
genirq: Sanitize spurious interrupt detection of threaded irqs
Till reported that the spurious interrupt detection of threaded
interrupts is broken in two ways:
- note_interrupt() is called for each action thread of a shared
interrupt line. That's wrong as we are only interested whether none
of the device drivers felt responsible for the interrupt, but by
calling multiple times for a single interrupt line we account
IRQ_NONE even if one of the drivers felt responsible.
- note_interrupt() when called from the thread handler is not
serialized. That leaves the members of irq_desc which are used for
the spurious detection unprotected.
To solve this we need to defer the spurious detection of a threaded
interrupt to the next hardware interrupt context where we have
implicit serialization.
If note_interrupt is called with action_ret == IRQ_WAKE_THREAD, we
check whether the previous interrupt requested a deferred check. If
not, we request a deferred check for the next hardware interrupt and
return.
If set, we check whether one of the interrupt threads signaled
success. Depending on this information we feed the result into the
spurious detector.
If one primary handler of a shared interrupt returns IRQ_HANDLED we
disable the deferred check of irq threads on the same line, as we have
found at least one device driver who cared.
Reported-by: Till Straumann <strauman@slac.stanford.edu>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Tested-by: Austin Schuh <austin@peloton-tech.com>
Cc: Oliver Hartkopp <socketcan@hartkopp.net>
Cc: Wolfgang Grandegger <wg@grandegger.com>
Cc: Pavel Pisa <pisa@cmp.felk.cvut.cz>
Cc: Marc Kleine-Budde <mkl@pengutronix.de>
Cc: linux-can@vger.kernel.org
Cc: stable@vger.kernel.org
Link: http://lkml.kernel.org/r/alpine.LFD.2.02.1303071450130.22263@ionos
Diffstat (limited to 'sound/soc/codecs/tlv320aic3x.c')
0 files changed, 0 insertions, 0 deletions