summaryrefslogtreecommitdiffstats
path: root/sound/pci
diff options
context:
space:
mode:
authorTakashi Iwai <tiwai@suse.de>2016-03-10 12:02:49 +0100
committerTakashi Iwai <tiwai@suse.de>2016-03-10 12:02:49 +0100
commit4f8e4f3537cafc4de128e6bfdf83baa78bc60eb1 (patch)
tree4ebdd0a442536fc6ae3b76cac5aad98437f8915b /sound/pci
parent56dc66ff1c6d71f9a38c4a7c000b72b921fe4c89 (diff)
downloadop-kernel-dev-4f8e4f3537cafc4de128e6bfdf83baa78bc60eb1.zip
op-kernel-dev-4f8e4f3537cafc4de128e6bfdf83baa78bc60eb1.tar.gz
ALSA: hda - Don't handle ELD notify from invalid port
The current Intel HDMI codec driver supports only three fixed ports from port B to port D. However, i915 driver may assign a DP on other ports, e.g. port A, when no eDP is used. This incompatibility is caught later at pin_nid_to_pin_index() and results in a warning message like "HDMI: pin nid 4 not registered" at each time. This patch filters out such invalid events beforehand, so that the kernel won't be too grumbling. Reported-by: Stefan Assmann <sassmann@kpanic.de> Cc: <stable@vger.kernel.org> Signed-off-by: Takashi Iwai <tiwai@suse.de>
Diffstat (limited to 'sound/pci')
-rw-r--r--sound/pci/hda/patch_hdmi.c4
1 files changed, 4 insertions, 0 deletions
diff --git a/sound/pci/hda/patch_hdmi.c b/sound/pci/hda/patch_hdmi.c
index bcbc4ee..b90e4f3 100644
--- a/sound/pci/hda/patch_hdmi.c
+++ b/sound/pci/hda/patch_hdmi.c
@@ -2432,6 +2432,10 @@ static void intel_pin_eld_notify(void *audio_ptr, int port)
struct hda_codec *codec = audio_ptr;
int pin_nid = port + 0x04;
+ /* we assume only from port-B to port-D */
+ if (port < 1 || port > 3)
+ return;
+
/* skip notification during system suspend (but not in runtime PM);
* the state will be updated at resume
*/
OpenPOWER on IntegriCloud