diff options
author | Takashi Iwai <tiwai@suse.de> | 2009-03-02 10:44:15 +0100 |
---|---|---|
committer | Takashi Iwai <tiwai@suse.de> | 2009-03-02 10:44:15 +0100 |
commit | f93d461bcde6ac3db542361c00a7e4167f88176d (patch) | |
tree | b4a64791fc78adbce9f245093bf802f43094c1d6 /sound/pci/hda | |
parent | d1f1af2dbf8207db590853a59bec465c4f68cfdc (diff) | |
download | op-kernel-dev-f93d461bcde6ac3db542361c00a7e4167f88176d.zip op-kernel-dev-f93d461bcde6ac3db542361c00a7e4167f88176d.tar.gz |
ALSA: hda - Revert the codec probe at control-creation errors
Revert the codec probe instead of returning the error to the driver
when any error occurs at creating the control elements.
The control element conflict can be non-fatal in many cases,
especially if it comes from the digital-only codec.
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Diffstat (limited to 'sound/pci/hda')
-rw-r--r-- | sound/pci/hda/hda_codec.c | 14 |
1 files changed, 10 insertions, 4 deletions
diff --git a/sound/pci/hda/hda_codec.c b/sound/pci/hda/hda_codec.c index 3b44c78..1be34ed 100644 --- a/sound/pci/hda/hda_codec.c +++ b/sound/pci/hda/hda_codec.c @@ -1434,7 +1434,6 @@ int snd_hda_ctl_add(struct hda_codec *codec, struct snd_kcontrol *kctl) } EXPORT_SYMBOL_HDA(snd_hda_ctl_add); -#ifdef CONFIG_SND_HDA_RECONFIG /* Clear all controls assigned to the given codec */ void snd_hda_ctls_clear(struct hda_codec *codec) { @@ -1529,7 +1528,6 @@ int snd_hda_codec_reset(struct hda_codec *codec) hda_unlock_devices(card); return 0; } -#endif /* CONFIG_SND_HDA_RECONFIG */ /* create a virtual master control and add slaves */ int snd_hda_add_vmaster(struct hda_codec *codec, char *name, @@ -2392,8 +2390,16 @@ int /*__devinit*/ snd_hda_build_controls(struct hda_bus *bus) list_for_each_entry(codec, &bus->codec_list, list) { int err = snd_hda_codec_build_controls(codec); - if (err < 0) - return err; + if (err < 0) { + printk(KERN_ERR "hda_codec: cannot build controls" + "for #%d (error %d)\n", codec->addr, err); + err = snd_hda_codec_reset(codec); + if (err < 0) { + printk(KERN_ERR + "hda_codec: cannot revert codec\n"); + return err; + } + } } return 0; } |