summaryrefslogtreecommitdiffstats
path: root/sound/pci/asihpi/hpicmn.c
diff options
context:
space:
mode:
authorThomas Meyer <thomas@m3y3r.de>2011-11-29 22:08:00 +0100
committerTakashi Iwai <tiwai@suse.de>2011-12-06 13:27:32 +0100
commit6d2d4313690f2f81a9a54c6a0c8ae645c4598063 (patch)
tree43b545d2d4818deadb08fd3a4b214fe5ec41dd85 /sound/pci/asihpi/hpicmn.c
parent1d5d37f408e530ce1eab1deb66d2331535665ec7 (diff)
downloadop-kernel-dev-6d2d4313690f2f81a9a54c6a0c8ae645c4598063.zip
op-kernel-dev-6d2d4313690f2f81a9a54c6a0c8ae645c4598063.tar.gz
ALSA: asihp: Use kcalloc instead of kzalloc to allocate array
The advantage of kcalloc is, that will prevent integer overflows which could result from the multiplication of number of elements and size and it is also a bit nicer to read. The semantic patch that makes this change is available in https://lkml.org/lkml/2011/11/25/107 Signed-off-by: Thomas Meyer <thomas@m3y3r.de> Signed-off-by: Takashi Iwai <tiwai@suse.de>
Diffstat (limited to 'sound/pci/asihpi/hpicmn.c')
-rw-r--r--sound/pci/asihpi/hpicmn.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/sound/pci/asihpi/hpicmn.c b/sound/pci/asihpi/hpicmn.c
index bd47521..44c7eb4 100644
--- a/sound/pci/asihpi/hpicmn.c
+++ b/sound/pci/asihpi/hpicmn.c
@@ -631,7 +631,7 @@ struct hpi_control_cache *hpi_alloc_control_cache(const u32 control_count,
if (!p_cache)
return NULL;
- p_cache->p_info = kzalloc(sizeof(*p_cache->p_info) * control_count,
+ p_cache->p_info = kcalloc(control_count, sizeof(*p_cache->p_info),
GFP_KERNEL);
if (!p_cache->p_info) {
kfree(p_cache);
OpenPOWER on IntegriCloud