diff options
| author | Adrian Bunk <bunk@stusta.de> | 2006-03-13 14:14:10 +0100 |
|---|---|---|
| committer | Jaroslav Kysela <perex@suse.cz> | 2006-03-22 10:37:31 +0100 |
| commit | 3a63e44420932852efd6a7d6d46cdad4d427f880 (patch) | |
| tree | ccabe72933a23a2d8553d399128d7a35d4a21570 /sound/core | |
| parent | 646494007b48e8897888cd407c2b7d1d69cb2e58 (diff) | |
| download | op-kernel-dev-3a63e44420932852efd6a7d6d46cdad4d427f880.zip op-kernel-dev-3a63e44420932852efd6a7d6d46cdad4d427f880.tar.gz | |
[ALSA] sound/core/: fix 3 off-by-one errors
Modules: ALSA Core
This patch fixes three off-by-one errors found by the Coverity checker.
Signed-off-by: Adrian Bunk <bunk@stusta.de>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Diffstat (limited to 'sound/core')
| -rw-r--r-- | sound/core/sound.c | 4 | ||||
| -rw-r--r-- | sound/core/sound_oss.c | 2 |
2 files changed, 3 insertions, 3 deletions
diff --git a/sound/core/sound.c b/sound/core/sound.c index df4ab94..4d28e52 100644 --- a/sound/core/sound.c +++ b/sound/core/sound.c @@ -121,7 +121,7 @@ void *snd_lookup_minor_data(unsigned int minor, int type) struct snd_minor *mreg; void *private_data; - if (minor > ARRAY_SIZE(snd_minors)) + if (minor >= ARRAY_SIZE(snd_minors)) return NULL; mutex_lock(&sound_mutex); mreg = snd_minors[minor]; @@ -140,7 +140,7 @@ static int snd_open(struct inode *inode, struct file *file) struct file_operations *old_fops; int err = 0; - if (minor > ARRAY_SIZE(snd_minors)) + if (minor >= ARRAY_SIZE(snd_minors)) return -ENODEV; mptr = snd_minors[minor]; if (mptr == NULL) { diff --git a/sound/core/sound_oss.c b/sound/core/sound_oss.c index 6b4a4bc..4023d3b 100644 --- a/sound/core/sound_oss.c +++ b/sound/core/sound_oss.c @@ -46,7 +46,7 @@ void *snd_lookup_oss_minor_data(unsigned int minor, int type) struct snd_minor *mreg; void *private_data; - if (minor > ARRAY_SIZE(snd_oss_minors)) + if (minor >= ARRAY_SIZE(snd_oss_minors)) return NULL; mutex_lock(&sound_oss_mutex); mreg = snd_oss_minors[minor]; |
