summaryrefslogtreecommitdiffstats
path: root/sound/core
diff options
context:
space:
mode:
authorMariusz Kozlowski <m.kozlowski@tuxland.pl>2009-06-21 20:26:59 +0200
committerTakashi Iwai <tiwai@suse.de>2009-06-22 07:54:21 +0200
commit8bd9bca3c1a214350e2f2f1e2fd493ed24c06f7e (patch)
tree36b727c9c87a326fbd5ad1af4f1b2259532d2b0b /sound/core
parent4f64e150191bfddc7f5c0768f325f747dbca1913 (diff)
downloadop-kernel-dev-8bd9bca3c1a214350e2f2f1e2fd493ed24c06f7e.zip
op-kernel-dev-8bd9bca3c1a214350e2f2f1e2fd493ed24c06f7e.tar.gz
sound: fix check for return value in snd_pcm_hw_refine
'params' is a pointer and looking at the code this probably should be a check for ioctl return value. Signed-off-by: Mariusz Kozlowski <m.kozlowski@tuxland.pl> Signed-off-by: Takashi Iwai <tiwai@suse.de>
Diffstat (limited to 'sound/core')
-rw-r--r--sound/core/pcm_native.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/sound/core/pcm_native.c b/sound/core/pcm_native.c
index 84da3ba..ac2150e 100644
--- a/sound/core/pcm_native.c
+++ b/sound/core/pcm_native.c
@@ -320,7 +320,7 @@ int snd_pcm_hw_refine(struct snd_pcm_substream *substream,
snd_mask_max(&params->masks[SNDRV_PCM_HW_PARAM_CHANNELS])) {
changed = substream->ops->ioctl(substream,
SNDRV_PCM_IOCTL1_FIFO_SIZE, params);
- if (params < 0)
+ if (changed < 0)
return changed;
}
}
OpenPOWER on IntegriCloud