diff options
author | Rafael J. Wysocki <rafael.j.wysocki@intel.com> | 2013-11-14 23:18:32 +0100 |
---|---|---|
committer | Rafael J. Wysocki <rafael.j.wysocki@intel.com> | 2013-11-14 23:18:32 +0100 |
commit | a104b4d467d1c4a09727bac2816928aef3304d3a (patch) | |
tree | ef1e2b2b10825be4c49c0ff2689a292835cd8dd4 /security | |
parent | 3a83f992490f8235661b768e53bd5f14915420ac (diff) | |
download | op-kernel-dev-a104b4d467d1c4a09727bac2816928aef3304d3a.zip op-kernel-dev-a104b4d467d1c4a09727bac2816928aef3304d3a.tar.gz |
ACPI / bind: Use (put|get)_device() on ACPI device objects too
When associating a "physical" device with an ACPI device object
acpi_bind_one() only uses get_device() to increment the reference
counter of the former, but there is no reason not to do that with
the latter too. Among other things, that may help to avoid
use-after-free when an ACPI device object is freed without calling
acpi_unbind_one() for all "physical" devices associated with it
(that only can happen in buggy code, but then it's better if the
kernel doesn't crash as a result of a bug).
For this reason, modify acpi_bind_one() to apply get_device() to
the ACPI device object too and update acpi_unbind_one() to drop
that reference using put_device() as appropriate.
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Reviewed-by: Lan Tianyu <tianyu.lan@intel.com>
Diffstat (limited to 'security')
0 files changed, 0 insertions, 0 deletions