summaryrefslogtreecommitdiffstats
path: root/security
diff options
context:
space:
mode:
authorSergey Senozhatsky <sergey.senozhatsky.work@gmail.com>2017-09-26 15:25:10 +0900
committerRob Herring <robh@kernel.org>2017-10-12 12:22:04 -0500
commitdb179e0d0d1003f10b798e072524be6bcdae5053 (patch)
tree1fd0391e582a81d8a3a6d34872a4d0eed3a67118 /security
parent8a5776a5f49812d29fe4b2d0a2d71675c3facf3f (diff)
downloadop-kernel-dev-db179e0d0d1003f10b798e072524be6bcdae5053.zip
op-kernel-dev-db179e0d0d1003f10b798e072524be6bcdae5053.tar.gz
of: do not leak console options
Do not strdup() console options. It seems that the only reason for it to be strdup()-ed was a compilation warning: printk, UART and console drivers, for some reason, expect char pointer instead of const char pointer. So we can just pass `of_stdout_options', but need to cast it to char pointer. A better fix would be to change printk, console drivers and UART to accept const char `options'; but that will take time - there are lots of drivers to update. The patch also fixes a possible memory leak: add_preferred_console() can fail, but we don't kfree() options. Signed-off-by: Sergey Senozhatsky <sergey.senozhatsky@gmail.com> Reviewed-by: Petr Mladek <pmladek@suse.com> Signed-off-by: Rob Herring <robh@kernel.org>
Diffstat (limited to 'security')
0 files changed, 0 insertions, 0 deletions
OpenPOWER on IntegriCloud