summaryrefslogtreecommitdiffstats
path: root/security
diff options
context:
space:
mode:
authorAl Viro <viro@zeniv.linux.org.uk>2010-01-30 15:27:27 -0500
committerAl Viro <viro@zeniv.linux.org.uk>2010-03-03 14:07:56 -0500
commitde27a5bf9caef3f1fca1f315aa58eee54fbf929a (patch)
tree807ac88de94235afb40117b27d4400bd32573cea /security
parentf694869709cc39a5fbde21aa40f22999ddad0e6e (diff)
downloadop-kernel-dev-de27a5bf9caef3f1fca1f315aa58eee54fbf929a.zip
op-kernel-dev-de27a5bf9caef3f1fca1f315aa58eee54fbf929a.tar.gz
fix mnt_mountpoint abuse in smack
(mnt,mnt_mountpoint) pair is conceptually wrong; if you want to use it for generating pathname and for nothing else *and* if you know that vfsmount tree is unchanging, you can get away with that, but the right solution for that is (mnt,mnt_root). Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Diffstat (limited to 'security')
-rw-r--r--security/smack/smack_lsm.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/security/smack/smack_lsm.c b/security/smack/smack_lsm.c
index 529c9ca..8dffcb7 100644
--- a/security/smack/smack_lsm.c
+++ b/security/smack/smack_lsm.c
@@ -387,7 +387,7 @@ static int smack_sb_umount(struct vfsmount *mnt, int flags)
struct smk_audit_info ad;
smk_ad_init(&ad, __func__, LSM_AUDIT_DATA_FS);
- smk_ad_setfield_u_fs_path_dentry(&ad, mnt->mnt_mountpoint);
+ smk_ad_setfield_u_fs_path_dentry(&ad, mnt->mnt_root);
smk_ad_setfield_u_fs_path_mnt(&ad, mnt);
sbp = mnt->mnt_sb->s_security;
OpenPOWER on IntegriCloud