summaryrefslogtreecommitdiffstats
path: root/security
diff options
context:
space:
mode:
authorJulia Lawall <julia@diku.dk>2010-05-14 21:30:30 +0200
committerJames Morris <jmorris@namei.org>2010-05-17 09:00:27 +1000
commitb3139bbc52762268769e7af842aade0e64372433 (patch)
treeeae65d208fdbeaefd9bdc9c6877d8eb18e617bf6 /security
parent9e4b50e93786d00c703f16ed46e6a4029c0dfdd1 (diff)
downloadop-kernel-dev-b3139bbc52762268769e7af842aade0e64372433.zip
op-kernel-dev-b3139bbc52762268769e7af842aade0e64372433.tar.gz
security/selinux/ss: Use kstrdup
Use kstrdup when the goal of an allocation is copy a string into the allocated region. The semantic patch that makes this change is as follows: (http://coccinelle.lip6.fr/) // <smpl> @@ expression from,to; expression flag,E1,E2; statement S; @@ - to = kmalloc(strlen(from) + 1,flag); + to = kstrdup(from, flag); ... when != \(from = E1 \| to = E1 \) if (to==NULL || ...) S ... when != \(from = E2 \| to = E2 \) - strcpy(to, from); // </smpl> Signed-off-by: Julia Lawall <julia@diku.dk> Acked-by: Eric Paris <eparis@redhat.com> Signed-off-by: James Morris <jmorris@namei.org>
Diffstat (limited to 'security')
-rw-r--r--security/selinux/ss/policydb.c3
1 files changed, 1 insertions, 2 deletions
diff --git a/security/selinux/ss/policydb.c b/security/selinux/ss/policydb.c
index 4f584fb..c57802a 100644
--- a/security/selinux/ss/policydb.c
+++ b/security/selinux/ss/policydb.c
@@ -156,12 +156,11 @@ static int roles_init(struct policydb *p)
rc = -EINVAL;
goto out_free_role;
}
- key = kmalloc(strlen(OBJECT_R) + 1, GFP_KERNEL);
+ key = kstrdup(OBJECT_R, GFP_KERNEL);
if (!key) {
rc = -ENOMEM;
goto out_free_role;
}
- strcpy(key, OBJECT_R);
rc = hashtab_insert(p->p_roles.table, key, role);
if (rc)
goto out_free_key;
OpenPOWER on IntegriCloud