summaryrefslogtreecommitdiffstats
path: root/security/smack
diff options
context:
space:
mode:
authorPavel Emelyanov <xemul@openvz.org>2008-04-30 00:52:41 -0700
committerLinus Torvalds <torvalds@linux-foundation.org>2008-04-30 08:29:34 -0700
commit9e3bd6c3fb2334be171e69b432039cd18bce4458 (patch)
tree199963534d6379457d84e6f2ead2b104088182dd /security/smack
parentc5363d03637885310f1101b95cbbd26d067b4c8d (diff)
downloadop-kernel-dev-9e3bd6c3fb2334be171e69b432039cd18bce4458.zip
op-kernel-dev-9e3bd6c3fb2334be171e69b432039cd18bce4458.tar.gz
signals: consolidate send_sigqueue and send_group_sigqueue
Both functions do the same thing after proper locking, but with different sigpending structs, so move the common code into a helper. After this we have 4 places that look very similar: send_sigqueue: calls do_send_sigqueue and signal_wakeup send_group_sigqueue: calls do_send_sigqueue and __group_complete_signal __group_send_sig_info: calls send_signal and __group_complete_signal specific_send_sig_info: calls send_signal and signal_wakeup Besides, send_signal performs actions similar to do_send_sigqueue's and __group_complete_signal - to signal_wakeup. It looks like they can be consolidated gracefully. Oleg said: Personally, I think this change is very good. But send_sigqueue() and send_group_sigqueue() have a very subtle difference which I was never able to understand. Let's suppose that sigqueue is already queued, and the signal is ignored (the latter means we should re-schedule cpu timer or handle overrruns). In that case send_sigqueue() returns 0, but send_group_sigqueue() returns 1. I think this is not the problem (in fact, I think this patch makes the behaviour more correct), but I hope Thomas can take a look and confirm. Signed-off-by: Pavel Emelyanov <xemul@openvz.org> Cc: Oleg Nesterov <oleg@tv-sign.ru> Cc: Roland McGrath <roland@redhat.com> Cc: Thomas Gleixner <tglx@linutronix.de> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'security/smack')
0 files changed, 0 insertions, 0 deletions
OpenPOWER on IntegriCloud