summaryrefslogtreecommitdiffstats
path: root/scripts
diff options
context:
space:
mode:
authorYann Droneaud <ydroneaud@opteya.com>2016-05-23 17:07:21 +0200
committerMichal Marek <mmarek@suse.com>2016-06-21 11:43:32 +0200
commitb7b2ee41f300b69c67c798df0cd5b8648bcb26a3 (patch)
treebeec6c46f805fd36a2a9b0386adb7f9ea1da91a8 /scripts
parenta720c0644d14011d3a1bcc8d1b36e80571ad2ce1 (diff)
downloadop-kernel-dev-b7b2ee41f300b69c67c798df0cd5b8648bcb26a3.zip
op-kernel-dev-b7b2ee41f300b69c67c798df0cd5b8648bcb26a3.tar.gz
coccinelle: catch krealloc() on devm_*() allocated memory
krealloc() must not be used against devm_*() allocated memory regions: - if a bigger memory is to be allocated, krealloc() and __krealloc() could return a different pointer than the one given to them, creating a memory region which is not managed, thus it will not be automatically released on device removal. - if a bigger memory is to be allocated, krealloc() could kfree() the managed memory region which is passed to it. The old pointer is left registered as a resource for the device. On device removal, this dangling pointer will be used and an unrelated memory region could be released. - if the requested size is equal to 0, krealloc() can also just behave like kfree(). Here too, the old pointer is kept associated with the device. On device removal, this invalid pointer will be used and an unrelated memory region could be released. For all these reasons, krealloc() must not be used on a pointer returned by devm_*() functions. Cc: Tejun Heo <tj@kernel.org> Cc: Pekka Enberg <penberg@cs.helsinki.fi> Acked-by: Julia Lawall <julia.lawall@lip6.fr> Signed-off-by: Yann Droneaud <ydroneaud@opteya.com> Signed-off-by: Michal Marek <mmarek@suse.com>
Diffstat (limited to 'scripts')
-rw-r--r--scripts/coccinelle/free/devm_free.cocci4
1 files changed, 4 insertions, 0 deletions
diff --git a/scripts/coccinelle/free/devm_free.cocci b/scripts/coccinelle/free/devm_free.cocci
index 3794cd9..c990d2c 100644
--- a/scripts/coccinelle/free/devm_free.cocci
+++ b/scripts/coccinelle/free/devm_free.cocci
@@ -66,6 +66,10 @@ position p;
|
* kzfree@p(x)
|
+* __krealloc@p(x, ...)
+|
+* krealloc@p(x, ...)
+|
* free_pages@p(x, ...)
|
* free_page@p(x)
OpenPOWER on IntegriCloud