diff options
| author | Andy Whitcroft <apw@canonical.com> | 2009-01-06 14:41:29 -0800 |
|---|---|---|
| committer | Linus Torvalds <torvalds@linux-foundation.org> | 2009-01-06 15:59:17 -0800 |
| commit | 2b6db5cb65cb1276a7aa363a6e7335b0a8a68393 (patch) | |
| tree | 289e1048f76a56c551ef57aeb4adf54d4f9a3172 /scripts | |
| parent | b53c8e104ed071c47ada2adce194625ab03d9f3d (diff) | |
| download | op-kernel-dev-2b6db5cb65cb1276a7aa363a6e7335b0a8a68393.zip op-kernel-dev-2b6db5cb65cb1276a7aa363a6e7335b0a8a68393.tar.gz | |
checkpatch: struct file_operations should normally be const
In the general use case struct file_operations should be a const object.
Check for and warn where it is not. As suggested by Steven and Ingo.
Acked-by: Steven Rostedt <rostedt@goodmis.org>
Cc: Ingo Molnar <mingo@elte.hu>
Signed-off-by: Andy Whitcroft <apw@canonical.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'scripts')
| -rwxr-xr-x | scripts/checkpatch.pl | 5 |
1 files changed, 5 insertions, 0 deletions
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index c39ce0b..94371f6 100755 --- a/scripts/checkpatch.pl +++ b/scripts/checkpatch.pl @@ -2509,6 +2509,11 @@ sub process { if ($line =~ /^.\s*__initcall\s*\(/) { WARN("please use device_initcall() instead of __initcall()\n" . $herecurr); } +# check for struct file_operations, ensure they are const. + if ($line =~ /\bstruct\s+file_operations\b/ && + $line !~ /\bconst\b/) { + WARN("struct file_operations should normally be const\n" . $herecurr); + } # use of NR_CPUS is usually wrong # ignore definitions of NR_CPUS and usage to define arrays as likely right |
