summaryrefslogtreecommitdiffstats
path: root/scripts
diff options
context:
space:
mode:
authorMichal Nazarewicz <mina86@mina86.com>2014-07-27 07:27:01 +0930
committerRusty Russell <rusty@rustcorp.com.au>2014-07-27 20:52:45 +0930
commitfcd38ed0ff263156c3917c70c2fb0b7e91bfeab1 (patch)
treea0fef8e6a66ebf755af71069dd776b6a0a7d167b /scripts
parent37549e94c77a94a9c32b5ae3313a3801cb66adf9 (diff)
downloadop-kernel-dev-fcd38ed0ff263156c3917c70c2fb0b7e91bfeab1.zip
op-kernel-dev-fcd38ed0ff263156c3917c70c2fb0b7e91bfeab1.tar.gz
scripts: modpost: fix compilation warning
The scripts/mod/modpost.c triggers the following warning: scripts/mod/modpost.c: In function ‘remove_dot’: scripts/mod/modpost.c:1710:10: warning: ignoring return value of ‘strtoul’, declared with attribute warn_unused_result [-Wunused-result] The remove_dot function that calls strtoul does not care about the numeric value of the string that is parsed but only looks for the end of the numeric sequence. As such, it's equivalent to just skip over all digits. Signed-off-by: Michal Nazarewicz <mina86@mina86.com> Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Diffstat (limited to 'scripts')
-rw-r--r--scripts/mod/modpost.c9
1 files changed, 4 insertions, 5 deletions
diff --git a/scripts/mod/modpost.c b/scripts/mod/modpost.c
index 9d9c5b9..5ba203b 100644
--- a/scripts/mod/modpost.c
+++ b/scripts/mod/modpost.c
@@ -1703,12 +1703,11 @@ static void check_sec_ref(struct module *mod, const char *modname,
static char *remove_dot(char *s)
{
- char *end;
- int n = strcspn(s, ".");
+ size_t n = strcspn(s, ".");
- if (n > 0 && s[n] != 0) {
- strtoul(s + n + 1, &end, 10);
- if (end > s + n + 1 && (*end == '.' || *end == 0))
+ if (n && s[n]) {
+ size_t m = strspn(s + n + 1, "0123456789");
+ if (m && (s[n + m] == '.' || s[n + m] == 0))
s[n] = 0;
}
return s;
OpenPOWER on IntegriCloud